memory: da8xx-ddrctl: remove redundant dev_err call in da8xx_ddrctl_probe()
PATCH 1/1 memory: da8xx-ddrctl: remove redundant dev_err call in da8xx_ddrctl_probe()
From: Wei Yongjun <[email protected]>
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message.
Signed-off-by Wei Yongjun <[email protected]>
--- drivers/memory/da8xx-ddrctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/memory/da8xx-ddrctl.c +1 -3
@@ -122,10 +122,8 @@ static int da8xx_ddrctl_probe(struct platform_device *pdev) res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); ddrctl =devm_ioremap_resource (dev, res); -if (IS_ERR (ddrctl)) { -dev_err (dev,"unable to map memory controller registers\n" ); +if (IS_ERR (ddrctl))return PTR_ERR (ddrctl); - }for (; setting->name; setting++) { knob =da8xx_ddrctl_match_knob (setting);
2017-02-09 16:28 GMT+01:00 Wei Yongjun <[email protected]>:
Quoted 20 lines
From: Wei Yongjun <[email protected]>
There is a error message within
devm_ioremap_resourcealready, so remove thedev_errcall to avoid redundant error message.Signed-off-by Wei Yongjun <[email protected]>--- drivers/memory/da8xx-ddrctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/memory/da8xx-ddrctl.c +0
-0@@ -122,10 +122,8 @@ static int da8xx_ddrctl_probe(struct platform_device *pdev)
drivers/memory/da8xx-ddrctl.c static int da8xx_ddrctl_probe(struct platform_device *pdev) · line 129
Quoted 10 lines
drivers/memory/da8xx-ddrctl.c +1
-3res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); ddrctl =devm_ioremap_resource (dev, res); -if (IS_ERR (ddrctl)) { -dev_err (dev,"unable to map memory controller registers\n" ); +if (IS_ERR (ddrctl))return PTR_ERR (ddrctl); - }for (; setting->name; setting++) { knob =da8xx_ddrctl_match_knob (setting);