Skip to contentSkip to conversation

btrfs: remove unused ulist members

PATCH In review David Sterba 3 participants 3 messages Feb 9, 2017 – Feb 10, 2017 Btrfs file system

lore
Share & tools
lore

David Sterba

author maintainer
#0 lore raw

PATCH 1/1 btrfs: remove unused ulist members

Commit "btrfs: ulist: Add ulist_del() function" (d4b804045924d7f8) removed some debugging code but left the structure defintions.

Signed-off-by David Sterba <[email protected]>
---
 fs/btrfs/ulist.h | 7 -------
 1 file changed, 7 deletions(-)
fs/btrfs/ulist.h +0 -7
index a01a2c45825f..007b22fff3f9 100644
@@ -19,9 +19,6 @@
  *
  */
 struct ulist_iterator {
-#ifdef CONFIG_BTRFS_DEBUG
-	int i;
-#endif
 	struct list_head *cur_list;  /* hint to start search */
 };
 

@@ -32,10 +29,6 @@ struct ulist_node {
 	u64 val;		/* value to store */
 	u64 aux;		/* auxiliary value saved along with the val */
 
-#ifdef CONFIG_BTRFS_DEBUG
-	int seqnum;		/* sequence number this node is added */
-#endif
-
 	struct list_head list;  /* used to link node */
 	struct rb_node rb_node;	/* used to speed up search */
 };
Signature · 1 line
2.10.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · David Sterba

Commit "btrfs: ulist: Add ulist_del() function" (d4b804045924d7f8) removed some debugging code but left the structure defintions.

Signed-off-by David Sterba <[email protected]>

Thanks for deleting that, I forgot to remove the member in structure.

Reviewed-by Qu Wenruo <[email protected]>

Thanks,
Qu

Quoted 30 lines
---
 fs/btrfs/ulist.h | 7 -------
 1 file changed, 7 deletions(-)
fs/btrfs/ulist.h +0 -7
index a01a2c45825f..007b22fff3f9 100644
@@ -19,9 +19,6 @@
  *
  */
 struct ulist_iterator {
-#ifdef CONFIG_BTRFS_DEBUG
-	int i;
-#endif
 	struct list_head *cur_list;  /* hint to start search */
 };
 

@@ -32,10 +29,6 @@ struct ulist_node {
 	u64 val;		/* value to store */
 	u64 aux;		/* auxiliary value saved along with the val */
 
-#ifdef CONFIG_BTRFS_DEBUG
-	int seqnum;		/* sequence number this node is added */
-#endif
-
 	struct list_head list;  /* used to link node */
 	struct rb_node rb_node;	/* used to speed up search */
 };
Reviewed-by on v1 1/1
#2 lore raw
In reply to David Sterba
Quoted 3 lines · David Sterba

Commit "btrfs: ulist: Add ulist_del() function" (d4b804045924d7f8) removed some debugging code but left the structure defintions.

Reviewed-by Liu Bo <[email protected]>
Quoted 37 lines
Signed-off-by David Sterba <[email protected]>
---
 fs/btrfs/ulist.h | 7 -------
 1 file changed, 7 deletions(-)
fs/btrfs/ulist.h +0 -7
index a01a2c45825f..007b22fff3f9 100644
@@ -19,9 +19,6 @@
  *
  */
 struct ulist_iterator {
-#ifdef CONFIG_BTRFS_DEBUG
-	int i;
-#endif
 	struct list_head *cur_list;  /* hint to start search */
 };
 

@@ -32,10 +29,6 @@ struct ulist_node {
 	u64 val;		/* value to store */
 	u64 aux;		/* auxiliary value saved along with the val */
 
-#ifdef CONFIG_BTRFS_DEBUG
-	int seqnum;		/* sequence number this node is added */
-#endif
-
 	struct list_head list;  /* used to link node */
 	struct rb_node rb_node;	/* used to speed up search */
 };
Signature · 6 lines
2.10.1

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html