insane.bbclass: print QA message correctly

PATCH Superseded Stephano Cetola 2 participants 2 messages Feb 9, 2017 – Feb 10, 2017

lore

Share & tools

lore

Stephano Cetola

author

2017-02-09 16:02 UTC #0 lore raw

PATCH 1/1 insane.bbclass: print QA message correctly

When checking for ".debug" files, print QA message correctly.

Fixes [YOCTO #11014]

introduced in OE-core revision 1dcb38ca9d6

Signed-off-by Stephano Cetola <[email protected]>

---
 meta/classes/insane.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

meta/classes/insane.bbclass +1 -1

index 3cf86c12c3..ddd58d0875 100644
@@ -398,7 +398,7 @@ def package_qa_check_dbg(path, name, d, elf, messages):
 
     if not "-dbg" in name and not "-ptest" in name:
         if '.debug' in path.split(os.path.sep):
-            messages("debug-files", "non debug package contains .debug directory: %s path %s" % \
+            package_qa_add_message(messages, "debug-files", "non debug package contains .debug directory: %s path %s" % \
                      (name, package_qa_clean_path(path,d)))
 
 QAPATHTEST[perms] = "package_qa_check_perm"

Signature · 1 line

2.11.1

Christopher Larson

2017-02-10 16:31 UTC #1 lore raw

Quoted 8 lines · Stephano Cetola

When checking for ".debug" files, print QA message correctly.
Fixes [YOCTO #11014]
introduced in OE-core revision 1dcb38ca9d6
Signed-off-by Stephano Cetola <[email protected]>

Just a note that nowhere in this commit message does it actually say what the problem is. It’s now correct, so what was it doing before? It’s not ideal to have to go check the bug tracking system to find out exactly what problem a commit is fixing.

Signature · 4 lines

Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics