Skip to contentSkip to conversation

arm: am57xx: cl-som-am57x: fix XHCI registers base address

PATCH New Uri Mashiach 3 participants 8 messages Feb 9, 2017 – Feb 14, 2017 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/6 arm: am57xx: cl-som-am57x: fix XHCI registers base address

The following XHCI registers base address are set to OMAP5 values:
OMAP_XHCI_BASE, OMAP_OCP1_SCP_BASE, OMAP_OTG_WRAPPER_BASE

Captured crash for "usb start" command:
----------------------------------cut---------------------------------- => usb start
starting USB...
USB0: data abort

pc : [<fff63d22>]          lr : [<fff63b63>]

reloc pc : [<8081cd22>] lr : [<8081cb63>]
sp : fdf42d08 ip : fff9e040 fp : fdf42d50
r10: fff8a998 r9 : fdf42ef0 r8 : 00000000
r7 : fdf42d28 r6 : fdf42d2c r5 : fffa5c00 r4 : 00000000
r3 : 4a020000 r2 : 00000000 r1 : fdf42e78 r0 : fffa5c00
Flags: nzCv IRQs off FIQs off Mode SVC_32
Resetting CPU ...

resetting ... ----------------------------------cut----------------------------------

Fix by adding the CL-SOM-AM57x target to the XHCI registers base address ifdef'ery.
A better fix should be based on a SOC family defines (currently missing).

---
 include/linux/usb/xhci-omap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/usb/xhci-omap.h +1 -1
index 9de80d7..89665a0 100644
@@ -14,7 +14,7 @@
 #define OMAP_XHCI_BASE 0x488d0000
 #define OMAP_OCP1_SCP_BASE 0x4A081000
 #define OMAP_OTG_WRAPPER_BASE 0x488c0000
-#elif defined CONFIG_TARGET_AM57XX_EVM
+#elif defined(CONFIG_TARGET_AM57XX_EVM) || defined(CONFIG_TARGET_CL_SOM_AM57X)
 #define OMAP_XHCI_BASE 0x48890000
 #define OMAP_OCP1_SCP_BASE 0x4A084c00
 #define OMAP_OTG_WRAPPER_BASE 0x48880000
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/6 arm: am57xx: cl-som-am57x: fix XHCI registers base address

Quoted 17 lines · Uri Mashiach

The following XHCI registers base address are set to OMAP5 values:
OMAP_XHCI_BASE, OMAP_OCP1_SCP_BASE, OMAP_OTG_WRAPPER_BASE

Captured crash for "usb start" command:
----------------------------------cut---------------------------------- => usb start
starting USB...
USB0: data abort

pc : [<fff63d22>]          lr : [<fff63b63>]

reloc pc : [<8081cd22>] lr : [<8081cb63>]
sp : fdf42d08 ip : fff9e040 fp : fdf42d50
r10: fff8a998 r9 : fdf42ef0 r8 : 00000000
r7 : fdf42d28 r6 : fdf42d2c r5 : fffa5c00 r4 : 00000000
r3 : 4a020000 r2 : 00000000 r1 : fdf42e78 r0 : fffa5c00
Flags: nzCv IRQs off FIQs off Mode SVC_32
Resetting CPU ...

Quoted 7 lines

resetting ... ----------------------------------cut----------------------------------

Fix by adding the CL-SOM-AM57x target to the XHCI registers base address ifdef'ery.
A better fix should be based on a SOC family defines (currently missing).

Can you please go add the Kconfig symbols that would be the better solution please? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170209/9c259f4a/attachment.sig>
#2 lore raw

PATCH 1/6 arm: am57xx: cl-som-am57x: fix XHCI registers base address

Hi Tom,

Quoted 22 lines · Tom Rini
Quoted 20 lines · Uri Mashiach

The following XHCI registers base address are set to OMAP5 values:
OMAP_XHCI_BASE, OMAP_OCP1_SCP_BASE, OMAP_OTG_WRAPPER_BASE

Captured crash for "usb start" command:
----------------------------------cut---------------------------------- => usb start
starting USB...
USB0: data abort

pc : [<fff63d22>]          lr : [<fff63b63>]

reloc pc : [<8081cd22>] lr : [<8081cb63>]
sp : fdf42d08 ip : fff9e040 fp : fdf42d50
r10: fff8a998 r9 : fdf42ef0 r8 : 00000000
r7 : fdf42d28 r6 : fdf42d2c r5 : fffa5c00 r4 : 00000000
r3 : 4a020000 r2 : 00000000 r1 : fdf42e78 r0 : fffa5c00
Flags: nzCv IRQs off FIQs off Mode SVC_32
Resetting CPU ...

resetting ... ----------------------------------cut----------------------------------

Quoted 8 lines
Quoted 4 lines

Fix by adding the CL-SOM-AM57x target to the XHCI registers base address ifdef'ery.
A better fix should be based on a SOC family defines (currently missing).

Can you please go add the Kconfig symbols that would be the better solution please? Thanks!

The SOC family symbol CONFIG_AM57XX was removed by the commit 3891a54:
"ARM: DRA7x/AM57xx: Get rid of CONFIG_AM57XX".
Maybe the symbol should be reintroduced just for the XHCI registers section?

Signature · 2 lines
Thanks,
Uri
#3 lore raw

PATCH 1/6 arm: am57xx: cl-som-am57x: fix XHCI registers base address

Quoted 30 lines · Uri Mashiach

Hi Tom,

Quoted 27 lines · Tom Rini
Quoted 24 lines · Uri Mashiach

The following XHCI registers base address are set to OMAP5 values:
OMAP_XHCI_BASE, OMAP_OCP1_SCP_BASE, OMAP_OTG_WRAPPER_BASE

Captured crash for "usb start" command:
----------------------------------cut---------------------------------- => usb start
starting USB...
USB0: data abort

pc : [<fff63d22>]          lr : [<fff63b63>]

reloc pc : [<8081cd22>] lr : [<8081cb63>]
sp : fdf42d08 ip : fff9e040 fp : fdf42d50
r10: fff8a998 r9 : fdf42ef0 r8 : 00000000
r7 : fdf42d28 r6 : fdf42d2c r5 : fffa5c00 r4 : 00000000
r3 : 4a020000 r2 : 00000000 r1 : fdf42e78 r0 : fffa5c00
Flags: nzCv IRQs off FIQs off Mode SVC_32
Resetting CPU ...

resetting ... ----------------------------------cut----------------------------------

Fix by adding the CL-SOM-AM57x target to the XHCI registers base address ifdef'ery.
A better fix should be based on a SOC family defines (currently missing).

Quoted 7 lines
Quoted 2 lines

Can you please go add the Kconfig symbols that would be the better solution please? Thanks!

The SOC family symbol CONFIG_AM57XX was removed by the commit 3891a54: "ARM: DRA7x/AM57xx: Get rid of CONFIG_AM57XX". Maybe the symbol should be reintroduced just for the XHCI registers section?

Yes, sounds like we do have a case where DRA7xx is not the same as AM57xx then?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170212/034e49f5/attachment.sig>
#4 lore raw

PATCH 1/6 arm: am57xx: cl-som-am57x: fix XHCI registers base address

Quoted 34 lines · Tom Rini
Quoted 33 lines · Uri Mashiach

Hi Tom,

Quoted 29 lines · Tom Rini
Quoted 17 lines · Uri Mashiach

The following XHCI registers base address are set to OMAP5 values:
OMAP_XHCI_BASE, OMAP_OCP1_SCP_BASE, OMAP_OTG_WRAPPER_BASE

Captured crash for "usb start" command:
----------------------------------cut---------------------------------- => usb start
starting USB...
USB0: data abort

pc : [<fff63d22>]          lr : [<fff63b63>]

reloc pc : [<8081cd22>] lr : [<8081cb63>]
sp : fdf42d08 ip : fff9e040 fp : fdf42d50
r10: fff8a998 r9 : fdf42ef0 r8 : 00000000
r7 : fdf42d28 r6 : fdf42d2c r5 : fffa5c00 r4 : 00000000
r3 : 4a020000 r2 : 00000000 r1 : fdf42e78 r0 : fffa5c00
Flags: nzCv IRQs off FIQs off Mode SVC_32
Resetting CPU ...

Quoted 7 lines

resetting ... ----------------------------------cut----------------------------------

Fix by adding the CL-SOM-AM57x target to the XHCI registers base address ifdef'ery.
A better fix should be based on a SOC family defines (currently missing).

Can you please go add the Kconfig symbols that would be the better solution please? Thanks!

Quoted 8 lines
Quoted 4 lines

The SOC family symbol CONFIG_AM57XX was removed by the commit 3891a54: "ARM: DRA7x/AM57xx: Get rid of CONFIG_AM57XX". Maybe the symbol should be reintroduced just for the XHCI registers section?

Yes, sounds like we do have a case where DRA7xx is not the same as AM57xx then?

No that's not right. It is just DRA74x_EVM and AM57XX evm is using different instances of XHCI. Ideally this base address should be coming from DT. I don't think it is a good idea to introduce CONFIG_AM57XX.

Thanks and regards,
Lokesh

#5 lore raw

PATCH 1/6 arm: am57xx: cl-som-am57x: fix XHCI registers base address

Quoted 46 lines · Lokesh Vutla
Quoted 34 lines · Tom Rini
Quoted 33 lines · Uri Mashiach

Hi Tom,

Quoted 29 lines · Tom Rini
Quoted 17 lines · Uri Mashiach

The following XHCI registers base address are set to OMAP5 values:
OMAP_XHCI_BASE, OMAP_OCP1_SCP_BASE, OMAP_OTG_WRAPPER_BASE

Captured crash for "usb start" command:
----------------------------------cut---------------------------------- => usb start
starting USB...
USB0: data abort

pc : [<fff63d22>]          lr : [<fff63b63>]

reloc pc : [<8081cd22>] lr : [<8081cb63>]
sp : fdf42d08 ip : fff9e040 fp : fdf42d50
r10: fff8a998 r9 : fdf42ef0 r8 : 00000000
r7 : fdf42d28 r6 : fdf42d2c r5 : fffa5c00 r4 : 00000000
r3 : 4a020000 r2 : 00000000 r1 : fdf42e78 r0 : fffa5c00
Flags: nzCv IRQs off FIQs off Mode SVC_32
Resetting CPU ...

Quoted 7 lines

resetting ... ----------------------------------cut----------------------------------

Fix by adding the CL-SOM-AM57x target to the XHCI registers base address ifdef'ery.
A better fix should be based on a SOC family defines (currently missing).

Can you please go add the Kconfig symbols that would be the better solution please? Thanks!

Quoted 8 lines
Quoted 4 lines

The SOC family symbol CONFIG_AM57XX was removed by the commit 3891a54: "ARM: DRA7x/AM57xx: Get rid of CONFIG_AM57XX". Maybe the symbol should be reintroduced just for the XHCI registers section?

Yes, sounds like we do have a case where DRA7xx is not the same as AM57xx then?

Quoted 7 lines

No that's not right. It is just DRA74x_EVM and AM57XX evm is using different instances of XHCI. Ideally this base address should be coming from DT. I don't think it is a good idea to introduce CONFIG_AM57XX.

Thanks and regards,
Lokesh

It seems that the address of register is SOC dependent.
In the current method all the target boards that use the relevant SOC should be included in the ifdef'ery - redundant maintenance.

Signature · 2 lines
Regards,
Uri
#6 lore raw

PATCH 1/6 arm: am57xx: cl-som-am57x: fix XHCI registers base address

Quoted 56 lines · Uri Mashiach
Quoted 53 lines · Lokesh Vutla
Quoted 37 lines · Tom Rini
Quoted 36 lines · Uri Mashiach

Hi Tom,

Quoted 32 lines · Tom Rini
Quoted 22 lines · Uri Mashiach

The following XHCI registers base address are set to OMAP5 values:
OMAP_XHCI_BASE, OMAP_OCP1_SCP_BASE, OMAP_OTG_WRAPPER_BASE

Captured crash for "usb start" command:
----------------------------------cut----------------------------------

=> usb start
starting USB...
USB0: data abort

pc : [<fff63d22>]          lr : [<fff63b63>]

reloc pc : [<8081cd22>] lr : [<8081cb63>]
sp : fdf42d08 ip : fff9e040 fp : fdf42d50
r10: fff8a998 r9 : fdf42ef0 r8 : 00000000
r7 : fdf42d28 r6 : fdf42d2c r5 : fffa5c00 r4 : 00000000
r3 : 4a020000 r2 : 00000000 r1 : fdf42e78 r0 : fffa5c00
Flags: nzCv IRQs off FIQs off Mode SVC_32
Resetting CPU ...

resetting ... ----------------------------------cut----------------------------------

Quoted 5 lines

Fix by adding the CL-SOM-AM57x target to the XHCI registers base address
ifdef'ery.
A better fix should be based on a SOC family defines (currently missing).

Can you please go add the Kconfig symbols that would be the better solution please? Thanks!

Quoted 8 lines
Quoted 4 lines

The SOC family symbol CONFIG_AM57XX was removed by the commit 3891a54: "ARM: DRA7x/AM57xx: Get rid of CONFIG_AM57XX". Maybe the symbol should be reintroduced just for the XHCI registers section?

Yes, sounds like we do have a case where DRA7xx is not the same as AM57xx then?

No that's not right. It is just DRA74x_EVM and AM57XX evm is using different instances of XHCI. Ideally this base address should be coming from DT. I don't think it is a good idea to introduce CONFIG_AM57XX.

Quoted 6 lines
Quoted 3 lines

Thanks and regards,
Lokesh

It seems that the address of register is SOC dependent.
In the current method all the target boards that use the relevant SOC should be included in the ifdef'ery - redundant maintenance.

Please have a look at the TRMs. DRA7xx[1], AM57xx[2]. Both has the above two instances of XHCI. There is no difference.

[1] http://www.ti.com/lit/ug/sprui30b/sprui30b.pdf
[2] http://www.ti.com/lit/ug/spruhz6h/spruhz6h.pdf

Thanks and regards,
Lokesh

Quoted 1 line
#7 lore raw

PATCH 1/6 arm: am57xx: cl-som-am57x: fix XHCI registers base address

Quoted 66 lines · Lokesh Vutla
Quoted 56 lines · Uri Mashiach
Quoted 53 lines · Lokesh Vutla
Quoted 37 lines · Tom Rini
Quoted 36 lines · Uri Mashiach

Hi Tom,

Quoted 32 lines · Tom Rini
Quoted 22 lines · Uri Mashiach

The following XHCI registers base address are set to OMAP5 values:
OMAP_XHCI_BASE, OMAP_OCP1_SCP_BASE, OMAP_OTG_WRAPPER_BASE

Captured crash for "usb start" command:
----------------------------------cut----------------------------------

=> usb start
starting USB...
USB0: data abort

pc : [<fff63d22>]          lr : [<fff63b63>]

reloc pc : [<8081cd22>] lr : [<8081cb63>]
sp : fdf42d08 ip : fff9e040 fp : fdf42d50
r10: fff8a998 r9 : fdf42ef0 r8 : 00000000
r7 : fdf42d28 r6 : fdf42d2c r5 : fffa5c00 r4 : 00000000
r3 : 4a020000 r2 : 00000000 r1 : fdf42e78 r0 : fffa5c00
Flags: nzCv IRQs off FIQs off Mode SVC_32
Resetting CPU ...

resetting ... ----------------------------------cut----------------------------------

Quoted 5 lines

Fix by adding the CL-SOM-AM57x target to the XHCI registers base address
ifdef'ery.
A better fix should be based on a SOC family defines (currently missing).

Can you please go add the Kconfig symbols that would be the better solution please? Thanks!

Quoted 8 lines
Quoted 4 lines

The SOC family symbol CONFIG_AM57XX was removed by the commit 3891a54: "ARM: DRA7x/AM57xx: Get rid of CONFIG_AM57XX". Maybe the symbol should be reintroduced just for the XHCI registers section?

Yes, sounds like we do have a case where DRA7xx is not the same as AM57xx then?

No that's not right. It is just DRA74x_EVM and AM57XX evm is using different instances of XHCI. Ideally this base address should be coming from DT. I don't think it is a good idea to introduce CONFIG_AM57XX.

Quoted 6 lines
Quoted 3 lines

Thanks and regards,
Lokesh

It seems that the address of register is SOC dependent.
In the current method all the target boards that use the relevant SOC should be included in the ifdef'ery - redundant maintenance.

Quoted 9 lines

Please have a look at the TRMs. DRA7xx[1], AM57xx[2]. Both has the above two instances of XHCI. There is no difference.

[1] http://www.ti.com/lit/ug/sprui30b/sprui30b.pdf
[2] http://www.ti.com/lit/ug/spruhz6h/spruhz6h.pdf

Thanks and regards,
Lokesh

The fact that the two SOCs share the same registers base doesn't contradict the approach of selecting the registers based on the SOC.

I agree that the resolution should be higher. The exact SOC id (CONFIG_AM572X, CONFIG_DRA74X, CONFIG_DRA75X...) should be determined by the target selection - board file or Kconfig.

The ifdef'ery should include the exact SOCs id. According to the provided TRMs, CONFIG_AM572X and CONFIG_DRA74X will be located in the same ifdef'ery case.

Signature · 2 lines
Regards,
Uri