Skip to contentSkip to conversation

x86: Clean up a tiny description mistake in kernel ld script

PATCH Superseded Baoquan He 2 participants 4 messages Feb 2, 2017 – Feb 10, 2017 x86

lore
Share & tools
lore

Baoquan He

author
#0 lore raw

PATCH 1/1 x86: Clean up a tiny description mistake in kernel ld script

Remove the redundent word "is".

---
 arch/x86/kernel/vmlinux.lds.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/vmlinux.lds.S +2 -2
index e79f15f..f8f56b9 100644
@@ -8,8 +8,8 @@
  *
  *
  * Don't define absolute symbols until and unless you know that symbol
- * value is should remain constant even if kernel image is relocated
- * at run time. Absolute symbols are not relocated. If symbol value should
+ * value should remain constant even if kernel image is relocated at
+ * run time. Absolute symbols are not relocated. If symbol value should
  * change if kernel is relocated, make the symbol section relative and
  * put it inside the section definition.
  */
Signature · 1 line
2.5.5
#1 lore raw
Quoted 12 lines · Baoquan He

Remove the redundent word "is".

---
 arch/x86/kernel/vmlinux.lds.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/vmlinux.lds.S +0 -0
index e79f15f..f8f56b9 100644

arch/x86/kernel/vmlinux.lds.S line 11

Quoted 6 lines
arch/x86/kernel/vmlinux.lds.S +1 -2
@@ -8,8 +8,8 @@
  *
  *
  * Don't define absolute symbols until and unless you know that symbol
- * value is should remain constant even if kernel image is relocated
- * at run time. Absolute symbols are not relocated. If symbol value should
+ * value should remain constant even if kernel image is relocated at

And while at it we could make it a proper sentence:

... you know that the symbol value should .... even if the kernel ....

arch/x86/kernel/vmlinux.lds.S line 12

Quoted 1 line
arch/x86/kernel/vmlinux.lds.S +1 -0
+ * run time. Absolute symbols are not relocated. If symbol value should

If the symbol value ...

arch/x86/kernel/vmlinux.lds.S line 13

Quoted 1 line
arch/x86/kernel/vmlinux.lds.S +0 -0
  * change if kernel is relocated, make the symbol section relative and

if the kernel

Quoted 6 lines
arch/x86/kernel/vmlinux.lds.S +0 -0
  * put it inside the section definition.
  */
Signature · 1 line
2.5.5
author
#2 lore raw

PATCH v2 1/1 x86: Clean up a tiny description mistake in kernel ld script

Remove the redundent word "is". And add several missing definite article 'the'.

---
 arch/x86/kernel/vmlinux.lds.S | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/x86/kernel/vmlinux.lds.S +4 -4
index e79f15f..44d7eaa 100644
@@ -7,10 +7,10 @@
  *   Copyright (C) 2007-2009  Sam Ravnborg <[email protected]>
  *
  *
- * Don't define absolute symbols until and unless you know that symbol
- * value is should remain constant even if kernel image is relocated
- * at run time. Absolute symbols are not relocated. If symbol value should
- * change if kernel is relocated, make the symbol section relative and
+ * Don't define absolute symbols until and unless you know that the symbol
+ * value should remain constant even if the kernel image is relocated at
+ * run time. Absolute symbols are not relocated. If the symbol value should
+ * change if the kernel is relocated, make the symbol section relative and
  * put it inside the section definition.
  */
 
Signature · 1 line
2.5.5
author
#3 lore raw
In reply to Thomas Gleixner
Quoted 25 lines · Thomas Gleixner
Quoted 12 lines · Baoquan He

Remove the redundent word "is".

---
 arch/x86/kernel/vmlinux.lds.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/vmlinux.lds.S +0 -0
index e79f15f..f8f56b9 100644

arch/x86/kernel/vmlinux.lds.S line 11

Quoted 6 lines
arch/x86/kernel/vmlinux.lds.S +1 -2
@@ -8,8 +8,8 @@
  *
  *
  * Don't define absolute symbols until and unless you know that symbol
- * value is should remain constant even if kernel image is relocated
- * at run time. Absolute symbols are not relocated. If symbol value should
+ * value should remain constant even if kernel image is relocated at

And while at it we could make it a proper sentence:

... you know that the symbol value should .... even if the kernel ....

Quoted 7 lines

arch/x86/kernel/vmlinux.lds.S line 12

Quoted 1 line
arch/x86/kernel/vmlinux.lds.S +1 -0
+ * run time. Absolute symbols are not relocated. If symbol value should

If the symbol value ...

arch/x86/kernel/vmlinux.lds.S line 13

Quoted 1 line
arch/x86/kernel/vmlinux.lds.S +0 -0
  * change if kernel is relocated, make the symbol section relative and

if the kernel

Yes, I missed these, let me post v2. Thanks!

Quoted 7 lines
Quoted 7 lines
arch/x86/kernel/vmlinux.lds.S +0 -0
  * put it inside the section definition.
  */
Signature · 1 line
2.5.5