Skip to contentSkip to conversation

vmbus: remove per channel state

PATCH Greg KH 3 participants 4 messages Feb 10, 2017 – Feb 12, 2017 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author
#2 lore raw
Quoted 9 lines · On Sun, Feb 05, 2017 at 05:20:35PM -0700, [email protected] wrote:

From: Stephen Hemminger <[email protected]>

The netvsc no longer needs per channel state hook to track receive buffer.

---
 include/linux/hyperv.h |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

This patch breaks the build badly, I don't know how it passed anyone's build tests :(

The functions are still used in two different files.

I've applied the first 4 patches here, but really, I shouldn't have had to bisect down to the offending patch.

ugh.

greg k-h

#3 lore raw

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Friday, February 10, 2017 6:47 AM
To: KY Srinivasan <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Stephen Hemminger <[email protected]>; Stephen Hemminger <[email protected]>
Subject: Re: [PATCH 05/13] vmbus: remove per channel state

Quoted 9 lines · On Sun, Feb 05, 2017 at 05:20:35PM -0700, [email protected] wrote:

From: Stephen Hemminger <[email protected]>

The netvsc no longer needs per channel state hook to track receive buffer.

---
 include/linux/hyperv.h |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

This patch breaks the build badly, I don't know how it passed anyone's build tests :(

The functions are still used in two different files.

I've applied the first 4 patches here, but really, I shouldn't have had to bisect down to the offending patch.

ugh.

greg k-h

In the set I submitted was the patch to remove usage of per channel state in netvsc. KY dropped it, because it already is in net-next. So this patch can wait until net-next is merged. The current split tree process is a pain and causes slow development cycles

author
#4 lore raw
Quoted 1 line · Stephen Hemminger

In the set I submitted was the patch to remove usage of per channel state in netvsc.

Ah.

Quoted 2 lines

KY dropped it, because it already is in net-next. So this patch can wait until net-next is merged. The current split tree process is a pain and causes slow development cycles

Ick, I offered up a way to do this, but it doesn't look like KY or anyone else took me up on it :(

sorry,

greg k-h

#5 lore raw
In reply to Stephen Hemminger
Quoted 46 lines

-----Original Message-----
From: Stephen Hemminger
Sent: Friday, February 10, 2017 8:39 AM
To: Greg KH <[email protected]>; KY Srinivasan <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Stephen Hemminger <[email protected]>
Subject: RE: [PATCH 05/13] vmbus: remove per channel state

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Friday, February 10, 2017 6:47 AM
To: KY Srinivasan <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Stephen Hemminger <[email protected]>; Stephen Hemminger <[email protected]>
Subject: Re: [PATCH 05/13] vmbus: remove per channel state

Quoted 9 lines · On Sun, Feb 05, 2017 at 05:20:35PM -0700, [email protected] wrote:

From: Stephen Hemminger <[email protected]>

The netvsc no longer needs per channel state hook to track receive buffer.

---
 include/linux/hyperv.h |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

This patch breaks the build badly, I don't know how it passed anyone's build tests :(

The functions are still used in two different files.

I've applied the first 4 patches here, but really, I shouldn't have had to bisect down to the offending patch.

ugh.

Quoted 7 lines

greg k-h

In the set I submitted was the patch to remove usage of per channel state in netvsc.
KY dropped it, because it already is in net-next. So this patch can wait until net-next is merged.
The current split tree process is a pain and causes slow development cycles

Greg,

Sorry for the confusion; I will be resending the rest of the patches.

Thanks,

K. Y