regulator: tps65086: Fix expected switch DT node names
PATCH 1/2 regulator: tps65086: Fix expected switch DT node names
The three load switches are called SWA1, SWB1, and SWB2. The node names describing properties for these are expected to be the same, but due to a typo they are not. Fix this here.
Fixes d2a2e729a666 ("regulator: tps65086: Add regulator driver for the TPS65086 PMIC")
Reported-by Steven Kipisz <[email protected]>
Signed-off-by Andrew F. Davis <[email protected]>
Tested-by Steven Kipisz <[email protected]>
--- drivers/regulator/tps65086-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/tps65086-regulator.c +2 -2
@@ -157,8 +157,8 @@ static struct tps65086_regulator regulators[] = { VDOA23_VID_MASK, TPS65086_LDOA3CTRL, BIT(0), tps65086_ldoa23_ranges, 0, 0),TPS65086_SWITCH ("SWA1" ,"swa1" ,SWA1 ,TPS65086_SWVTT_EN ,BIT (5 )), -TPS65086_SWITCH ("SWB1" ,"swa2" ,SWB1 ,TPS65086_SWVTT_EN ,BIT (6 )), -TPS65086_SWITCH ("SWB2" ,"swa3" ,SWB2 ,TPS65086_SWVTT_EN ,BIT (7 )), +TPS65086_SWITCH ("SWB1" ,"swb1" ,SWB1 ,TPS65086_SWVTT_EN ,BIT (6 )), +TPS65086_SWITCH ("SWB2" ,"swb2" ,SWB2 ,TPS65086_SWVTT_EN ,BIT (7 )), TPS65086_SWITCH("VTT", "vtt", VTT, TPS65086_SWVTT_EN, BIT(4)), };
Signature · 1 line
2.11.0
PATCH 2/2 regulator: tps65086: Fix DT node referencing in of_parse_cb
When we check for additional DT properties in the current node we use the device_node passed in with the configuration data, this will not point to the correct DT node, use the one passed in for this purpose.
Fixes d2a2e729a666 ("regulator: tps65086: Add regulator driver for the TPS65086 PMIC")
Reported-by Steven Kipisz <[email protected]>
Signed-off-by Andrew F. Davis <[email protected]>
Tested-by Steven Kipisz <[email protected]>
--- drivers/regulator/tps65086-regulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/regulator/tps65086-regulator.c +3 -3
@@ -162,14 +162,14 @@ static struct tps65086_regulator regulators[] = { TPS65086_SWITCH("VTT", "vtt", VTT, TPS65086_SWVTT_EN, BIT(4)), }; -static int tps65086_of_parse_cb (struct device_node *dev, +static int tps65086_of_parse_cb (struct device_node *node,const struct regulator_desc *desc,struct regulator_config *config) {int ret;/* Check for 25mV step mode */ -if (of_property_read_bool (config->of_node,"ti,regulator-step-size-25mv" )) { +if (of_property_read_bool (node,"ti,regulator-step-size-25mv" )) {switch (desc->id) {case BUCK1 :case BUCK2 :
@@ -193,7 +193,7 @@ static int tps65086_of_parse_cb(struct device_node *dev, }/* Check for decay mode */ -if (desc->id <=BUCK6 &&of_property_read_bool (config->of_node,"ti,regulator-decay" )) { +if (desc->id <=BUCK6 &&of_property_read_bool (node,"ti,regulator-decay" )) { ret = regmap_write_bits(config->regmap, regulators[desc->id].decay_reg, regulators[desc->id].decay_mask,
Signature · 1 line
2.11.0