Skip to contentSkip to conversation

classpath: bump to version 0.99

PATCH Superseded Marcus Hoffmann 3 participants 13 messages Feb 12, 2017 – Feb 13, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 classpath: bump to version 0.99

Drop both patches since they are included upstream. We don't need to autoreconf now.

Note: classpath 0.99 has a bug in it's autoconf scripts, such that configure always fails when specifying --disable-tools[1]. We enable these for now.

Also explicitly disable GJDoc generation, as this defaults to on now.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70660

---
 package/classpath/0001-fix-gmp-include.patch  |  46 --
 package/classpath/0002-add-config-rpath.patch | 680 --------------------------
 package/classpath/classpath.hash              |   2 +-
 package/classpath/classpath.mk                |   7 +-
 4 files changed, 4 insertions(+), 731 deletions(-)
 delete mode 100644 package/classpath/0001-fix-gmp-include.patch
 delete mode 100644 package/classpath/0002-add-config-rpath.patch
package/classpath/0001-fix-gmp-include.patch deleted +0 -46
deleted file mode 100644
index f7a3920..0000000
@@ -1,46 +0,0 @@
-The GMP include is hardcoded to /usr/include causing obvious problems.
-
-From classpath CVS:
-http://cvs.savannah.gnu.org/viewvc/classpath/configure.ac?root=classpath&r1=1.245&r2=1.246
-
-[Gustavo: ditch -L or libtool complains loudly]
-
-Signed-off-by: Gustavo Zacarias <[email protected]>
-
---- a/configure.ac	2010/01/30 01:33:50	1.245
-+++ b/configure.ac	2010/05/04 12:29:23	1.246
-@@ -752,10 +752,32 @@
-   dnl __gmpz_mul_si for earlier versions (>= 3.1).
-   dnl IMPORTANT: if you decide to look for __gmpz_combit, don't forget to
-   dnl change the name of the corresponding ac_ variable on lines 860...
-+  AC_ARG_WITH(gmp, [  --with-gmp=PATH         specify prefix directory for the installed GMP package.
-+                          Equivalent to --with-gmp-include=PATH/include
-+                          plus --with-gmp-lib=PATH/lib])
-+  AC_ARG_WITH(gmp_include, [  --with-gmp-include=PATH specify directory for installed GMP include files])
-+  AC_ARG_WITH(gmp_lib, [  --with-gmp-lib=PATH     specify directory for the installed GMP library])
-+
-   if test "x${COMPILE_GMP}" = xyes; then
-+    AC_MSG_CHECKING([for GMP directories])
-+    if test "x$with_gmp" != x; then
-+       gmplibs="-lgmp"
-+       gmpinc="-I$with_gmp/include"
-+       if test "x$with_gmp_include" != x; then
-+       	  gmpinc="-I$with_gmp_include $gmpinc"
-+       fi
-+       if test "x$with_gmp_lib" != x; then
-+       	  gmplibs="$gmplibs"
-+       fi
-+    else
-+        with_gmp="/usr"
-+	gmplibs="-lgmp"
-+    	gmpinc="-I/usr/include"
-+    fi
-+    AC_MSG_RESULT([prefix=$with_gmp, libs=$gmplibs, inc=$gmpinc])
-     AC_CHECK_LIB(gmp, __gmpz_mul_si,
--      [GMP_CFLAGS=-I/usr/include
--       GMP_LIBS=-lgmp ],
-+      [GMP_CFLAGS="$gmpinc"
-+       GMP_LIBS="$gmplibs" ],
-       [GMP_CFLAGS=
-        GMP_LIBS= ])
-     AC_SUBST(GMP_CFLAGS)
package/classpath/0002-add-config-rpath.patch deleted +0 -680

680 lines not on this page · raw message

package/classpath/classpath.hash +1 -1
index 25d3e8c..8ee0ab4 100644
@@ -1,2 +1,2 @@
 # From http://www.gnu.org/software/classpath/announce/20090205.html
-sha1	1d6e8d1b3542a35bbd1013c61fab3cfae083decb	classpath-0.98.tar.gz
+sha256	f929297f8ae9b613a1a167e231566861893260651d913ad9b6c11933895fecc8	classpath-0.99.tar.gz
package/classpath/classpath.mk +3 -4
index 3825c76..97b7f0d 100644
@@ -4,21 +4,20 @@
 #
 ################################################################################
 
-CLASSPATH_VERSION = 0.98
+CLASSPATH_VERSION = 0.99
 CLASSPATH_SITE = $(BR2_GNU_MIRROR)/classpath
 CLASSPATH_CONF_OPTS = \
 	--disable-examples \
-	--disable-plugin \
 	--disable-rpath \
 	--disable-Werror \
 	--disable-gconf-peer \
-	--disable-tools
+	--disable-gjdoc
+	--enable-tools
 
 # classpath assumes qt runs on top of X11, but we
 # don't support qt4 on X11
 CLASSPATH_CONF_OPTS += --disable-qt-peer
 CLASSPATH_DEPENDENCIES = host-pkgconf
-CLASSPATH_AUTORECONF = YES
 CLASSPATH_LICENSE = GPLv2+ with exception
 CLASSPATH_LICENSE_FILES = COPYING
 
Signature · 1 line
2.9.3
#1 lore raw

PATCH v2 1/1 classpath: bump to version 0.99

Drop both patches since they are included upstream. We don't need to autoreconf now.

Note: classpath 0.99 has a bug in it's autoconf scripts, such that configure always fails when specifying --disable-tools[1]. We enable these for now.

Also explicitly disable GJDoc generation, as this defaults to on now.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70660

---
Changes v1 -> v2:
- Fixed announcement url in .hash file

 package/classpath/0001-fix-gmp-include.patch  |  46 --
 package/classpath/0002-add-config-rpath.patch | 680 --------------------------
 package/classpath/classpath.hash              |   2 +-
 package/classpath/classpath.mk                |   7 +-
 4 files changed, 4 insertions(+), 731 deletions(-)
 delete mode 100644 package/classpath/0001-fix-gmp-include.patch
 delete mode 100644 package/classpath/0002-add-config-rpath.patch
package/classpath/0001-fix-gmp-include.patch deleted +0 -46
deleted file mode 100644
index f7a3920..0000000
@@ -1,46 +0,0 @@
-The GMP include is hardcoded to /usr/include causing obvious problems.
-
-From classpath CVS:
-http://cvs.savannah.gnu.org/viewvc/classpath/configure.ac?root=classpath&r1=1.245&r2=1.246
-
-[Gustavo: ditch -L or libtool complains loudly]
-
-Signed-off-by: Gustavo Zacarias <[email protected]>
-
---- a/configure.ac	2010/01/30 01:33:50	1.245
-+++ b/configure.ac	2010/05/04 12:29:23	1.246
-@@ -752,10 +752,32 @@
-   dnl __gmpz_mul_si for earlier versions (>= 3.1).
-   dnl IMPORTANT: if you decide to look for __gmpz_combit, don't forget to
-   dnl change the name of the corresponding ac_ variable on lines 860...
-+  AC_ARG_WITH(gmp, [  --with-gmp=PATH         specify prefix directory for the installed GMP package.
-+                          Equivalent to --with-gmp-include=PATH/include
-+                          plus --with-gmp-lib=PATH/lib])
-+  AC_ARG_WITH(gmp_include, [  --with-gmp-include=PATH specify directory for installed GMP include files])
-+  AC_ARG_WITH(gmp_lib, [  --with-gmp-lib=PATH     specify directory for the installed GMP library])
-+
-   if test "x${COMPILE_GMP}" = xyes; then
-+    AC_MSG_CHECKING([for GMP directories])
-+    if test "x$with_gmp" != x; then
-+       gmplibs="-lgmp"
-+       gmpinc="-I$with_gmp/include"
-+       if test "x$with_gmp_include" != x; then
-+       	  gmpinc="-I$with_gmp_include $gmpinc"
-+       fi
-+       if test "x$with_gmp_lib" != x; then
-+       	  gmplibs="$gmplibs"
-+       fi
-+    else
-+        with_gmp="/usr"
-+	gmplibs="-lgmp"
-+    	gmpinc="-I/usr/include"
-+    fi
-+    AC_MSG_RESULT([prefix=$with_gmp, libs=$gmplibs, inc=$gmpinc])
-     AC_CHECK_LIB(gmp, __gmpz_mul_si,
--      [GMP_CFLAGS=-I/usr/include
--       GMP_LIBS=-lgmp ],
-+      [GMP_CFLAGS="$gmpinc"
-+       GMP_LIBS="$gmplibs" ],
-       [GMP_CFLAGS=
-        GMP_LIBS= ])
-     AC_SUBST(GMP_CFLAGS)
package/classpath/0002-add-config-rpath.patch deleted +0 -680

680 lines not on this page · raw message

package/classpath/classpath.hash +1 -1
index 25d3e8c..8ee0ab4 100644
@@ -1,2 +1,2 @@
 # From http://www.gnu.org/software/classpath/announce/20090205.html
-sha1	1d6e8d1b3542a35bbd1013c61fab3cfae083decb	classpath-0.98.tar.gz
+sha256	f929297f8ae9b613a1a167e231566861893260651d913ad9b6c11933895fecc8	classpath-0.99.tar.gz
package/classpath/classpath.mk +3 -4
index 3825c76..97b7f0d 100644
@@ -4,21 +4,20 @@
 #
 ################################################################################
 
-CLASSPATH_VERSION = 0.98
+CLASSPATH_VERSION = 0.99
 CLASSPATH_SITE = $(BR2_GNU_MIRROR)/classpath
 CLASSPATH_CONF_OPTS = \
 	--disable-examples \
-	--disable-plugin \
 	--disable-rpath \
 	--disable-Werror \
 	--disable-gconf-peer \
-	--disable-tools
+	--disable-gjdoc
+	--enable-tools
 
 # classpath assumes qt runs on top of X11, but we
 # don't support qt4 on X11
 CLASSPATH_CONF_OPTS += --disable-qt-peer
 CLASSPATH_DEPENDENCIES = host-pkgconf
-CLASSPATH_AUTORECONF = YES
 CLASSPATH_LICENSE = GPLv2+ with exception
 CLASSPATH_LICENSE_FILES = COPYING
 
Signature · 1 line
2.9.3
#2 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

Drop both patches since they are included upstream. We don't need to autoreconf now.

Note: classpath 0.99 has a bug in it's autoconf scripts, such that configure always fails when specifying --disable-tools[1]. We enable these for now.

Also explicitly disable GJDoc generation, as this defaults to on now. --disable-plugin is not needed any more, since this is now the default.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70660

---
Changes v2 -> v3:
- Fixed announcement url in .hash file (This time for real...)
- Clarify dropping the --disable-plugin option.

Changes v1 -> v2:
- Fixed announcement url in .hash file

 package/classpath/0001-fix-gmp-include.patch  |  46 --
 package/classpath/0002-add-config-rpath.patch | 680 --------------------------
 package/classpath/classpath.hash              |   4 +-
 package/classpath/classpath.mk                |   7 +-
 4 files changed, 5 insertions(+), 732 deletions(-)
 delete mode 100644 package/classpath/0001-fix-gmp-include.patch
 delete mode 100644 package/classpath/0002-add-config-rpath.patch
package/classpath/0001-fix-gmp-include.patch deleted +0 -46
deleted file mode 100644
index f7a3920..0000000
@@ -1,46 +0,0 @@
-The GMP include is hardcoded to /usr/include causing obvious problems.
-
-From classpath CVS:
-http://cvs.savannah.gnu.org/viewvc/classpath/configure.ac?root=classpath&r1=1.245&r2=1.246
-
-[Gustavo: ditch -L or libtool complains loudly]
-
-Signed-off-by: Gustavo Zacarias <[email protected]>
-
---- a/configure.ac	2010/01/30 01:33:50	1.245
-+++ b/configure.ac	2010/05/04 12:29:23	1.246
-@@ -752,10 +752,32 @@
-   dnl __gmpz_mul_si for earlier versions (>= 3.1).
-   dnl IMPORTANT: if you decide to look for __gmpz_combit, don't forget to
-   dnl change the name of the corresponding ac_ variable on lines 860...
-+  AC_ARG_WITH(gmp, [  --with-gmp=PATH         specify prefix directory for the installed GMP package.
-+                          Equivalent to --with-gmp-include=PATH/include
-+                          plus --with-gmp-lib=PATH/lib])
-+  AC_ARG_WITH(gmp_include, [  --with-gmp-include=PATH specify directory for installed GMP include files])
-+  AC_ARG_WITH(gmp_lib, [  --with-gmp-lib=PATH     specify directory for the installed GMP library])
-+
-   if test "x${COMPILE_GMP}" = xyes; then
-+    AC_MSG_CHECKING([for GMP directories])
-+    if test "x$with_gmp" != x; then
-+       gmplibs="-lgmp"
-+       gmpinc="-I$with_gmp/include"
-+       if test "x$with_gmp_include" != x; then
-+       	  gmpinc="-I$with_gmp_include $gmpinc"
-+       fi
-+       if test "x$with_gmp_lib" != x; then
-+       	  gmplibs="$gmplibs"
-+       fi
-+    else
-+        with_gmp="/usr"
-+	gmplibs="-lgmp"
-+    	gmpinc="-I/usr/include"
-+    fi
-+    AC_MSG_RESULT([prefix=$with_gmp, libs=$gmplibs, inc=$gmpinc])
-     AC_CHECK_LIB(gmp, __gmpz_mul_si,
--      [GMP_CFLAGS=-I/usr/include
--       GMP_LIBS=-lgmp ],
-+      [GMP_CFLAGS="$gmpinc"
-+       GMP_LIBS="$gmplibs" ],
-       [GMP_CFLAGS=
-        GMP_LIBS= ])
-     AC_SUBST(GMP_CFLAGS)
package/classpath/0002-add-config-rpath.patch deleted +0 -680

680 lines not on this page · raw message

package/classpath/classpath.hash +2 -2
index 25d3e8c..d1c5b5c 100644
@@ -1,2 +1,2 @@
-# From http://www.gnu.org/software/classpath/announce/20090205.html
-sha1	1d6e8d1b3542a35bbd1013c61fab3cfae083decb	classpath-0.98.tar.gz
+# From https://www.gnu.org/software/classpath/announce/20120307.html
+sha256	f929297f8ae9b613a1a167e231566861893260651d913ad9b6c11933895fecc8	classpath-0.99.tar.gz
package/classpath/classpath.mk +3 -4
index 3825c76..97b7f0d 100644
@@ -4,21 +4,20 @@
 #
 ################################################################################
 
-CLASSPATH_VERSION = 0.98
+CLASSPATH_VERSION = 0.99
 CLASSPATH_SITE = $(BR2_GNU_MIRROR)/classpath
 CLASSPATH_CONF_OPTS = \
 	--disable-examples \
-	--disable-plugin \
 	--disable-rpath \
 	--disable-Werror \
 	--disable-gconf-peer \
-	--disable-tools
+	--disable-gjdoc
+	--enable-tools
 
 # classpath assumes qt runs on top of X11, but we
 # don't support qt4 on X11
 CLASSPATH_CONF_OPTS += --disable-qt-peer
 CLASSPATH_DEPENDENCIES = host-pkgconf
-CLASSPATH_AUTORECONF = YES
 CLASSPATH_LICENSE = GPLv2+ with exception
 CLASSPATH_LICENSE_FILES = COPYING
 
Signature · 1 line
2.9.3
#3 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

Hello,

Quoted 10 lines · Marcus Hoffmann

Drop both patches since they are included upstream. We don't need to autoreconf now.

Note: classpath 0.99 has a bug in it's autoconf scripts, such that configure always fails when specifying --disable-tools[1]. We enable these for now.

Also explicitly disable GJDoc generation, as this defaults to on now. --disable-plugin is not needed any more, since this is now the default.

Quoted 7 lines

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70660

---
Changes v2 -> v3:
- Fixed announcement url in .hash file (This time for real...)
- Clarify dropping the --disable-plugin option.

Applied to next, thanks. I have two comments though:

1. If you're using/interested in classpath, would you mind adding your name in the DEVELOPERS file for this package? Same if you're using/interested in jamvm. Those two packages are currently not associated to any developer, it would be nice to have a developer interested in those two packages.

2. classpath has a "depends on BR2_PACKAGE_JAMVM" and jamvm has a "select BR2_PACKAGE_CLASSPATH" which feels a bit like a circular dependency. It would be nice to fix that up as well.

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

Hello Thomas,

Quoted 21 lines · Thomas Petazzoni

Hello,

Quoted 10 lines · Marcus Hoffmann

Drop both patches since they are included upstream. We don't need to autoreconf now.

Note: classpath 0.99 has a bug in it's autoconf scripts, such that configure always fails when specifying --disable-tools[1]. We enable these for now.

Also explicitly disable GJDoc generation, as this defaults to on now. --disable-plugin is not needed any more, since this is now the default.

Quoted 7 lines

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70660

---
Changes v2 -> v3:
- Fixed announcement url in .hash file (This time for real...)
- Clarify dropping the --disable-plugin option.

Quoted 7 lines

Applied to next, thanks. I have two comments though:

1. If you're using/interested in classpath, would you mind adding your name in the DEVELOPERS file for this package? Same if you're using/interested in jamvm. Those two packages are currently not associated to any developer, it would be nice to have a developer interested in those two packages.

I don't know, we are looking into jamvm/classpath but haven't decided on a Java VM/class library yet. For now I would wait a while until there is a decision if we'll be using those packages.

Quoted 4 lines

2. classpath has a "depends on BR2_PACKAGE_JAMVM" and jamvm has a "select BR2_PACKAGE_CLASSPATH" which feels a bit like a circular dependency. It would be nice to fix that up as well.

What would be the preferred solution here? JamVM selecting classpath seems fine, as long as there is no alternative class library in buildroot. So we allow selecting classpath but not JamVM? Here is a list of projects using gnu classpath:
https://www.gnu.org/software/classpath/stories.html#jvm

But if you explicitly select the gnu classpath library then you probably know why you want it, right?

I can send a patch changing that.

Quoted 5 lines

Thanks a lot!

Thomas

Marcus

#5 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

Hello,

Quoted 8 lines · Marcus Hoffmann
Quoted 5 lines

1. If you're using/interested in classpath, would you mind adding your name in the DEVELOPERS file for this package? Same if you're using/interested in jamvm. Those two packages are currently not associated to any developer, it would be nice to have a developer interested in those two packages.

I don't know, we are looking into jamvm/classpath but haven't decided on a Java VM/class library yet. For now I would wait a while until there is a decision if we'll be using those packages.

OK.

Quoted 9 lines
Quoted 3 lines

2. classpath has a "depends on BR2_PACKAGE_JAMVM" and jamvm has a "select BR2_PACKAGE_CLASSPATH" which feels a bit like a circular dependency. It would be nice to fix that up as well.

What would be the preferred solution here? JamVM selecting classpath seems fine, as long as there is no alternative class library in buildroot. So we allow selecting classpath but not JamVM? Here is a list of projects using gnu classpath:
https://www.gnu.org/software/classpath/stories.html#jvm

My understanding is that the build dependency is:

	jamvm -> classpath

i.e the classpath package needs to be built/installed before we build the jamvm package. If that's the case, then I would keep the "select BR2_PACKAGE_CLASSPATH" in jamvm/Config.in, but get rid of the "depends on BR2_PACKAGE_JAMVM" in classpath/Config.in.

Peter, you're the one who added classpath originally (commit 5062f530081913bd0487f0f879be180f30836ab8) including this "depends on BR2_PACKAGE_JAMVM" dependency. What do you think ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#6 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

Hello,

Quoted 12 lines · Thomas Petazzoni

Hello,

Quoted 9 lines
Quoted 3 lines

2. classpath has a "depends on BR2_PACKAGE_JAMVM" and jamvm has a "select BR2_PACKAGE_CLASSPATH" which feels a bit like a circular dependency. It would be nice to fix that up as well.

What would be the preferred solution here? JamVM selecting classpath seems fine, as long as there is no alternative class library in buildroot. So we allow selecting classpath but not JamVM? Here is a list of projects using gnu classpath:
https://www.gnu.org/software/classpath/stories.html#jvm

Quoted 8 lines

My understanding is that the build dependency is:

	jamvm -> classpath

i.e the classpath package needs to be built/installed before we build the jamvm package. If that's the case, then I would keep the "select BR2_PACKAGE_CLASSPATH" in jamvm/Config.in, but get rid of the "depends on BR2_PACKAGE_JAMVM" in classpath/Config.in.

That's my understanding as well.
I'll prepare a patch.

Quoted 7 lines

Peter, you're the one who added classpath originally (commit 5062f530081913bd0487f0f879be180f30836ab8) including this "depends on BR2_PACKAGE_JAMVM" dependency. What do you think ?

Thomas

Marcus

#7 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 4 lines

My understanding is that the build dependency is:

	jamvm -> classpath
Quoted 8 lines

i.e the classpath package needs to be built/installed before we build the jamvm package. If that's the case, then I would keep the "select BR2_PACKAGE_CLASSPATH" in jamvm/Config.in, but get rid of the "depends on BR2_PACKAGE_JAMVM" in classpath/Config.in.

Peter, you're the one who added classpath originally (commit 5062f530081913bd0487f0f879be180f30836ab8) including this "depends on BR2_PACKAGE_JAMVM" dependency. What do you think ?

I don't recall the details, but as far as I remember the thinking was that classpath only made sense if we have a jvm (and jamvm is our only jvm).

Signature · 1 line
Bye, Peter Korsgaard
#8 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

Hello,

Quoted 5 lines · Peter Korsgaard
Quoted 4 lines

i.e the classpath package needs to be built/installed before we build the jamvm package. If that's the case, then I would keep the "select BR2_PACKAGE_CLASSPATH" in jamvm/Config.in, but get rid of the "depends on BR2_PACKAGE_JAMVM" in classpath/Config.in.

Quoted 7 lines
Quoted 3 lines

Peter, you're the one who added classpath originally (commit 5062f530081913bd0487f0f879be180f30836ab8) including this "depends on BR2_PACKAGE_JAMVM" dependency. What do you think ?

I don't recall the details, but as far as I remember the thinking was that classpath only made sense if we have a jvm (and jamvm is our only jvm).

Agreed. But that creates a kind of weird circular dependency, no?

Or perhaps we should just get rid of the prompt for classpath completely?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#9 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 8 lines
Quoted 3 lines

I don't recall the details, but as far as I remember the thinking was that classpath only made sense if we have a jvm (and jamvm is our only jvm).

Agreed. But that creates a kind of weird circular dependency, no?

Or perhaps we should just get rid of the prompt for classpath completely?

Either that or dropping the 'depends on jamvm' from classpath. It indeed isn't very useful without a jvm, but it still builds Ok and I guess a lot of other package combinations also don't make a lot of sense.

Signature · 1 line
Bye, Peter Korsgaard
#10 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

Hello,

Quoted 8 lines · Peter Korsgaard
Quoted 4 lines

Agreed. But that creates a kind of weird circular dependency, no?

Or perhaps we should just get rid of the prompt for classpath completely?

Either that or dropping the 'depends on jamvm' from classpath. It indeed isn't very useful without a jvm, but it still builds Ok and I guess a lot of other package combinations also don't make a lot of sense.

I think it's a better option than making the classpath package invisible. Indeed, if we make it invisible, users might wonder if we have "support" for it.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#11 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

In reply to Marcus Hoffmann

Hello,

package/classpath/classpath.mk line 14

Quoted 11 lines · Marcus Hoffmann
package/classpath/classpath.mk +2 -3
-CLASSPATH_VERSION = 0.98
+CLASSPATH_VERSION = 0.99
 CLASSPATH_SITE = $(BR2_GNU_MIRROR)/classpath
 CLASSPATH_CONF_OPTS = \
 	--disable-examples \
-	--disable-plugin \
 	--disable-rpath \
 	--disable-Werror \
 	--disable-gconf-peer \
-	--disable-tools
+	--disable-gjdoc

There was a typo here: missing final backslash. Due to this, Buildroot could not build this package at all. Did you test it before submitting the patch? :-)

package/classpath/classpath.mk line 15

Quoted 1 line
package/classpath/classpath.mk +1 -0
+	--enable-tools

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#12 lore raw

PATCH v3 1/1 classpath: bump to version 0.99

Hello Thomas,

Quoted 4 lines · Thomas Petazzoni

Hello,

On Sun, 12 Feb 2017 03:04:44 +0100, Marcus Hoffmann wrote:

Quoted 15 lines

package/classpath/classpath.mk line 14

Quoted 11 lines
package/classpath/classpath.mk +2 -3
-CLASSPATH_VERSION = 0.98
+CLASSPATH_VERSION = 0.99
 CLASSPATH_SITE = $(BR2_GNU_MIRROR)/classpath
 CLASSPATH_CONF_OPTS = \
 	--disable-examples \
-	--disable-plugin \
 	--disable-rpath \
 	--disable-Werror \
 	--disable-gconf-peer \
-	--disable-tools
+	--disable-gjdoc

There was a typo here: missing final backslash. Due to this, Buildroot could not build this package at all. Did you test it before submitting the patch? :-)

I let it run through the test-pkg script. And then I think I reordered some lines before the final commit... :-/ Sorry about that.

I saw you fixed it already. Thanks, and sorry again!

Quoted 7 lines

package/classpath/classpath.mk line 15

Quoted 2 lines
package/classpath/classpath.mk +1 -0
+	--enable-tools

Thanks!

Thomas

Marcus