Skip to contentSkip to conversation

mmc: pci: only compile on platforms that need it

PATCH New Andy Shevchenko 3 participants 3 messages Feb 13, 2017 – Feb 15, 2017 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: pci: only compile on platforms that need it

From: Felipe Balbi <[email protected]>

We should only compile pci_mmc.c on platforms that actually need this. Some platforms are using generic sdhci through driver model.

---
 drivers/mmc/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mmc/Makefile +3 -1
index 49413dfaf1..26db92e582 100644
@@ -36,7 +36,9 @@ obj-$(CONFIG_MVEBU_MMC) += mvebu_mmc.o
 obj-$(CONFIG_MMC_OMAP_HS)		+= omap_hsmmc.o
 obj-$(CONFIG_MMC_MXC)			+= mxcmmc.o
 obj-$(CONFIG_MMC_MXS)			+= mxsmmc.o
-obj-$(CONFIG_X86) += pci_mmc.o
+obj-$(CONFIG_INTEL_BAYTRAIL) += pci_mmc.o
+obj-$(CONFIG_INTEL_QUARK) += pci_mmc.o
+obj-$(CONFIG_INTEL_QUEENSBAY) += pci_mmc.o
 obj-$(CONFIG_PXA_MMC_GENERIC) += pxa_mmc_gen.o
 obj-$(CONFIG_SUPPORT_EMMC_RPMB) += rpmb.o
 obj-$(CONFIG_S3C_SDI) += s3c_sdi.o
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 mmc: pci: only compile on platforms that need it

Hi,

Quoted 16 lines · Andy Shevchenko

From: Felipe Balbi <[email protected]>

We should only compile pci_mmc.c on platforms that actually need this. Some platforms are using generic sdhci through driver model.

---
 drivers/mmc/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mmc/Makefile +0 -0
index 49413dfaf1..26db92e582 100644

drivers/mmc/Makefile obj-$(CONFIG_MVEBU_MMC) += mvebu_mmc.o · line 41

Quoted 7 lines
drivers/mmc/Makefile +3 -1
@@ -36,7 +36,9 @@ obj-$(CONFIG_MVEBU_MMC) += mvebu_mmc.o
 obj-$(CONFIG_MMC_OMAP_HS)		+= omap_hsmmc.o
 obj-$(CONFIG_MMC_MXC)			+= mxcmmc.o
 obj-$(CONFIG_MMC_MXS)			+= mxsmmc.o
-obj-$(CONFIG_X86) += pci_mmc.o
+obj-$(CONFIG_INTEL_BAYTRAIL) += pci_mmc.o
+obj-$(CONFIG_INTEL_QUARK) += pci_mmc.o
+obj-$(CONFIG_INTEL_QUEENSBAY) += pci_mmc.o

How about adding new CONFIG_MMC_X86_PCI for this.

obj-$(CONFIG_MMC_X86_PCI) += pci_mmc.o

Of course, you need to modify Kconfig file.

Best Regards,
Jaehoon Chung

Quoted 4 lines
drivers/mmc/Makefile +0 -0
 obj-$(CONFIG_PXA_MMC_GENERIC) += pxa_mmc_gen.o
 obj-$(CONFIG_SUPPORT_EMMC_RPMB) += rpmb.o
 obj-$(CONFIG_S3C_SDI) += s3c_sdi.o
#2 lore raw

PATCH 1/1 mmc: pci: only compile on platforms that need it

Hi,

Quoted 27 lines · Jaehoon Chung
Quoted 16 lines · Andy Shevchenko

From: Felipe Balbi <[email protected]>

We should only compile pci_mmc.c on platforms that actually need this. Some platforms are using generic sdhci through driver model.

---
 drivers/mmc/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mmc/Makefile +0 -0
index 49413dfaf1..26db92e582 100644

drivers/mmc/Makefile obj-$(CONFIG_MVEBU_MMC) += mvebu_mmc.o · line 41

Quoted 7 lines
drivers/mmc/Makefile +3 -1
@@ -36,7 +36,9 @@ obj-$(CONFIG_MVEBU_MMC) += mvebu_mmc.o
 obj-$(CONFIG_MMC_OMAP_HS)		+= omap_hsmmc.o
 obj-$(CONFIG_MMC_MXC)			+= mxcmmc.o
 obj-$(CONFIG_MMC_MXS)			+= mxsmmc.o
-obj-$(CONFIG_X86) += pci_mmc.o
+obj-$(CONFIG_INTEL_BAYTRAIL) += pci_mmc.o
+obj-$(CONFIG_INTEL_QUARK) += pci_mmc.o
+obj-$(CONFIG_INTEL_QUEENSBAY) += pci_mmc.o

How about adding new CONFIG_MMC_X86_PCI for this.

Quoted 3 lines

obj-$(CONFIG_MMC_X86_PCI) += pci_mmc.o

Of course, you need to modify Kconfig file.

doable, no problems for me.

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170215/2dff4c44/attachment.sig>