Install raptor package in staging
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 Install raptor package in staging
---
?package/raptor/raptor.mk | 2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)
package/raptor/raptor.mk +0 -0
@@ -13,7 +13,7 @@ RAPTOR_LICENSE_FILES = LICENSE.txt
?
?# Flag is added to make sure the patch is applied for the configure.ac of raptor. ?RAPTOR_AUTORECONF = YES
-
+RAPTOR_INSTALL_STAGING=YES
?RAPTOR_CONF_OPTS =\
???? --with-xml2-config=$(STAGING_DIR)/usr/bin/xml2-config \
???? --with-xslt-config=$(STAGING_DIR)/usr/bin/xslt-config
Signature · 5 lines
2.7.4 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170213/4c86adee/attachment.html>
PATCH 1/1 Install raptor package in staging
Erwan,
Quoted 14 lines · Erwan Gautron
Signed-off-by Erwan Gautron <[email protected]>--- package/raptor/raptor.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/raptor/raptor.mk +0
-0@@ -13,7 +13,7 @@ RAPTOR_LICENSE_FILES = LICENSE.txt # Flag is added to make sure the patch is applied for the configure.ac ofraptor.
RAPTOR_AUTORECONF= YES
package/raptor/raptor.mk
Quoted 2 lines
package/raptor/raptor.mk +1
-1- +RAPTOR_INSTALL_STAGING=YES
Quoted 6 lines
RAPTOR_CONF_OPTS =\ --with-xml2-config=$(STAGING_DIR)/usr/bin/xml2-config \ --with-xslt-config=$(STAGING_DIR)/usr/bin/xslt-config--
2.7.4
Signature · 8 lines
Matthew L Weber / Pr Software Engineer Airborne Information Systems / Security Systems and Software / Secure Platforms MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA www.rockwellcollins.com Note: Any Export License Required Information and License Restricted Third Party Intellectual Property (TPIP) content must be encrypted and sent to matthew.weber at corp.rockwellcollins.com.
PATCH 1/1 Install raptor package in staging
In reply to Erwan GautronHello,
Thanks for your contribution! This looks mostly good, but I have a few comments below.
The commit title should be:
raptor: install package to staging
indeed, for consistency reasons, we want all commit titles to follow the format:
<package>: <short description>
Quoted 1 line · Erwan Gautron
Signed-off-by Erwan Gautron <[email protected]>
Could you expand the commit log to explain *why* we want to install this package to staging?
package/raptor/raptor.mk
Quoted 13 lines
?package/raptor/raptor.mk | 2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)package/raptor/raptor.mk +0
-0@@ -13,7 +13,7 @@ RAPTOR_LICENSE_FILES = LICENSE.txt?
?# Flag is added to make sure the patch is applied for the configure.ac of raptor. ?RAPTOR_AUTORECONF = YESpackage/raptor/raptor.mk +1
-1- +RAPTOR_INSTALL_STAGING=YES
Missing spaces before and after the equal sign.
I could have fixed this and the commit title myself, but I can't fix the reason why this patch is useful. So can you fix all three issues and submit an updated version of your patch?
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 Install raptor package in staging
HelloI'll do
BR
Erwan
De?: Thomas Petazzoni <[email protected]>
??: Erwan Gautron <[email protected]>
Cc?: "buildroot at buildroot.org" <[email protected]>
Envoy? le : Lundi 13 f?vrier 2017 15h58
Objet?: Re: [Buildroot] [PATCH 1/1] Install raptor package in staging
Hello,
Thanks for your contribution! This looks mostly good, but I have a few comments below.
The commit title should be:
??? raptor: install package to staging
indeed, for consistency reasons, we want all commit titles to follow the format:
??? <package>: <short description>
Quoted 1 line · Erwan Gautron
Signed-off-by Erwan Gautron <[email protected]>
Could you expand the commit log to explain *why* we want to install this package to staging?
package/raptor/raptor.mk
Quoted 13 lines
?package/raptor/raptor.mk | 2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)package/raptor/raptor.mk +0
-0@@ -13,7 +13,7 @@ RAPTOR_LICENSE_FILES = LICENSE.txt?
?# Flag is added to make sure the patch is applied for the configure.ac of raptor. ?RAPTOR_AUTORECONF = YESpackage/raptor/raptor.mk +1
-1- +RAPTOR_INSTALL_STAGING=YES
Missing spaces before and after the equal sign.
I could have fixed this and the commit title myself, but I can't fix the reason why this patch is useful. So can you fix all three issues and submit an updated version of your patch?
Thanks a lot!
Thomas
Signature · 12 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170214/f883c632/attachment.html>