Skip to contentSkip to conversation

Input: tca8418_keypad - remove double read of key event register

PATCH New Dmitry Torokhov 1 participant 1 message Feb 13, 2017

Subsystems (2)
lore
Share & tools
lore

Dmitry Torokhov

author maintainer
#0 lore raw

PATCH 1/1 Input: tca8418_keypad - remove double read of key event register

There is no need to tread the same register twice in a row.

Fixes ea4348c8462a ("Input: tca8418_keypad - hide gcc-4.9 -Wmaybe-un ...")
---
 drivers/input/keyboard/tca8418_keypad.c | 2 --
 1 file changed, 2 deletions(-)
drivers/input/keyboard/tca8418_keypad.c +0 -2
index 44dd7689c571..e37e335e406f 100644
@@ -188,8 +188,6 @@ static void tca8418_read_keypad(struct tca8418_keypad *keypad_data)
 		input_event(input, EV_MSC, MSC_SCAN, code);
 		input_report_key(input, keymap[code], state);
 
-		/* Read for next loop */
-		error = tca8418_read_byte(keypad_data, REG_KEY_EVENT_A, &reg);
 	} while (1);
 
 	input_sync(input);
Signature · 4 lines
2.11.0.483.g087da7b7c-goog

-- 
Dmitry