Skip to contentSkip to conversation

kmsxx: not available on m68k

PATCH New Peter Korsgaard 3 participants 9 messages Feb 13, 2017 – Feb 14, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kmsxx: not available on m68k

Fixes:
http://autobuild.buildroot.net/results/273/2738e5fd446467b105f6dcca391500e3734e5a9b/
http://autobuild.buildroot.net/results/7eb/7ebaa00b2d14131fadd15df6db32632828c1de33/
http://autobuild.buildroot.net/results/42c/42c2aa4b58de3ab84a27f53a696fa60d087c178b/

GCC dies with an internal compiler error when building kmsxx on m68k, so disable it.

These autobuilder issues are with a 2016.11 toolchain (gcc 5.x), but also verified with gcc 6.3.0 / binutils 2.27.

---
 package/kmsxx/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/kmsxx/Config.in +2 -0
index 1d174c18b..3750897bb 100644
@@ -4,6 +4,7 @@ config BR2_PACKAGE_KMSXX
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm
+	depends on !BR2_m68k # gcc ice
 	select BR2_PACKAGE_LIBDRM
 	help
 	  libkms++ is a C++11 library for kernel mode setting.
@@ -24,3 +25,4 @@ endif
 comment "kms++ needs a toolchain w/ threads, C++, gcc >= 4.8, headers >= 3.8"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8
+	depends on !BR2_m68k
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 kmsxx: not available on m68k

Hello,

package/kmsxx/Config.in config BR2_PACKAGE_KMSXX · line 7

Quoted 9 lines · Peter Korsgaard
package/kmsxx/Config.in +1 -0
index 1d174c18b..3750897bb 100644
@@ -4,6 +4,7 @@ config BR2_PACKAGE_KMSXX
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm
+	depends on !BR2_m68k # gcc ice

As usual, I really prefer if we report the bug to gcc upstream, and then do a depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_xyz. Otherwise, it's really tricky to keep track of when this or that issue gets resolved and when we can re-enable m68k.

CC'ing Waldemar on this.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 kmsxx: not available on m68k

Quoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

package/kmsxx/Config.in config BR2_PACKAGE_KMSXX · line 7

Quoted 9 lines · Peter Korsgaard
package/kmsxx/Config.in +0 -0
index 1d174c18b..3750897bb 100644
@@ -4,6 +4,7 @@ config BR2_PACKAGE_KMSXX

depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm

package/kmsxx/Config.in +1 -0
+	depends on !BR2_m68k # gcc ice

As usual, I really prefer if we report the bug to gcc upstream, and then do a depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_xyz. Otherwise, it's really tricky to keep track of when this or that issue gets resolved and when we can re-enable m68k.

Quoted 1 line

CC'ing Waldemar on this.

That's also fine by me if somebody wants to do that. I personally don't know/care enough about m68k, and it has been failing since October without anything happening, so I think we should disable it.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 kmsxx: not available on m68k

Hi Peter,
Peter Korsgaard wrote,

Quoted 20 lines
Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

package/kmsxx/Config.in config BR2_PACKAGE_KMSXX · line 7

Quoted 9 lines · Peter Korsgaard
package/kmsxx/Config.in +0 -0
index 1d174c18b..3750897bb 100644
@@ -4,6 +4,7 @@ config BR2_PACKAGE_KMSXX

depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm

package/kmsxx/Config.in +1 -0
+	depends on !BR2_m68k # gcc ice

As usual, I really prefer if we report the bug to gcc upstream, and then do a depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_xyz. Otherwise, it's really tricky to keep track of when this or that issue gets resolved and when we can re-enable m68k.

Quoted 5 lines
Quoted 1 line

CC'ing Waldemar on this.

That's also fine by me if somebody wants to do that. I personally don't know/care enough about m68k, and it has been failing since October without anything happening, so I think we should disable it.

It is not that nothing happened.
I think this would be solved by my following patch:
http://buildroot-busybox.2317881.n4.nabble.com/PATCH-m68k-add-special-gcc-flag-to-avoid-ICE-for-coldfire-td151151.html

Did you had a chance to discuss the required changes with Arnout in the last developer meeting?

best regards
Waldemar

#4 lore raw

PATCH 1/1 kmsxx: not available on m68k

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Waldemar" == Waldemar Brodkorb <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 3 lines

That's also fine by me if somebody wants to do that. I personally don't know/care enough about m68k, and it has been failing since October without anything happening, so I think we should disable it.

It is not that nothing happened.
I think this would be solved by my following patch:
http://buildroot-busybox.2317881.n4.nabble.com/PATCH-m68k-add-special-gcc-flag-to-avoid-ICE-for-coldfire-td151151.html

Sorry, I forgot about the relation between this build issue and the "magic" compiler flag.

Quoted 2 lines

Did you had a chance to discuss the required changes with Arnout in the last developer meeting?

I could only join from Monday evening, but I don't think so.

We are again past rc1, so I think the safest approach for 2017.02 is to not add it to the wrapper, but instead explicitly pass it in kmsxx.mk (and any other package with the same problem). From my IRC history this also seems to be what you discussed with Thomas yesterday.

Will you send patches to do this?

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 kmsxx: not available on m68k

Hello,

Quoted 4 lines · Peter Korsgaard

We are again past rc1, so I think the safest approach for 2017.02 is to not add it to the wrapper, but instead explicitly pass it in kmsxx.mk (and any other package with the same problem). From my IRC history this also seems to be what you discussed with Thomas yesterday.

In addition, only 3 packages need it for the moment according to Waldemar, so I think for now a per-package fix is better. We'll see later if this needs to be generalized and put into the wrapper if really a large number of packages are affected.

Has this issue been reported upstream?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#6 lore raw

PATCH 1/1 kmsxx: not available on m68k

In reply to Peter Korsgaard

Hi Peter,
Peter Korsgaard wrote,

Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Waldemar" == Waldemar Brodkorb <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 3 lines

That's also fine by me if somebody wants to do that. I personally don't know/care enough about m68k, and it has been failing since October without anything happening, so I think we should disable it.

It is not that nothing happened.
I think this would be solved by my following patch:
http://buildroot-busybox.2317881.n4.nabble.com/PATCH-m68k-add-special-gcc-flag-to-avoid-ICE-for-coldfire-td151151.html

Sorry, I forgot about the relation between this build issue and the "magic" compiler flag.

Quoted 2 lines

Did you had a chance to discuss the required changes with Arnout in the last developer meeting?

Quoted 8 lines

I could only join from Monday evening, but I don't think so.

We are again past rc1, so I think the safest approach for 2017.02 is to not add it to the wrapper, but instead explicitly pass it in kmsxx.mk (and any other package with the same problem). From my IRC history this also seems to be what you discussed with Thomas yesterday.

Will you send patches to do this?

I can try. But now I am back to my original problem, how do I overwrite CFLAGS/CXXFLAGS correctly for a single package build with cmake?

Any examples in the tree?

I think that was the reason we tried to add it globally in the wrapper :/

best regards
Waldemar

#7 lore raw

PATCH 1/1 kmsxx: not available on m68k

Hello,

Quoted 5 lines · Waldemar Brodkorb

I can try. But now I am back to my original problem, how do I overwrite CFLAGS/CXXFLAGS correctly for a single package build with cmake?

Any examples in the tree?

ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
LIBCEC_DEPENDENCIES += rpi-userland

LIBCEC_CONF_OPTS += \
        -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -lvcos -lvchiq_arm" \
        -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) \
                -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux \
                -I$(STAGING_DIR)/usr/include/interface/vcos/pthreads"

endif

or

ifeq ($(BR2_ARM_CPU_ARMV7A)$(BR2_ARM_CPU_HAS_NEON),yy) GNURADIO_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -march=armv7-a" endif

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#8 lore raw

PATCH 1/1 kmsxx: not available on m68k

In reply to Waldemar Brodkorb
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Waldemar" == Waldemar Brodkorb <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 1 line

Will you send patches to do this?

I can try. But now I am back to my original problem, how do I overwrite CFLAGS/CXXFLAGS correctly for a single package build with cmake?

Any examples in the tree?

I'm far from a cmake expert, but I would expect something like:

KMSXX_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -fno-dwarf2-cfi-asm"

Would work. rpi-userland does something similar.

Signature · 1 line
Bye, Peter Korsgaard