Skip to contentSkip to conversation

ddrescue: fix uclibc compile

PATCH New Peter Seiderer 2 participants 3 messages Feb 14, 2017 – Feb 15, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ddrescue: fix uclibc compile

Fixes compile failure with uclibc [1] because of missing stdio.h include:

In file included from io.cc:28:0:
block.h:219:22: error: ?FILE? has not been declared
int write_mapfile( FILE * f = 0, const bool timestamp = false,

[1] http://autobuild.buildroot.net/results/4ac0754f1cc5ea934d6437e89d1f4906fb3fd0a8

---
 .../ddrescue/0001-io.cc-add-stdio.h-include.patch  | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 package/ddrescue/0001-io.cc-add-stdio.h-include.patch
package/ddrescue/0001-io.cc-add-stdio.h-include.patch new file +36 -0
new file mode 100644
index 000000000..e719c708e
@@ -0,0 +1,36 @@
+From 0f72787b922c53c33d497b17300a959b911e621f Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <[email protected]>
+Date: Tue, 14 Feb 2017 20:12:05 +0100
+Subject: [PATCH] io.cc: add stdio.h include
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes buildroot compile failure with uclibc [1]:
+
+  In file included from io.cc:28:0:
+  block.h:219:22: error: ?FILE? has not been declared
+     int write_mapfile( FILE * f = 0, const bool timestamp = false,
+
+[1] http://autobuild.buildroot.net/results/4ac0754f1cc5ea934d6437e89d1f4906fb3fd0a8
+
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ io.cc | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/io.cc b/io.cc
+index 36b8341..2d6a76e 100644
+--- a/io.cc
++++ b/io.cc
+@@ -23,6 +23,7 @@
+ #include <string>
+ #include <vector>
+ #include <stdint.h>
++#include <stdio.h>
+ #include <unistd.h>
+ 
+ #include "block.h"
+-- 
+2.11.0
+
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 ddrescue: fix uclibc compile

Hello,

Quoted 6 lines · Peter Seiderer

Fixes compile failure with uclibc [1] because of missing stdio.h include:

In file included from io.cc:28:0:
block.h:219:22: error: ?FILE? has not been declared
int write_mapfile( FILE * f = 0, const bool timestamp = false,

Quoted 7 lines

[1] http://autobuild.buildroot.net/results/4ac0754f1cc5ea934d6437e89d1f4906fb3fd0a8

---
 .../ddrescue/0001-io.cc-add-stdio.h-include.patch  | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 package/ddrescue/0001-io.cc-add-stdio.h-include.patch

Applied to master, thanks. Please submit upstream as well. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 ddrescue: fix uclibc compile

Hello Thomas,

Quoted 11 lines · Thomas Petazzoni

Hello,

Quoted 8 lines · Peter Seiderer

Fixes compile failure with uclibc [1] because of missing stdio.h include:

In file included from io.cc:28:0:
block.h:219:22: error: ?FILE? has not been declared
int write_mapfile( FILE * f = 0, const bool timestamp = false,

[1] http://autobuild.buildroot.net/results/4ac0754f1cc5ea934d6437e89d1f4906fb3fd0a8

Quoted 8 lines
Quoted 5 lines
---
 .../ddrescue/0001-io.cc-add-stdio.h-include.patch  | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 package/ddrescue/0001-io.cc-add-stdio.h-include.patch

Applied to master, thanks. Please submit upstream as well. Thanks!

Already submitted upstream:

http://lists.gnu.org/archive/html/bug-ddrescue/2017-02/msg00001.html

Regards,
Peter

Quoted 1 line

Thomas