Skip to contentSkip to conversation

of: add EXPORT_SYMBOL for of_device_compatible_match

PATCH In review Corentin Labbe 2 participants 3 messages Feb 15, 2017 – Feb 17, 2017 Device tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 of: add EXPORT_SYMBOL for of_device_compatible_match

This symbol will be needed for the dwmac-sun8i ethernet driver. For letting it to be build as module, of_device_compatible_match need to be exported.

---
 drivers/of/base.c | 1 +
 1 file changed, 1 insertion(+)
drivers/of/base.c +1 -0
index df6f6e3..fba351b 100644
@@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
 
 	return score;
 }
+EXPORT_SYMBOL(of_device_compatible_match);
 
 /**
  * of_machine_is_compatible - Test root of device tree for a given compatible value
Signature · 6 lines
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 15 lines · Corentin Labbe

This symbol will be needed for the dwmac-sun8i ethernet driver. For letting it to be build as module, of_device_compatible_match need to be exported.

---
 drivers/of/base.c | 1 +
 1 file changed, 1 insertion(+)
drivers/of/base.c +0 -0
index df6f6e3..fba351b 100644

drivers/of/base.c int of_device_compatible_match(struct device_node *device, · line 530

Quoted 7 lines
drivers/of/base.c +1 -0
@@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
 
 	return score;
 }
+EXPORT_SYMBOL(of_device_compatible_match);
 
 /**
  * of_machine_is_compatible - Test root of device tree for a given compatible value

Rob's reply to the last person who requested that:

It's not missing because no modules use it. It's generally preferred to use a match table and of_match_node.

-Frank
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 28 lines · Frank Rowand
Quoted 15 lines · Corentin Labbe

This symbol will be needed for the dwmac-sun8i ethernet driver. For letting it to be build as module, of_device_compatible_match need to be exported.

---
 drivers/of/base.c | 1 +
 1 file changed, 1 insertion(+)
drivers/of/base.c +0 -0
index df6f6e3..fba351b 100644

drivers/of/base.c int of_device_compatible_match(struct device_node *device, · line 530

Quoted 7 lines
drivers/of/base.c +1 -0
@@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
 
 	return score;
 }
+EXPORT_SYMBOL(of_device_compatible_match);
 
 /**
  * of_machine_is_compatible - Test root of device tree for a given compatible value

Rob's reply to the last person who requested that:

Quoted 4 lines

It's not missing because no modules use it. It's generally preferred to use a match table and of_match_node.

-Frank

I replace of_device_compatible_match like you said and it works. Thanks
Corentin Labbe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html