Enable IPC & WM related WA's
Subsystems (2)
cover Enable IPC & WM related WA's
This series include remaining patches from following series to enable IPC and Enable/update memory BW related WA's for WM.
https://patchwork.freedesktop.org/series/15562/
Mahesh Kumar (3):
drm/i915/bxt: Enable IPC support
drm/i915: Decode system memory bandwidth drm/i915/gen9: WM memory bandwidth related workaround
drivers/gpu/drm/i915/i915_drv.c | 184 ++++++++++++++++++++++++++++++- drivers/gpu/drm/i915/i915_drv.h | 27 +++++ drivers/gpu/drm/i915/i915_reg.h | 32 ++++++ drivers/gpu/drm/i915/intel_display.c | 35 ++++++ drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 203 ++++++++++++++++++++++++++++++----- 6 files changed, 457 insertions(+), 25 deletions(-)
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/3 drm/i915/bxt: Enable IPC support
This patch adds IPC support for platforms. This patch enables IPC only for BXT/KBL platform as for SKL recommendation is to keep it disabled. IPC (Isochronous Priority Control) is the hardware feature, which dynamically controls the memory read priority of Display.
When IPC is enabled, plane read requests are sent at high priority until filling above the transition watermark, then the requests are sent at lower priority until dropping below the level 0 watermark. The lower priority requests allow other memory clients to have better memory access. When IPC is disabled, all plane read requests are sent at high priority.
Changes since V1:
- Remove commandline parameter to disable ipc
- Address Paulo's comments
Changes since V2:
- Address review comments
- Set ipc_enabled flag
Changes since V3:
- move ipc_enabled flag assignment inside intel_ipc_enable function
Changes since V4:
- Re-enable IPC after suspend/resume
--- drivers/gpu/drm/i915/i915_drv.c | 4 +++- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 16 ++++++++++++++++ 5 files changed, 22 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +3 -1
@@ -1275,7 +1275,7 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)intel_runtime_pm_enable (dev_priv); - dev_priv->ipc_enabled = false; +intel_enable_ipc (dev_priv);/* Everything is in place, we can now relax! */ DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
@@ -2504,6 +2504,8 @@ static int intel_runtime_resume(struct device *kdev)enable_rpm_wakeref_asserts (dev_priv); +intel_enable_ipc (dev_priv); +if (ret)DRM_ERROR ("Runtime resume failed, disabling it (%d)\n" , ret);else
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -6513,6 +6513,7 @@ enum {#define DISP_FBC_WM_DIS (1<<15)#define DISP_ARB_CTL2 _MMIO(0x45004)#define DISP_DATA_PARTITION_5_6 (1<<6) +#define DISP_IPC_ENABLE (1<<3)#define DBUF_CTL _MMIO(0x45008)#define DBUF_POWER_REQUEST (1<<31)#define DBUF_POWER_STATE (1<<30)
drivers/gpu/drm/i915/intel_display.c +1 -0
@@ -15590,6 +15590,7 @@ void intel_display_resume(struct drm_device *dev)if (!ret) ret =__intel_display_resume (dev, state, &ctx); +intel_enable_ipc (dev_priv);drm_modeset_drop_locks (&ctx);drm_modeset_acquire_fini (&ctx);mutex_unlock (&dev->mode_config.mutex);
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -1824,6 +1824,7 @@ bool skl_ddb_allocation_overlaps(const struct skl_ddb_entry **entries, int ignore);bool ilk_disable_lp_wm (struct drm_device *dev);int sanitize_rc6_option (struct drm_i915_private *dev_priv,int enable_rc6); +void intel_enable_ipc (struct drm_i915_private *dev_priv);static inline int intel_enable_rc6 (void ) {return i915.enable_rc6;
drivers/gpu/drm/i915/intel_pm.c +16 -0
@@ -4646,6 +4646,22 @@ void intel_update_watermarks(struct intel_crtc *crtc) dev_priv->display.update_wm (crtc); } +void intel_enable_ipc (struct drm_i915_private *dev_priv) +{ +u32 val; + + dev_priv->ipc_enabled = false; +if (!(IS_BROXTON (dev_priv) ||IS_KABYLAKE (dev_priv))) +return ; + + val =I915_READ (DISP_ARB_CTL2 ); + + val |=DISP_IPC_ENABLE ; + +I915_WRITE (DISP_ARB_CTL2 , val); + dev_priv->ipc_enabled = true; +} +/* * Lock protecting IPS related data structures */
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/3 drm/i915: Decode system memory bandwidth
In reply to Mahesh KumarThis patch adds support to decode system memory bandwidth which will be used for arbitrated display memory percentage calculation in GEN9 based system.
Changes from v1:
- Address comments from Paulo
- implement decode function for SKL/KBL also
Changes from v2:
- Rewrite the code as per HW team inputs
- Addresses review comments
Changes from v3:
- Fix compilation warning
Changes from v4:
- Address review comments from Paulo
- Round-off the frequency & bandwidth results (Paulo)
--- drivers/gpu/drm/i915/i915_drv.c | 179 ++++++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/i915_drv.h | 12 +++ drivers/gpu/drm/i915/i915_reg.h | 31 +++++++ 3 files changed, 222 insertions(+)
drivers/gpu/drm/i915/i915_drv.c +179 -0
@@ -997,6 +997,179 @@ static void intel_sanitize_options(struct drm_i915_private *dev_priv)DRM_DEBUG_DRIVER ("use GPU sempahores? %s\n" ,yesno (i915.semaphores)); } +static enum memdev_rank +skl_memdev_get_channel_rank (uint32_t val) +{ +uint8_t l_rank, s_rank; +uint8_t l_size, s_size; + +if (!val) +return I915_DRAM_RANK_INVALID ; + + l_size = (val >>SKL_DRAM_SIZE_L_SHIFT ) &SKL_DRAM_SIZE_MASK ; + s_size = (val >>SKL_DRAM_SIZE_S_SHIFT ) &SKL_DRAM_SIZE_MASK ; + l_rank = (val >>SKL_DRAM_RANK_L_SHIFT ) &SKL_DRAM_RANK_MASK ; + s_rank = (val >>SKL_DRAM_RANK_S_SHIFT ) &SKL_DRAM_RANK_MASK ; + +if ((l_size ==0 ) && (s_size ==0 )) +return I915_DRAM_RANK_INVALID ; + +if (l_rank ==SKL_DRAM_RANK_DUAL || s_rank ==SKL_DRAM_RANK_DUAL ) +return I915_DRAM_RANK_DUAL ; + +if ((l_size && l_rank ==SKL_DRAM_RANK_SINGLE ) && + (s_size && s_rank ==SKL_DRAM_RANK_SINGLE )) +return I915_DRAM_RANK_DUAL ; +return I915_DRAM_RANK_SINGLE ; +} + +static int +skl_get_memdev_info (struct drm_i915_private *dev_priv) +{ +struct memdev_info *memdev_info = &dev_priv->memdev_info; +uint32_t mem_freq_khz; +uint32_t val; +enum memdev_rank ch0_rank, ch1_rank; + + val =I915_READ (SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU ); + mem_freq_khz =DIV_ROUND_UP ((val &SKL_REQ_DATA_MASK ) * +SKL_MEMORY_FREQ_MULTIPLIER_HZ ,1000 ); + + val =I915_READ (SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN ); + ch0_rank =skl_memdev_get_channel_rank (val); +if (ch0_rank !=I915_DRAM_RANK_INVALID ) + memdev_info->num_channels++; + + val =I915_READ (SKL_MAD_DIMM_CH1_0_0_0_MCHBAR_MCMAIN ); + ch1_rank =skl_memdev_get_channel_rank (val); +if (ch1_rank !=I915_DRAM_RANK_INVALID ) + memdev_info->num_channels++; + +if (memdev_info->num_channels ==0 ) { +DRM_ERROR ("Number of memory channels is zero\n" ); +return -EINVAL ; + } + + memdev_info->bandwidth_kbps = memdev_info->num_channels * + mem_freq_khz *8 ; + +if (memdev_info->bandwidth_kbps ==0 ) { +DRM_ERROR ("Couldn't get system memory bandwidth\n" ); +return -EINVAL ; + } + +/* +* If any of the channel is single rank channel, worst case output +* will be same as if single rank memory, so consider single rank +* memory. +*/ +if (ch0_rank ==I915_DRAM_RANK_SINGLE + || ch1_rank ==I915_DRAM_RANK_SINGLE ) + memdev_info->rank =I915_DRAM_RANK_SINGLE ; +else + memdev_info->rank =max (ch0_rank, ch1_rank); + +if (memdev_info->rank ==I915_DRAM_RANK_INVALID ) { +DRM_ERROR ("couldn't get memory rank information\n" ); +return -EINVAL ; + } + + memdev_info->valid = true; +return 0 ; +} + +static int +bxt_get_memdev_info (struct drm_i915_private *dev_priv) +{ +struct memdev_info *memdev_info = &dev_priv->memdev_info; +uint32_t dram_channels; +uint32_t mem_freq_khz, val; +uint8_t num_active_channels; +int i; + + val =I915_READ (BXT_P_CR_MC_BIOS_REQ_0_0_0 ); + mem_freq_khz =DIV_ROUND_UP ((val &BXT_REQ_DATA_MASK ) * +BXT_MEMORY_FREQ_MULTIPLIER_HZ ,1000 ); + + dram_channels = (val >>BXT_DRAM_CHANNEL_ACTIVE_SHIFT ) & +BXT_DRAM_CHANNEL_ACTIVE_MASK ; + num_active_channels =hweight32 (dram_channels); + +/* Each active bit represents 4-byte channel */ + memdev_info->bandwidth_kbps = (mem_freq_khz * num_active_channels *4 ); + +if (memdev_info->bandwidth_kbps ==0 ) { +DRM_ERROR ("Couldn't get system memory bandwidth\n" ); +return -EINVAL ; + } + +/* +* Now read each DUNIT8/9/10/11 to check the rank of each dimms. +*/ +for (i =BXT_D_CR_DRP0_DUNIT_START ; i <=BXT_D_CR_DRP0_DUNIT_END ; i++) { + val =I915_READ (BXT_D_CR_DRP0_DUNIT (i)); +if (val !=0xFFFFFFFF ) { +uint8_t rank; +enum memdev_rank ch_rank; + + memdev_info->num_channels++; + rank = val &BXT_DRAM_RANK_MASK ; +if (rank ==BXT_DRAM_RANK_SINGLE ) + ch_rank =I915_DRAM_RANK_SINGLE ; +else if (rank ==BXT_DRAM_RANK_DUAL ) + ch_rank =I915_DRAM_RANK_DUAL ; +else + ch_rank =I915_DRAM_RANK_INVALID ; + +/* +* If any of the channel is single rank channel, +* worst case output will be same as if single rank +* memory, so consider single rank memory. +*/ +if (memdev_info->rank ==I915_DRAM_RANK_INVALID ) + memdev_info->rank = ch_rank; +else if (ch_rank ==I915_DRAM_RANK_SINGLE ) + memdev_info->rank =I915_DRAM_RANK_SINGLE ; + } + } + +if (memdev_info->rank ==I915_DRAM_RANK_INVALID ) { +DRM_ERROR ("couldn't get memory rank information\n" ); +return -EINVAL ; + } + + memdev_info->valid = true; +return 0 ; +} + +static void +intel_get_memdev_info (struct drm_i915_private *dev_priv) +{ +struct memdev_info *memdev_info = &dev_priv->memdev_info; +int ret; + + memdev_info->valid = false; + memdev_info->rank =I915_DRAM_RANK_INVALID ; + memdev_info->num_channels =0 ; + +if (!IS_GEN9 (dev_priv)) +return ; + +if (IS_BROXTON (dev_priv)) + ret =bxt_get_memdev_info (dev_priv); +else + ret =skl_get_memdev_info (dev_priv); +if (ret) +return ; + +DRM_DEBUG_DRIVER ("DRAM bandwidth: %u KBps, total-channels: %u\n" , + memdev_info->bandwidth_kbps, + memdev_info->num_channels); +DRM_DEBUG_DRIVER ("DRAM rank: %s rank\n" , + (memdev_info->rank ==I915_DRAM_RANK_DUAL ) ? +"dual" :"single" ); +} +/** * i915_driver_init_hw - setup state requiring device access * @dev_priv: device private
@@ -1103,6 +1276,12 @@ static int i915_driver_init_hw(struct drm_i915_private *dev_priv)if (ret) goto out_ggtt; +/* +* Fill the memdev structure to get the system raw bandwidth +* This will be used by WM algorithm, to implement GEN9 based WA +*/ +intel_get_memdev_info (dev_priv); +return 0 ; out_ggtt:
drivers/gpu/drm/i915/i915_drv.h +12 -0
@@ -2384,6 +2384,18 @@ struct drm_i915_private {bool distrust_bios_wm; } wm; +struct memdev_info { +bool valid; +uint32_t bandwidth_kbps; +uint8_t num_channels; +enum memdev_rank { +I915_DRAM_RANK_INVALID =0 , +I915_DRAM_RANK_SINGLE , +I915_DRAM_RANK_DUAL + } rank; + } memdev_info; + +struct i915_runtime_pm pm;struct {
drivers/gpu/drm/i915/i915_reg.h +31 -0
@@ -8110,6 +8110,37 @@ enum {#define DC_STATE_DEBUG_MASK_CORES (1<<0)#define DC_STATE_DEBUG_MASK_MEMORY_UP (1<<1) +#define BXT_P_CR_MC_BIOS_REQ_0_0_0 _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x7114) +#define BXT_REQ_DATA_MASK 0x3F +#define BXT_DRAM_CHANNEL_ACTIVE_SHIFT 12 +#define BXT_DRAM_CHANNEL_ACTIVE_MASK 0xF +#define BXT_MEMORY_FREQ_MULTIPLIER_HZ 133333333 + +#define BXT_D_CR_DRP0_DUNIT8 0x1000 +#define BXT_D_CR_DRP0_DUNIT9 0x1200 +#define BXT_D_CR_DRP0_DUNIT_START 8 +#define BXT_D_CR_DRP0_DUNIT_END 11 +#define _MMIO_MCHBAR_DUNIT (x, a, b) _MMIO(MCHBAR_MIRROR_BASE_SNB + (a) + (x - BXT_D_CR_DRP0_DUNIT_START)*((b)-(a))) +#define BXT_D_CR_DRP0_DUNIT (x) _MMIO_MCHBAR_DUNIT(x, BXT_D_CR_DRP0_DUNIT8, BXT_D_CR_DRP0_DUNIT9) +#define BXT_DRAM_RANK_MASK 0x3 +#define BXT_DRAM_RANK_SINGLE 0x1 +#define BXT_DRAM_RANK_DUAL 0x3 + +#define SKL_MEMORY_FREQ_MULTIPLIER_HZ 266666666 +#define SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5E04) +#define SKL_REQ_DATA_MASK (0xF << 0) + +#define SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x500C) +#define SKL_MAD_DIMM_CH1_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5010) +#define SKL_DRAM_SIZE_MASK 0x3F +#define SKL_DRAM_SIZE_L_SHIFT 0 +#define SKL_DRAM_SIZE_S_SHIFT 16 +#define SKL_DRAM_RANK_MASK 0x1 +#define SKL_DRAM_RANK_L_SHIFT 10 +#define SKL_DRAM_RANK_S_SHIFT 26 +#define SKL_DRAM_RANK_SINGLE 0x0 +#define SKL_DRAM_RANK_DUAL 0x1 +/* Please see hsw_read_dcomp() and hsw_write_dcomp() before using this register, * since on HSW we can't write to it using I915_WRITE. */ #define D_COMP_HSW _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5F0C)
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/3] drm/i915: Decode system memory bandwidth
Em Qua, 2017-02-15 às 20:18 +0530, Mahesh Kumar escreveu:
Quoted 19 lines
This patch adds support to decode system memory bandwidth which will be used for arbitrated display memory percentage calculation in GEN9 based system.
Changes from v1:
- Address comments from Paulo
- implement decode function for SKL/KBL also Changes from v2:
- Rewrite the code as per HW team inputs
- Addresses review comments
Changes from v3:
- Fix compilation warning
Changes from v4:
- Address review comments from Paulo
- Round-off the frequency & bandwidth results (Paulo)Signed-off-by Mahesh Kumar <[email protected]>---
<snip>
Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.c +10
-0+ +static void +intel_get_memdev_info (struct drm_i915_private *dev_priv) +{ +struct memdev_info *memdev_info = &dev_priv->memdev_info; +int ret; + + memdev_info->valid = false; + memdev_info->rank =I915_DRAM_RANK_INVALID ; + memdev_info->num_channels =0 ;
drivers/gpu/drm/i915/i915_drv.c static void intel_sanitize_options(struct drm_i915_private *dev_priv) · line 1163
Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.c +10
-0+ +if (!IS_GEN9 (dev_priv)) +return ; + +if (IS_BROXTON (dev_priv)) + ret =bxt_get_memdev_info (dev_priv); +else + ret =skl_get_memdev_info (dev_priv); +if (ret) +return ;
Quick question: we now have GLK and it's going to call skl_get_memdev_info(). Is this intentional?
drivers/gpu/drm/i915/i915_drv.c static void intel_sanitize_options(struct drm_i915_private *dev_priv) · line 1172
Quoted 11 lines
(quoted diff) +2
-0+ + DRM_DEBUG_DRIVER("DRAM bandwidth: %u KBps, total-channels:%u\n",
drivers/gpu/drm/i915/i915_drv.c +4
-0+ memdev_info->bandwidth_kbps, + memdev_info->num_channels); + DRM_DEBUG_DRIVER("DRAM rank: %s rank\n", + (memdev_info->rank ==
I915_DRAM_RANK_DUAL) ?drivers/gpu/drm/i915/i915_drv.c +3
-0+ "dual" : "single"); +} +
Besides, I see BAT pointed a bunch of WARNs for this series, so I'll wait until BAT gives use the approval stamp before I continue this review, since it's likely that I'll end up having to re-review once the WARNs get fixed.
Thanks,
Paulo
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/3 drm/i915/gen9: WM memory bandwidth related workaround
In reply to Mahesh KumarThis patch disables workarounds related to display arbitrated memory bandwidth if it's not required. WA's are applicable for all GEN9 based platforms.
Changes since v1:
- Rebase on top of Paulo's patch series
Changes since v2:
- Address review comments
- Rebase/rework as per other patch changes in series
Changes since v3:
- Rebase the patch
- Address Paulo's review comments
- introduce ww_mutex to protect WM operations
- Protect system memory bandwidth calculation with ww_mutex
Changes since v4:
- drop goto label
- fix compilation warnings
- Add crtc only if it's WM got changed
--- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 15 +++ drivers/gpu/drm/i915/intel_display.c | 34 +++++++ drivers/gpu/drm/i915/intel_pm.c | 187 ++++++++++++++++++++++++++++++----- 4 files changed, 213 insertions(+), 24 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +1 -0
@@ -835,6 +835,7 @@ static int i915_driver_init_early(struct drm_i915_private *dev_priv,mutex_init (&dev_priv->modeset_restore_lock);mutex_init (&dev_priv->av_mutex);mutex_init (&dev_priv->wm.wm_mutex); +drm_modeset_lock_init (&dev_priv->wm.wm_ww_mutex);mutex_init (&dev_priv->pps_mutex);intel_uc_init_early (dev_priv);
drivers/gpu/drm/i915/i915_drv.h +15 -0
@@ -1189,6 +1189,13 @@ enum intel_sbi_destination { SBI_MPHY, }; +/* SKL+ Watermark arbitrated display bandwidth Workarounds */ +enum watermark_memory_wa { +WATERMARK_WA_NONE , +WATERMARK_WA_X_TILED , +WATERMARK_WA_Y_TILED , +}; +#define QUIRK_PIPEA_FORCE (1<<0)#define QUIRK_LVDS_SSC_DISABLE (1<<1)#define QUIRK_INVERT_BRIGHTNESS (1<<2)
@@ -1754,8 +1761,15 @@ struct skl_ddb_allocation {struct skl_ddb_entry y_plane[I915_MAX_PIPES ][I915_MAX_PLANES ]; }; +struct skl_mem_bw_attr { +enum watermark_memory_wa mem_wa; +uint32_t pipe_bw_kbps[I915_MAX_PIPES ]; +bool pipe_y_tiled[I915_MAX_PIPES ]; +}; +struct skl_wm_values {unsigned dirty_pipes; +struct skl_mem_bw_attr mem_attr;struct skl_ddb_allocation ddb; };
@@ -2375,6 +2389,7 @@ struct drm_i915_private {* cstate->wm.need_postvbl_update. */ struct mutex wm_mutex; +struct drm_modeset_lock wm_ww_mutex;/* protect DDB/WM redistribution among pipes */ /* * Set during HW readout of watermarks/DDB. Some platforms
drivers/gpu/drm/i915/intel_display.c +34 -0
@@ -13030,6 +13030,38 @@ static void intel_atomic_track_fbs(struct drm_atomic_state *state) to_intel_plane(plane)->frontbuffer_bit); } +static void +intel_update_wm_bw_wa (struct drm_atomic_state *state) +{ +struct intel_atomic_state *intel_state =to_intel_atomic_state (state); +struct drm_i915_private *dev_priv =to_i915 (state->dev); +const struct drm_crtc *crtc; +const struct drm_crtc_state *cstate; +const struct memdev_info *memdev_info = &dev_priv->memdev_info; +struct skl_mem_bw_attr *results = &intel_state->wm_results.mem_attr; +struct skl_mem_bw_attr *hw_vals = &dev_priv->wm.skl_hw.mem_attr; +int i; + +if (!IS_GEN9 (dev_priv)) +return ; + +if (!memdev_info->valid) +return ; + +for_each_crtc_in_state (state, crtc, cstate, i) { + hw_vals->pipe_bw_kbps[i] = results->pipe_bw_kbps[i]; + hw_vals->pipe_y_tiled[i] = results->pipe_y_tiled[i]; + } + + hw_vals->mem_wa = results->mem_wa; + +/* +* As we already updated state variables no need to hold the lock, +* other commits can proceed now with their calculation +*/ +drm_modeset_unlock (&dev_priv->wm.wm_ww_mutex); +} +/** * intel_atomic_commit - commit validated state object * @dev: DRM device
@@ -13070,6 +13102,8 @@ static int intel_atomic_commit(struct drm_device *dev,intel_shared_dpll_swap_state (state);intel_atomic_track_fbs (state); +intel_update_wm_bw_wa (state); +if (intel_state->modeset) {memcpy (dev_priv->min_pixclk, intel_state->min_pixclk,sizeof (intel_state->min_pixclk));
drivers/gpu/drm/i915/intel_pm.c +163 -24
250 lines not on this page · raw message
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for Enable IPC & WM related WA's (rev3)
In reply to Mahesh Kumar== Series Details ==
== Series Details ==
Series: Enable IPC & WM related WA's (rev3)
URL : https://patchwork.freedesktop.org/series/18842/
State : failure
== Summary ==
Series 18842v3 Enable IPC & WM related WA's
https://patchwork.freedesktop.org/api/1.0/series/18842/revisions/3/mbox/
Test core_prop_blob:
Subgroup basic:
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
Test drv_hangman:
Subgroup error-state-basic:
pass -> DMESG-WARN (fi-bxt-j4205)
Test drv_module_reload:
Subgroup basic-reload-final:
pass -> DMESG-WARN (fi-skl-6770hq)
Test gem_busy:
Subgroup basic-busy-default:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_close_race:
Subgroup basic-threads:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_ctx_basic:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_ctx_exec:
Subgroup basic:
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
Test gem_ctx_switch:
Subgroup basic-default:
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
Test gem_exec_basic:
Subgroup basic-bsd:
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup basic-render:
pass -> DMESG-WARN (fi-bxt-j4205)
Subgroup gtt-bsd:
pass -> DMESG-WARN (fi-bxt-j4205)
Subgroup gtt-default:
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-bxt-j4205)
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup readonly-blt:
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup readonly-bsd2:
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6770hq)
Test gem_exec_create:
Subgroup basic:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_exec_fence:
Subgroup basic-await-default:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_exec_flush:
Subgroup basic-uc-pro-default:
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-bxt-j4205)
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup basic-uc-rw-default:
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup basic-wb-prw-default:
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup basic-wb-rw-default:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_exec_nop:
Subgroup basic-parallel:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_exec_reloc:
Subgroup basic-gtt:
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6260u)WARNING: Long output truncated
890e171e84eb11944701de9d53c1162dd5c38142 drm-tip: 2017y-02m-15d-15h-34m-13s UTC integration manifest 1861422 drm/i915/gen9: WM memory bandwidth related workaround
391befb drm/i915: Decode system memory bandwidth
6bb5680 drm/i915/bxt: Enable IPC support
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3827/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for Enable IPC & WM related WA's (rev3)
In reply to Mahesh Kumar== Series Details ==
== Series Details ==
Series: Enable IPC & WM related WA's (rev3)
URL : https://patchwork.freedesktop.org/series/18842/
State : warning
== Summary ==
Series 18842v3 Enable IPC & WM related WA's
https://patchwork.freedesktop.org/api/1.0/series/18842/revisions/3/mbox/
Test core_prop_blob:
Subgroup basic:
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-kbl-7500u)
Test drv_hangman:
Subgroup error-state-basic:
pass -> DMESG-WARN (fi-bxt-j4205)
Test drv_module_reload:
Subgroup basic-reload:
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6770hq)
Subgroup basic-reload-final:
pass -> DMESG-WARN (fi-skl-6260u)
Subgroup basic-reload-inject:
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_busy:
Subgroup basic-busy-default:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_close_race:
Subgroup basic-threads:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_ctx_basic:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_ctx_exec:
Subgroup basic:
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-kbl-7500u)
Test gem_ctx_switch:
Subgroup basic-default:
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-kbl-7500u)
Test gem_exec_basic:
Subgroup basic-bsd:
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-kbl-7500u)
Subgroup basic-render:
pass -> DMESG-WARN (fi-bxt-j4205)
Subgroup gtt-bsd:
pass -> DMESG-WARN (fi-bxt-j4205)
Subgroup gtt-default:
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-bxt-j4205)
pass -> DMESG-WARN (fi-skl-6700k)
Subgroup readonly-blt:
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-kbl-7500u)
Subgroup readonly-bsd2:
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6260u)
Test gem_exec_create:
Subgroup basic:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_exec_fence:
Subgroup basic-await-default:
pass -> DMESG-WARN (fi-bxt-j4205)
Test gem_exec_flush:
Subgroup basic-uc-pro-default:
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-bxt-j4205)
pass -> DMESG-WARN (fi-skl-6700k)
Subgroup basic-uc-rw-default:
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-kbl-7500u)
Subgroup basic-wb-prw-default:
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-kbl-7500u)
Subgroup basic-wb-rw-default:
pass -> DMESG-WARN (fi-bxt-j4205)Test gem_exec_nop:
WARNING: Long output truncated
89a932d98b6e1733011019c9872583a9c7c8fda3 drm-tip: 2017y-02m-16d-10h-06m-42s UTC integration manifest 5edd33a drm/i915/gen9: WM memory bandwidth related workaround
ae47779 drm/i915: Decode system memory bandwidth
95a680a drm/i915/bxt: Enable IPC support
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3846/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx