perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
Subsystems (4)
PATCH 1/1 perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
From: Anton Blanchard <[email protected]>
We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently use the plurals.
--- Documentation/trace/kprobetrace.txt | 2 +- Documentation/trace/uprobetracer.txt | 2 +- arch/powerpc/configs/85xx/kmp204x_defconfig | 2 +- arch/s390/configs/default_defconfig | 2 +- arch/s390/configs/gcov_defconfig | 2 +- arch/s390/configs/performance_defconfig | 2 +- arch/s390/defconfig | 2 +- kernel/trace/Kconfig | 6 +++--- kernel/trace/Makefile | 4 ++-- kernel/trace/trace.c | 10 +++++----- kernel/trace/trace_probe.h | 4 ++-- 11 files changed, 19 insertions(+), 19 deletions(-)
Documentation/trace/kprobetrace.txt +1 -1
@@ -12,7 +12,7 @@ kprobes can probe (this means, all functions body except for __kprobes functions). Unlike the Tracepoint based event, this can be added and removed dynamically, on the fly. -To enable this feature, build your kernel with CONFIG_KPROBE_EVENT=y. +To enable this feature, build your kernel with CONFIG_KPROBE_EVENTS=y. Similar to the events tracer, this doesn't need to be activated via current_tracer. Instead of that, add probe points via
Documentation/trace/uprobetracer.txt +1 -1
@@ -7,7 +7,7 @@ Overview -------- Uprobe based trace events are similar to kprobe based trace events. -To enable this feature, build your kernel with CONFIG_UPROBE_EVENT=y. +To enable this feature, build your kernel with CONFIG_UPROBE_EVENTS=y. Similar to the kprobe-event tracer, this doesn't need to be activated via current_tracer. Instead of that, add probe points via
arch/powerpc/configs/85xx/kmp204x_defconfig +1 -1
@@ -210,7 +210,7 @@ CONFIG_DEBUG_SHIRQ=y CONFIG_DETECT_HUNG_TASK=y CONFIG_SCHEDSTATS=y CONFIG_RCU_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_CRYPTO_NULL=y CONFIG_CRYPTO_PCBC=m CONFIG_CRYPTO_MD4=y
arch/s390/configs/default_defconfig +1 -1
@@ -609,7 +609,7 @@ CONFIG_SCHED_TRACER=y CONFIG_FTRACE_SYSCALLS=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_HIST_TRIGGERS=y CONFIG_TRACE_ENUM_MAP_FILE=y
arch/s390/configs/gcov_defconfig +1 -1
@@ -560,7 +560,7 @@ CONFIG_SCHED_TRACER=y CONFIG_FTRACE_SYSCALLS=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_HIST_TRIGGERS=y CONFIG_TRACE_ENUM_MAP_FILE=y
arch/s390/configs/performance_defconfig +1 -1
@@ -558,7 +558,7 @@ CONFIG_SCHED_TRACER=y CONFIG_FTRACE_SYSCALLS=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_HIST_TRIGGERS=y CONFIG_TRACE_ENUM_MAP_FILE=y
arch/s390/defconfig +1 -1
@@ -179,7 +179,7 @@ CONFIG_FTRACE_SYSCALLS=y CONFIG_TRACER_SNAPSHOT_PER_CPU_SWAP=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_TRACE_ENUM_MAP_FILE=y CONFIG_KPROBES_SANITY_TEST=y
kernel/trace/Kconfig +3 -3
@@ -429,7 +429,7 @@ config BLK_DEV_IO_TRACE If unsure, say N. -config KPROBE_EVENT +config KPROBE_EVENTS depends on KPROBES depends on HAVE_REGS_AND_STACK_ACCESS_API bool "Enable kprobes-based dynamic events"
@@ -447,7 +447,7 @@ config KPROBE_EVENT This option is also required by perf-probe subcommand of perf tools. If you want to use perf tools, this option is strongly recommended. -config UPROBE_EVENT +config UPROBE_EVENTS bool "Enable uprobes-based dynamic events" depends on ARCH_SUPPORTS_UPROBES depends on MMU
@@ -466,7 +466,7 @@ config UPROBE_EVENT config BPF_EVENTS depends on BPF_SYSCALL - depends on (KPROBE_EVENT || UPROBE_EVENT) && PERF_EVENTS + depends on (KPROBE_EVENTS || UPROBE_EVENTS) && PERF_EVENTS bool default y help
kernel/trace/Makefile +2 -2
@@ -57,7 +57,7 @@ obj-$(CONFIG_EVENT_TRACING) += trace_events_filter.o obj-$(CONFIG_EVENT_TRACING) += trace_events_trigger.o obj-$(CONFIG_HIST_TRIGGERS) += trace_events_hist.o obj-$(CONFIG_BPF_EVENTS) += bpf_trace.o -obj-$(CONFIG_KPROBE_EVENT) += trace_kprobe.o +obj-$(CONFIG_KPROBE_EVENTS) += trace_kprobe.o obj-$(CONFIG_TRACEPOINTS) += power-traces.o ifeq ($(CONFIG_PM),y) obj-$(CONFIG_TRACEPOINTS) += rpm-traces.o
@@ -66,7 +66,7 @@ ifeq ($(CONFIG_TRACING),y) obj-$(CONFIG_KGDB_KDB) += trace_kdb.o endif obj-$(CONFIG_PROBE_EVENTS) += trace_probe.o -obj-$(CONFIG_UPROBE_EVENT) += trace_uprobe.o +obj-$(CONFIG_UPROBE_EVENTS) += trace_uprobe.o obj-$(CONFIG_TRACEPOINT_BENCHMARK) += trace_benchmark.o
kernel/trace/trace.c +5 -5
@@ -4348,22 +4348,22 @@ static const char readme_msg[] "\t\t\t traces\n"#endif #endif /* CONFIG_STACK_TRACER */ -#ifdef CONFIG_KPROBE_EVENT +#ifdef CONFIG_KPROBE_EVENTS " kprobe_events\t\t- Add/remove/show the kernel dynamic events\n" "\t\t\t Write into this file to define/undefine new trace events.\n"#endif -#ifdef CONFIG_UPROBE_EVENT +#ifdef CONFIG_UPROBE_EVENTS " uprobe_events\t\t- Add/remove/show the userspace dynamic events\n" "\t\t\t Write into this file to define/undefine new trace events.\n"#endif -#if defined(CONFIG_KPROBE_EVENT ) || defined(CONFIG_UPROBE_EVENT ) +#if defined(CONFIG_KPROBE_EVENTS ) || defined(CONFIG_UPROBE_EVENTS )"\t accepts: event-definitions (one definition per line)\n" "\t Format: p|r[:[<group>/]<event>] <place> [<args>]\n" "\t -:[<group>/]<event>\n" -#ifdef CONFIG_KPROBE_EVENT +#ifdef CONFIG_KPROBE_EVENTS "\t place: [<module>:]<symbol>[+<offset>]|<memaddr>\n"#endif -#ifdef CONFIG_UPROBE_EVENT +#ifdef CONFIG_UPROBE_EVENTS "\t place: <path>:<offset>\n" #endif"\t args: <name>þtcharg[:type]\n"
kernel/trace/trace_probe.h +2 -2
@@ -248,7 +248,7 @@ ASSIGN_FETCH_FUNC(file_offset, ftype), \#define FETCH_TYPE_STRING 0#define FETCH_TYPE_STRSIZE 1 -#ifdef CONFIG_KPROBE_EVENT +#ifdef CONFIG_KPROBE_EVENTS struct symbol_cache ;unsigned long update_symbol_cache (struct symbol_cache *sc);void free_symbol_cache (struct symbol_cache *sc);
@@ -278,7 +278,7 @@ alloc_symbol_cache(const char *sym, long offset) {return NULL ; } -#endif /* CONFIG_KPROBE_EVENT */ +#endif /* CONFIG_KPROBE_EVENTS */ struct probe_arg {struct fetch_param fetch;
Signature · 1 line
2.9.3
tip-bot for Anton Blanchard
merge bot[tip:perf/urgent] perf/core: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
perf/core: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
Commit-ID: 6b0b7551428e4caae1e2c023a529465a9a9ae2d4 Gitweb: http://git.kernel.org/tip/6b0b7551428e4caae1e2c023a529465a9a9ae2d4 Author: Anton Blanchard <[email protected]> AuthorDate: Thu, 16 Feb 2017 17:00:50 +1100 Committer: Ingo Molnar <[email protected]> CommitDate: Wed, 1 Mar 2017 10:26:39 +0100
perf/core: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS.
Consistently use the plurals.
--- Documentation/trace/kprobetrace.txt | 2 +- Documentation/trace/uprobetracer.txt | 2 +- arch/powerpc/configs/85xx/kmp204x_defconfig | 2 +- arch/s390/configs/default_defconfig | 2 +- arch/s390/configs/gcov_defconfig | 2 +- arch/s390/configs/performance_defconfig | 2 +- arch/s390/defconfig | 2 +- kernel/trace/Kconfig | 6 +++--- kernel/trace/Makefile | 4 ++-- kernel/trace/trace.c | 10 +++++----- kernel/trace/trace_probe.h | 4 ++-- 11 files changed, 19 insertions(+), 19 deletions(-)
Documentation/trace/kprobetrace.txt +1 -1
@@ -12,7 +12,7 @@ kprobes can probe (this means, all functions body except for __kprobes functions). Unlike the Tracepoint based event, this can be added and removed dynamically, on the fly. -To enable this feature, build your kernel with CONFIG_KPROBE_EVENT=y. +To enable this feature, build your kernel with CONFIG_KPROBE_EVENTS=y. Similar to the events tracer, this doesn't need to be activated via current_tracer. Instead of that, add probe points via
Documentation/trace/uprobetracer.txt +1 -1
@@ -7,7 +7,7 @@ Overview -------- Uprobe based trace events are similar to kprobe based trace events. -To enable this feature, build your kernel with CONFIG_UPROBE_EVENT=y. +To enable this feature, build your kernel with CONFIG_UPROBE_EVENTS=y. Similar to the kprobe-event tracer, this doesn't need to be activated via current_tracer. Instead of that, add probe points via
arch/powerpc/configs/85xx/kmp204x_defconfig +1 -1
@@ -210,7 +210,7 @@ CONFIG_DEBUG_SHIRQ=y CONFIG_DETECT_HUNG_TASK=y CONFIG_SCHEDSTATS=y CONFIG_RCU_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_CRYPTO_NULL=y CONFIG_CRYPTO_PCBC=m CONFIG_CRYPTO_MD4=y
arch/s390/configs/default_defconfig +1 -1
@@ -609,7 +609,7 @@ CONFIG_SCHED_TRACER=y CONFIG_FTRACE_SYSCALLS=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_HIST_TRIGGERS=y CONFIG_TRACE_ENUM_MAP_FILE=y
arch/s390/configs/gcov_defconfig +1 -1
@@ -560,7 +560,7 @@ CONFIG_SCHED_TRACER=y CONFIG_FTRACE_SYSCALLS=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_HIST_TRIGGERS=y CONFIG_TRACE_ENUM_MAP_FILE=y
arch/s390/configs/performance_defconfig +1 -1
@@ -558,7 +558,7 @@ CONFIG_SCHED_TRACER=y CONFIG_FTRACE_SYSCALLS=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_HIST_TRIGGERS=y CONFIG_TRACE_ENUM_MAP_FILE=y
arch/s390/defconfig +1 -1
@@ -179,7 +179,7 @@ CONFIG_FTRACE_SYSCALLS=y CONFIG_TRACER_SNAPSHOT_PER_CPU_SWAP=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_TRACE_ENUM_MAP_FILE=y CONFIG_KPROBES_SANITY_TEST=y
kernel/trace/Kconfig +3 -3
@@ -429,7 +429,7 @@ config BLK_DEV_IO_TRACE If unsure, say N. -config KPROBE_EVENT +config KPROBE_EVENTS depends on KPROBES depends on HAVE_REGS_AND_STACK_ACCESS_API bool "Enable kprobes-based dynamic events"
@@ -447,7 +447,7 @@ config KPROBE_EVENT This option is also required by perf-probe subcommand of perf tools. If you want to use perf tools, this option is strongly recommended. -config UPROBE_EVENT +config UPROBE_EVENTS bool "Enable uprobes-based dynamic events" depends on ARCH_SUPPORTS_UPROBES depends on MMU
@@ -466,7 +466,7 @@ config UPROBE_EVENT config BPF_EVENTS depends on BPF_SYSCALL - depends on (KPROBE_EVENT || UPROBE_EVENT) && PERF_EVENTS + depends on (KPROBE_EVENTS || UPROBE_EVENTS) && PERF_EVENTS bool default y help
kernel/trace/Makefile +2 -2
@@ -57,7 +57,7 @@ obj-$(CONFIG_EVENT_TRACING) += trace_events_filter.o obj-$(CONFIG_EVENT_TRACING) += trace_events_trigger.o obj-$(CONFIG_HIST_TRIGGERS) += trace_events_hist.o obj-$(CONFIG_BPF_EVENTS) += bpf_trace.o -obj-$(CONFIG_KPROBE_EVENT) += trace_kprobe.o +obj-$(CONFIG_KPROBE_EVENTS) += trace_kprobe.o obj-$(CONFIG_TRACEPOINTS) += power-traces.o ifeq ($(CONFIG_PM),y) obj-$(CONFIG_TRACEPOINTS) += rpm-traces.o
@@ -66,7 +66,7 @@ ifeq ($(CONFIG_TRACING),y) obj-$(CONFIG_KGDB_KDB) += trace_kdb.o endif obj-$(CONFIG_PROBE_EVENTS) += trace_probe.o -obj-$(CONFIG_UPROBE_EVENT) += trace_uprobe.o +obj-$(CONFIG_UPROBE_EVENTS) += trace_uprobe.o obj-$(CONFIG_TRACEPOINT_BENCHMARK) += trace_benchmark.o
kernel/trace/trace.c +5 -5
@@ -4341,22 +4341,22 @@ static const char readme_msg[] = "\t\t\t traces\n"#endif #endif /* CONFIG_STACK_TRACER */ -#ifdef CONFIG_KPROBE_EVENT +#ifdef CONFIG_KPROBE_EVENTS " kprobe_events\t\t- Add/remove/show the kernel dynamic events\n" "\t\t\t Write into this file to define/undefine new trace events.\n"#endif -#ifdef CONFIG_UPROBE_EVENT +#ifdef CONFIG_UPROBE_EVENTS " uprobe_events\t\t- Add/remove/show the userspace dynamic events\n" "\t\t\t Write into this file to define/undefine new trace events.\n"#endif -#if defined(CONFIG_KPROBE_EVENT ) || defined(CONFIG_UPROBE_EVENT ) +#if defined(CONFIG_KPROBE_EVENTS ) || defined(CONFIG_UPROBE_EVENTS )"\t accepts: event-definitions (one definition per line)\n" "\t Format: p|r[:[<group>/]<event>] <place> [<args>]\n" "\t -:[<group>/]<event>\n" -#ifdef CONFIG_KPROBE_EVENT +#ifdef CONFIG_KPROBE_EVENTS "\t place: [<module>:]<symbol>[+<offset>]|<memaddr>\n"#endif -#ifdef CONFIG_UPROBE_EVENT +#ifdef CONFIG_UPROBE_EVENTS "\t place: <path>:<offset>\n" #endif"\t args: <name>=fetcharg[:type]\n"
kernel/trace/trace_probe.h +2 -2
@@ -248,7 +248,7 @@ ASSIGN_FETCH_FUNC(file_offset, ftype), \#define FETCH_TYPE_STRING 0#define FETCH_TYPE_STRSIZE 1 -#ifdef CONFIG_KPROBE_EVENT +#ifdef CONFIG_KPROBE_EVENTS struct symbol_cache ;unsigned long update_symbol_cache (struct symbol_cache *sc);void free_symbol_cache (struct symbol_cache *sc);
@@ -278,7 +278,7 @@ alloc_symbol_cache(const char *sym, long offset) {return NULL ; } -#endif /* CONFIG_KPROBE_EVENT */ +#endif /* CONFIG_KPROBE_EVENTS */ struct probe_arg {struct fetch_param fetch;
change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
In reply to Anton BlanchardQuoted 7 lines · Anton Blanchard
From: Anton Blanchard <[email protected]>
We have uses of
CONFIG_UPROBE_EVENTandCONFIG_KPROBE_EVENTas well asCONFIG_UPROBE_EVENTSandCONFIG_KPROBE_EVENTS. Consistently use the plurals.Signed-off-by Anton Blanchard <[email protected]>
this rename made me notice that UPROBE_EVENTS still defaults to 'n'. this is key feature that all distros enable, so having default 'n' is kinda saying that it's not something that should be turned on or used widely. which is obviously not the case.
imo it's time to change it to 'y'.
Thoughts?
Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
Added more people to the CC list.
Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
Quoted 11 lines · Anton Blanchard
Quoted 3 lines
We have uses of
CONFIG_UPROBE_EVENTandCONFIG_KPROBE_EVENTas well asCONFIG_UPROBE_EVENTSandCONFIG_KPROBE_EVENTS. Consistently use the plurals.this rename made me notice that
UPROBE_EVENTSstill defaults to 'n'. this is key feature that all distros enable, so having default 'n' is kinda saying that it's not something that should be turned on or used widely. which is obviously not the case.
imo it's time to change it to 'y'.
Thoughts?
Agreed, I also found it strange that it was disabled by default when I recently did a 'make oldconfig' :-\
- Arnaldo
Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
Quoted 15 lines · Arnaldo Carvalho de Melo
Added more people to the CC list.
Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
Quoted 11 lines · Anton Blanchard
Quoted 3 lines
We have uses of
CONFIG_UPROBE_EVENTandCONFIG_KPROBE_EVENTas well asCONFIG_UPROBE_EVENTSandCONFIG_KPROBE_EVENTS. Consistently use the plurals.this rename made me notice that
UPROBE_EVENTSstill defaults to 'n'. this is key feature that all distros enable, so having default 'n' is kinda saying that it's not something that should be turned on or used widely. which is obviously not the case.
imo it's time to change it to 'y'.
Thoughts?
Quoted 2 lines
Agreed, I also found it strange that it was disabled by default when I recently did a 'make oldconfig' :-\
Debian stretch, Ubuntu 16.10, Fedora 26 all have it enabled. Perhaps it should default on.
Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
Quoted 16 lines · David Ahern
Quoted 15 lines · Arnaldo Carvalho de Melo
Added more people to the CC list.
Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
Quoted 11 lines · Anton Blanchard
Quoted 3 lines
We have uses of
CONFIG_UPROBE_EVENTandCONFIG_KPROBE_EVENTas well asCONFIG_UPROBE_EVENTSandCONFIG_KPROBE_EVENTS. Consistently use the plurals.this rename made me notice that
UPROBE_EVENTSstill defaults to 'n'. this is key feature that all distros enable, so having default 'n' is kinda saying that it's not something that should be turned on or used widely. which is obviously not the case.
imo it's time to change it to 'y'.
Thoughts?
Quoted 5 lines
Quoted 2 lines
Agreed, I also found it strange that it was disabled by default when I recently did a 'make oldconfig' :-\
Debian stretch, Ubuntu 16.10, Fedora 26 all have it enabled. Perhaps it should default on.
+1
Archlinux also has it enabled.
Thanks,
Namhyung
Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
In reply to Arnaldo Carvalho de MeloQuoted 15 lines
Added more people to the CC list.
Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
Quoted 11 lines · Anton Blanchard
Quoted 3 lines
We have uses of
CONFIG_UPROBE_EVENTandCONFIG_KPROBE_EVENTas well asCONFIG_UPROBE_EVENTSandCONFIG_KPROBE_EVENTS. Consistently use the plurals.this rename made me notice that
UPROBE_EVENTSstill defaults to 'n'. this is key feature that all distros enable, so having default 'n' is kinda saying that it's not something that should be turned on or used widely. which is obviously not the case.
imo it's time to change it to 'y'.
Thoughts?
Quoted 2 lines
Agreed, I also found it strange that it was disabled by default when I recently did a 'make oldconfig' :-\
Yes, we could make it default on.
Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
In reply to Arnaldo Carvalho de MeloQuoted 14 lines · Arnaldo Carvalho de Melo
Added more people to the CC list.
Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
Quoted 11 lines · Anton Blanchard
Quoted 3 lines
We have uses of
CONFIG_UPROBE_EVENTandCONFIG_KPROBE_EVENTas well asCONFIG_UPROBE_EVENTSandCONFIG_KPROBE_EVENTS. Consistently use the plurals.this rename made me notice that
UPROBE_EVENTSstill defaults to 'n'. this is key feature that all distros enable, so having default 'n' is kinda saying that it's not something that should be turned on or used widely. which is obviously not the case.
imo it's time to change it to 'y'.
Thoughts?
Quoted 4 lines
Agreed, I also found it strange that it was disabled by default when I recently did a 'make oldconfig' :-\
- Arnaldo
+1.
Some internal distros in my company now have started discussing supporting user space probing. Turning uprobes on for upstream kernel helps us saving a lot of discussion.
Thank you.
Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
In reply to Arnaldo Carvalho de MeloQuoted 15 lines · Arnaldo Carvalho de Melo
Added more people to the CC list.
Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
Quoted 11 lines · Anton Blanchard
Quoted 3 lines
We have uses of
CONFIG_UPROBE_EVENTandCONFIG_KPROBE_EVENTas well asCONFIG_UPROBE_EVENTSandCONFIG_KPROBE_EVENTS. Consistently use the plurals.this rename made me notice that
UPROBE_EVENTSstill defaults to 'n'. this is key feature that all distros enable, so having default 'n' is kinda saying that it's not something that should be turned on or used widely. which is obviously not the case.
imo it's time to change it to 'y'.
Thoughts?
Quoted 2 lines
Agreed, I also found it strange that it was disabled by default when I recently did a 'make oldconfig' :-\
Agreed, someone please send a patch (or feel free to include it in the perf tooling tree) to switch the default around.
Thanks,
Ingo
Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
Em Thu, Mar 16, 2017 at 07:40:55AM +0100, Ingo Molnar escreveu:
Quoted 18 lines · Arnaldo Carvalho de Melo
Quoted 16 lines
Added more people to the CC list.
Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
Quoted 11 lines · Anton Blanchard
Quoted 3 lines
We have uses of
CONFIG_UPROBE_EVENTandCONFIG_KPROBE_EVENTas well asCONFIG_UPROBE_EVENTSandCONFIG_KPROBE_EVENTS. Consistently use the plurals.this rename made me notice that
UPROBE_EVENTSstill defaults to 'n'. this is key feature that all distros enable, so having default 'n' is kinda saying that it's not something that should be turned on or used widely. which is obviously not the case.
imo it's time to change it to 'y'.
Thoughts?
Quoted 5 lines
Quoted 2 lines
Agreed, I also found it strange that it was disabled by default when I recently did a 'make oldconfig' :-\
Agreed, someone please send a patch (or feel free to include it in the perf tooling tree) to switch the default around.
Ok, will collect the agreements as Acked-by tags and put it in perf/core.
- Arnaldo
Masami Hiramatsu
maintainerRe: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
In reply to Arnaldo Carvalho de MeloQuoted 15 lines · On Wed, 15 Mar 2017 22:06:51 -0300 Arnaldo Carvalho de Melo <[email protected]>…
Added more people to the CC list.
Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
Quoted 11 lines · Anton Blanchard
Quoted 3 lines
We have uses of
CONFIG_UPROBE_EVENTandCONFIG_KPROBE_EVENTas well asCONFIG_UPROBE_EVENTSandCONFIG_KPROBE_EVENTS. Consistently use the plurals.this rename made me notice that
UPROBE_EVENTSstill defaults to 'n'. this is key feature that all distros enable, so having default 'n' is kinda saying that it's not something that should be turned on or used widely. which is obviously not the case.
imo it's time to change it to 'y'.
Thoughts?
Quoted 2 lines
Agreed, I also found it strange that it was disabled by default when I recently did a 'make oldconfig' :-\
Agreed. Now uprobes is enough stable. (and widely used)
Thanks!
Signature · 1 line
Masami Hiramatsu <[email protected]>
tip-bot for Arnaldo Carvalho de Melo
merge bot[tip:perf/core] uprobes: Default UPROBES_EVENTS to Y
In reply to Alexei Starovoitovuprobes: Default UPROBES_EVENTS to Y
Commit-ID: 61f35d750683b21e9e3836e309195c79c1daed74 Gitweb: http://git.kernel.org/tip/61f35d750683b21e9e3836e309195c79c1daed74 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Thu, 16 Mar 2017 12:42:02 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 16 Mar 2017 12:42:02 -0300
uprobes: Default UPROBES_EVENTS to Y
As it is already turned on by most distros, so just flip the default to Y.
--- kernel/trace/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/Kconfig +1 -1
@@ -455,7 +455,7 @@ config UPROBE_EVENTS select UPROBES select PROBE_EVENTS select TRACING - default n + default y help This allows the user to add tracing events on top of userspace dynamic events (similar to tracepoints) on the fly via the trace