trace: Correct comments about list of pages in buffer
PATCH 1/1 trace: Correct comments about list of pages in buffer
Comments related to list of pages in the ring buffer seem to be incorrect. This patch corrects them.
Signed-off-by Joel Fernandes <[email protected]>
--- kernel/trace/trace.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
kernel/trace/trace.c +5 -5
@@ -262,11 +262,11 @@ unsigned long long ns2usecs(u64 nsec)/* * The global_trace is the descriptor that holds the tracing * buffers for the live tracing. For each CPU, it contains -* a link list of pages that will store trace entries. The -* page descriptor of the pages in the memory is used to hold -* the link list by linking the lru item in the page descriptor -* to each of the pages in the buffer per CPU. -* +* a link list of pages that will store trace entries. +* Each page is wrapped by a buffer_page descriptor which contains +* a list element used to hold the list of pages by linking with +* other list elements of other buffer_page descriptors (for each +* of the pages) in the ring buffer per CPU. * For each active CPU there is a data field that holds the * pages for the buffer for that CPU. Each CPU has the same number * of pages allocated for its buffer.
Signature · 1 line
2.11.0.483.g087da7b7c-goog
Steven Rostedt
maintainerQuoted 13 lines · On Thu, 16 Feb 2017 02:17:28 -0800 Joel Fernandes <[email protected]> wrote:
Comments related to list of pages in the ring buffer seem to be incorrect. This patch corrects them.
Signed-off-by Joel Fernandes <[email protected]>--- kernel/trace/trace.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)kernel/trace/trace.c +0
-0
kernel/trace/trace.c unsigned long long ns2usecs(u64 nsec) · line 268
Quoted 7 lines
kernel/trace/trace.c +0
-4@@ -262,11 +262,11 @@ unsigned long long ns2usecs(u64 nsec)/* * The global_trace is the descriptor that holds the tracing * buffers for the live tracing. For each CPU, it contains -* a link list of pages that will store trace entries. The -* page descriptor of the pages in the memory is used to hold -* the link list by linking the lru item in the page descriptor -* to each of the pages in the buffer per CPU.
Wow, that's a description of the very first (and poor) implementation of the ring buffer.
kernel/trace/trace.c unsigned long long ns2usecs(u64 nsec) · line 269
Quoted 6 lines
kernel/trace/trace.c +5
-1-* +* a link list of pages that will store trace entries. +* Each page is wrapped by a buffer_page descriptor which contains +* a list element used to hold the list of pages by linking with +* other list elements of other buffer_page descriptors (for each +* of the pages) in the ring buffer per CPU.
Actually, this comment doesn't even belong here anymore. The code lives elsewhere.
Want to send another patch that just nukes this?
Thanks!
-- Steve
Quoted 3 lines
kernel/trace/trace.c +0
-0* For each active CPU there is a data field that holds the * pages for the buffer for that CPU. Each CPU has the same number * of pages allocated for its buffer.