drm/msm/dsi: Fix bug in dsi_mgr_phy_enable
PATCH 1/1 drm/msm/dsi: Fix bug in dsi_mgr_phy_enable
A recent commit introduces a bug in dsi_mgr_phy_enable. In the non dual DSI mode, we reset the mdsi (master DSI) PHY. This isn't right since master and slave DSI exist only in dual DSI mode. For the normal mode of operation, we should simply reset the PHY of the DSI device (i.e. msm_dsi) corresponding to the current bridge.
Usage of the wrong DSI pointer also resulted in a static checker warning. That too is resolved with this fix.
--- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/dsi/dsi_manager.c +1 -1
@@ -171,7 +171,7 @@ dsi_mgr_phy_enable(int id, } } }else { -msm_dsi_host_reset_phy (mdsi->host); +msm_dsi_host_reset_phy (msm_dsi->host); ret =enable_phy (msm_dsi, src_pll_id, &shared_timings[id]);if (ret)return ret;
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 6 lines · Archit Taneja
A recent commit introduces a bug in
dsi_mgr_phy_enable. In the non dual DSI mode, we reset the mdsi (master DSI) PHY. This isn't right since master and slave DSI exist only in dual DSI mode. For the normal mode of operation, we should simply reset the PHY of the DSI device (i.e.msm_dsi) corresponding to the current bridge.
Quoted 7 lines
Usage of the wrong DSI pointer also resulted in a static checker warning. That too is resolved with this fix.
Fixes b62aa70a98c5 (drm/msm/dsi: Move PHY operations out of host)Reported-by Dan Carpenter <[email protected]>Signed-off-by Archit Taneja <[email protected]>
Quoted 21 lines
--- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/dsi/dsi_manager.c +1
-2@@ -171,7 +171,7 @@ dsi_mgr_phy_enable(int id, } } }else { -msm_dsi_host_reset_phy (mdsi->host); +msm_dsi_host_reset_phy (msm_dsi->host); ret =enable_phy (msm_dsi, src_pll_id, &shared_timings[id]);if (ret)return ret; --The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation