Skip to contentSkip to conversation

staging: rtl8192u: Replace symbolic permissions with octal permissions

PATCH New simran singhal 1 participant 1 message Feb 16, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 staging: rtl8192u: Replace symbolic permissions with octal permissions

Octal permissions should be used instead of symbolic ones for easier reading.

WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
This warning is detected by checkpatch.pl

---

v2:
-Added more information about patch -Reworked for putting proc_create() in one line

 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +1 -2
index a9a92d8..503ba7f 100644
@@ -283,8 +283,7 @@ int __init ieee80211_debug_init(void)
 				" proc directory\n");
 		return -EIO;
 	}
-	e = proc_create("debug_level", S_IRUGO | S_IWUSR,
-			      ieee80211_proc, &fops);
+	e = proc_create("debug_level", 0644, ieee80211_proc, &fops);
 	if (!e) {
 		remove_proc_entry(DRV_NAME, init_net.proc_net);
 		ieee80211_proc = NULL;
Signature · 1 line
2.7.4