net/tap: fix coverity warning on strncpy
PATCH v3 1/1 net/tap: fix coverity warning on strncpy
Calling strncpy with a maximum size argument of 16 bytes on destination array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the destination string unterminated.
---
v3 - convert strncpy to use snprintf instead.
v2 - fix the checkpatch warning no spaces around '-' v1 - fix coverity warning on strncpy using invalid length.
drivers/net/tap/rte_eth_tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/tap/rte_eth_tap.c +1 -1
@@ -297,7 +297,7 @@ tap_link_set_flags(struct pmd_internals *pmd, short flags, int add)return -1 ; }memset (&ifr,0 ,sizeof (ifr)); -strncpy (ifr.ifr_name, pmd->name,IFNAMSIZ ); +strncpy (ifr.ifr_name, pmd->name,IFNAMSIZ -1 ); err =ioctl (s,SIOCGIFFLAGS , &ifr);if (err <0 ) { RTE_LOG(WARNING, PMD, "Unable to get %s device flags: %s\n",
Signature · 1 line
2.8.0.GIT
Quoted 21 lines · Keith Wiles
Calling strncpy with a maximum size argument of 16 bytes on destination array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the destination string unterminated.
Signed-off-by Keith Wiles <[email protected]>---
v3 - convert strncpy to use snprintf instead.
v2 - fix the checkpatch warning no spaces around '-' v1 - fix coverity warning on strncpy using invalid length.
drivers/net/tap/rte_eth_tap.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/tap/rte_eth_tap.c +0
-0
drivers/net/tap/rte_eth_tap.c tap_link_set_flags(struct pmd_internals *pmd, short flags, int add) · line 303
Quoted 8 lines
drivers/net/tap/rte_eth_tap.c +1
-1@@ -297,7 +297,7 @@ tap_link_set_flags(struct pmd_internals *pmd, short flags, int add)return -1 ; }memset (&ifr,0 ,sizeof (ifr)); -strncpy (ifr.ifr_name, pmd->name,IFNAMSIZ ); +strncpy (ifr.ifr_name, pmd->name,IFNAMSIZ -1 ); err =ioctl (s,SIOCGIFFLAGS , &ifr);if (err <0 ) { RTE_LOG(WARNING, PMD, "Unable to get %s device flags: %s\n”,
NAK :-( forgot to finish the rebase
Quoted 3 lines
Signature · 1 line
2.8.0.GIT
Regards,
Keith