staging: xgifb: function definition argument should also have an identifier name'
PATCH 1/1 staging: xgifb: function definition argument should also have an identifier name'
function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name.
--- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/xgifb/vb_init.h +1 -1
@@ -1,6 +1,6 @@#ifndef _VBINIT_#define _VBINIT_unsigned char XGIInitNew (struct pci_dev *pdev); -void XGIRegInit (struct vb_device_info *,unsigned long ); +void XGIRegInit (struct vb_device_info *pVBInfo,unsigned long BaseAddr);#endif
Signature · 1 line
2.11.0
Quoted 2 lines · Arushi Singhal
function definition argument 'struct
vb_device_info*' and 'unsigned long' should also have an identifier name.
This could be a bit more clear as "Add variable names to function prototype parameter list."
Quoted 11 lines
Signed-off-by Arushi Singhal <[email protected]>--- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/xgifb/vb_init.h +0
-0
drivers/staging/xgifb/vb_init.h line 4
Quoted 5 lines
drivers/staging/xgifb/vb_init.h +1
-1@@ -1,6 +1,6 @@#ifndef _VBINIT_#define _VBINIT_unsigned char XGIInitNew (struct pci_dev *pdev); -void XGIRegInit (struct vb_device_info *,unsigned long ); +void XGIRegInit (struct vb_device_info *pVBInfo,unsigned long BaseAddr);
Actually, you should use the same names as found in the definition of the function, which seem to be:
void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr)
julia
Quoted 12 lines
drivers/staging/xgifb/vb_init.h +0
-1#endif --2.11.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218132356.GA4907%40arushi-HP-Pavilion-Notebook.
For more options, visit https://groups.google.com/d/optout.