Skip to contentSkip to conversation

ipv6: release dst on error in ip6_dst_lookup_tail

PATCH Applied Willem de Bruijn 3 participants 3 messages Feb 19, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ipv6: release dst on error in ip6_dst_lookup_tail

From: Willem de Bruijn <[email protected]>

If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped check, release the dst before returning an error.

Fixes ec5e3b0a1d41 ("ipv6: Inhibit IPv4-mapped src address on the wire.")
---
 net/ipv6/ip6_output.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
net/ipv6/ip6_output.c +4 -2
index e164684456df..7cebee58e55b 100644
@@ -1022,8 +1022,10 @@ static int ip6_dst_lookup_tail(struct net *net, const struct sock *sk,
 	}
 #endif
 	if (ipv6_addr_v4mapped(&fl6->saddr) &&
-	    !(ipv6_addr_v4mapped(&fl6->daddr) || ipv6_addr_any(&fl6->daddr)))
-		return -EAFNOSUPPORT;
+	    !(ipv6_addr_v4mapped(&fl6->daddr) || ipv6_addr_any(&fl6->daddr))) {
+		err = -EAFNOSUPPORT;
+		goto out_err_release;
+	}
 
 	return 0;
 
Signature · 1 line
2.11.0.483.g087da7b7c-goog