Skip to contentSkip to conversation

Add model data for Dell Precision 3510 trackpad.

PATCH In review John L. Preston 4 participants 9 messages Feb 19, 2017 – Feb 21, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add model data for Dell Precision 3510 trackpad.

---
 drivers/input/mouse/alps.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/mouse/alps.c +1 -0
index 328edc8c8786..c0a4edefe54d 100644
@@ -139,6 +139,7 @@ static const struct alps_model_info alps_model_data[] = {
 	{ { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } },				/* Toshiba Tecra A11-11L */
 	{ { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
+	{ { 0x73, 0x03, 0x28 }, 0x13, { ALPS_PROTO_V8, 0x18, 0x18, 0 } },			/* Dell Precision 3510 */
 };
 
 static const struct alps_protocol_info alps_v3_protocol_data = {
Signature · 1 line
2.11.1
#1 lore raw
Quoted 9 lines · On Sunday 19 February 2017 13:16:34 John L. Preston wrote:
---
 drivers/input/mouse/alps.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/mouse/alps.c +0 -0
index 328edc8c8786..c0a4edefe54d 100644

drivers/input/mouse/alps.c static const struct alps_model_info alps_model_data[] = { · line 145

Quoted 7 lines
drivers/input/mouse/alps.c +1 -0
@@ -139,6 +139,7 @@ static const struct alps_model_info alps_model_data[] = {
 	{ { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } },				/* Toshiba Tecra A11-11L */
 	{ { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
+	{ { 0x73, 0x03, 0x28 }, 0x13, { ALPS_PROTO_V8, 0x18, 0x18, 0 } },			/* Dell Precision 3510 */
 };
 
 static const struct alps_protocol_info alps_v3_protocol_data = {

Hi John! This is not a correct place do add new proto data. I already proposed reducing this table to just for PROTO_V2, but Dmitry was not happy about it.

Anyway, look at function alps_identify() where is detection for ALPS_V8:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/input/mouse/alps.c?h=v4.10-rc8#n2829

V8 is already detected when e7 is (0x73, 0x03, 0x28) and ec[1] is 0x01. What are your ec data? Probably ec[1] is not 0x01 as otherwise it should be already detected.

Btw, from where you got your proto data in this patch?

Signature · 2 lines
Pali Rohár
[email protected]
#2 lore raw
Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Sunday 19 February 2017 13:16:34 John L. Preston wrote:
---
 drivers/input/mouse/alps.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/mouse/alps.c +0 -0
index 328edc8c8786..c0a4edefe54d 100644
@@ -139,6 +139,7 @@ static const struct alps_model_info 
 alps_model_data[] = {
 	{ { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } },				/* 

Toshiba Tecra A11-11L */

drivers/input/mouse/alps.c +1 -0
 	{ { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
+	{ { 0x73, 0x03, 0x28 }, 0x13, { ALPS_PROTO_V8, 0x18, 0x18, 0 } 

}, /* Dell Precision 3510 */
};

Quoted 5 lines
Quoted 1 line

static const struct alps_protocol_info alps_v3_protocol_data = {

Hi John! This is not a correct place do add new proto data. I already proposed reducing this table to just for PROTO_V2, but Dmitry was not happy about it.

Hi Pali. :)

Quoted 7 lines

Anyway, look at function alps_identify() where is detection for ALPS_V8:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/input/mouse/alps.c?h=v4.10-rc8#n2829

V8 is already detected when e7 is (0x73, 0x03, 0x28) and ec[1] is 0x01. What are your ec data? Probably ec[1] is not 0x01 as otherwise it should be already detected.

I have just found that code and am confused because that is not the same code I have running on my system. My ec[1] is 0x01 so you are correct, it should already be detected and my patch is unnecessary. Sorry for the inconvenience.

Quoted 2 lines

Btw, from where you got your proto data in this patch?

I pulled it from dmesg:

[john@slate ~]$ dmesg|grep "Unknown ALPS touchpad"

[    3.071891] psmouse serio1: alps: Unknown ALPS touchpad: E7=73 03 28, EC=73 01 13
#3 lore raw

Hi John and Pali,

Quoted 42 lines · John Preston
Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Sunday 19 February 2017 13:16:34 John L. Preston wrote:
---
 drivers/input/mouse/alps.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/mouse/alps.c +0 -0
index 328edc8c8786..c0a4edefe54d 100644
@@ -139,6 +139,7 @@ static const struct alps_model_info
 alps_model_data[] = {
 	{ { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } },				/*

Toshiba Tecra A11-11L */

drivers/input/mouse/alps.c +1 -0
 	{ { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
+	{ { 0x73, 0x03, 0x28 }, 0x13, { ALPS_PROTO_V8, 0x18, 0x18, 0 }

}, /* Dell Precision 3510 */
};

Quoted 5 lines
Quoted 1 line

static const struct alps_protocol_info alps_v3_protocol_data = {

Hi John! This is not a correct place do add new proto data. I already proposed reducing this table to just for PROTO_V2, but Dmitry was not happy about it.

Hi Pali. :)

Quoted 7 lines

Anyway, look at function alps_identify() where is detection for ALPS_V8:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/input/mouse/alps.c?h=v4.10-rc8#n2829

V8 is already detected when e7 is (0x73, 0x03, 0x28) and ec[1] is 0x01. What are your ec data? Probably ec[1] is not 0x01 as otherwise it should be already detected.

I have just found that code and am confused because that is not the same code I have running on my system. My ec[1] is 0x01 so you are correct, it should already be detected and my patch is unnecessary. Sorry for the inconvenience.

Quoted 1 line
Quoted 7 lines
Quoted 1 line

Btw, from where you got your proto data in this patch?

I pulled it from dmesg:

[john@slate ~]$ dmesg|grep "Unknown ALPS touchpad"

[    3.071891] psmouse serio1: alps: Unknown ALPS touchpad: E7=73 03 28,

EC=73 01 13

There are other open bugs mentioning the same problem, with similar ALPS devices:
https://bugzilla.kernel.org/show_bug.cgi?id=57841
https://bugzilla.kernel.org/show_bug.cgi?id=43931
https://bugzilla.kernel.org/show_bug.cgi?id=80181
https://bugzilla.kernel.org/show_bug.cgi?id=67941

This one without even a dmesg output:
https://bugzilla.kernel.org/show_bug.cgi?id=84081

Maybe they are related, or also need some touch to let them being discovered as proper devices?

Thanks,
Marcos

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw

Unknown ALPS touchpad

Adding Masaki into discussion.

Quoted 2 lines · On Sunday 19 February 2017 20:01:07 Marcos Paulo de Souza wrote:

There are other open bugs mentioning the same problem, with similar ALPS devices:
https://bugzilla.kernel.org/show_bug.cgi?id=57841

Unknown ALPS touchpad: E7=73 03 50, EC=73 02 02

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=43931

Unknown ALPS touchpad: E7=73 00 14, EC=10 00 64

Should be supported since commit 95f75e91 which was introduced in Linux version v3.13-rc4.

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=80181

Unknown ALPS touchpad: E7=73 03 0a, EC=88 b3 22

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=67941

Unknown ALPS touchpad: E7=73 03 0a, EC=88 b3 18

Quoted 2 lines

This one without even a dmesg output:
https://bugzilla.kernel.org/show_bug.cgi?id=84081

Sorry, this one does not contain any useful information.

Quoted 1 line

Maybe they are related, or also need some touch to let them being discovered as proper devices?

Masaki, can you look at those unknown ALPS touchpad identifiers and provide some information about protocol which they are using?

Basically touchpads with these identifiers are unsupported by last kernel version:

E7=73 03 50, EC=73 02 02
E7=73 03 0a, EC=88 b3 22
E7=73 03 0a, EC=88 b3 18

Signature · 2 lines
Pali Rohár
[email protected]
#5 lore raw

RE: Unknown ALPS touchpad

Hi, Pali,

I know these devices, and they are supported in new kernel. I'm not sure when they are supported from.
In alps.c has below code.

static int alps_identify(struct psmouse *psmouse, struct alps_data *priv) {...
...

		if (e7[0] == 0x73 && e7[1] == 0x03 && e7[2] == 0x50 &&
			   ec[0] == 0x73 && (ec[1] == 0x01 || ec[1] == 0x02)) {
			protocol = &alps_v5_protocol_data;
		} else if (ec[0] == 0x88 &&
			   ((ec[1] & 0xf0) == 0xb0 || (ec[1] & 0xf0) == 0xc0)) {
			protocol = &alps_v7_protocol_data;}
}

E7=73 03 50, EC=73 02 02 <- alps_v5_protocol_data
E7=73 03 0a, EC=88 b3 22 <- alps_v7_protocol_data
E7=73 03 0a, EC=88 b3 18 <- alps_v7_protocol_data

Best Regards,
Masaki Ota
-----Original Message-----
From: Pali Rohár [mailto:[email protected]]
Sent: Tuesday, February 21, 2017 12:51 AM
To: Marcos Paulo de Souza <[email protected]>; 太田 真喜 Masaki Ota <[email protected]>
Cc: John Preston <[email protected]>; Dmitry Torokhov <[email protected]>; [email protected]; [email protected]
Subject: Unknown ALPS touchpad

Adding Masaki into discussion.

Quoted 2 lines · On Sunday 19 February 2017 20:01:07 Marcos Paulo de Souza wrote:

There are other open bugs mentioning the same problem, with similar ALPS devices:
https://bugzilla.kernel.org/show_bug.cgi?id=57841

Unknown ALPS touchpad: E7=73 03 50, EC=73 02 02

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=43931

Unknown ALPS touchpad: E7=73 00 14, EC=10 00 64

Should be supported since commit 95f75e91 which was introduced in Linux version v3.13-rc4.

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=80181

Unknown ALPS touchpad: E7=73 03 0a, EC=88 b3 22

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=67941

Unknown ALPS touchpad: E7=73 03 0a, EC=88 b3 18

Quoted 2 lines

This one without even a dmesg output:
https://bugzilla.kernel.org/show_bug.cgi?id=84081

Sorry, this one does not contain any useful information.

Quoted 1 line

Maybe they are related, or also need some touch to let them being discovered as proper devices?

Masaki, can you look at those unknown ALPS touchpad identifiers and provide some information about protocol which they are using?

Basically touchpads with these identifiers are unsupported by last kernel version:

E7=73 03 50, EC=73 02 02
E7=73 03 0a, EC=88 b3 22
E7=73 03 0a, EC=88 b3 18

--
Pali Rohár
[email protected]

#6 lore raw

Re: Unknown ALPS touchpad

Quoted 9 lines · On Tuesday 21 February 2017 03:10:06 Masaki Ota wrote:

Hi, Pali,

I know these devices, and they are supported in new kernel. I'm not sure when they are supported from.
In alps.c has below code.

static int alps_identify(struct psmouse *psmouse, struct alps_data *priv) {...
...

Quoted 7 lines
		if (e7[0] == 0x73 && e7[1] == 0x03 && e7[2] == 0x50 &&
			   ec[0] == 0x73 && (ec[1] == 0x01 || ec[1] == 0x02)) {
			protocol = &alps_v5_protocol_data;
		} else if (ec[0] == 0x88 &&
			   ((ec[1] & 0xf0) == 0xb0 || (ec[1] & 0xf0) == 0xc0)) {
			protocol = &alps_v7_protocol_data;}
}

Ou, sorry I have missed this checks for ec[0] == 0x88.

Marcos, so conclusion is that all those ALPS devices are already supported by last mainline kernel. So you can close those bug reports. If you need with git blame you can identify commit in which was support added and then you can find in which kernel version was particular commit first time.

Quoted 54 lines

E7=73 03 50, EC=73 02 02 <- alps_v5_protocol_data
E7=73 03 0a, EC=88 b3 22 <- alps_v7_protocol_data
E7=73 03 0a, EC=88 b3 18 <- alps_v7_protocol_data

Best Regards,
Masaki Ota
-----Original Message-----
From: Pali Rohár [mailto:[email protected]]
Sent: Tuesday, February 21, 2017 12:51 AM
To: Marcos Paulo de Souza <[email protected]>; 太田 真喜 Masaki Ota <[email protected]>
Cc: John Preston <[email protected]>; Dmitry Torokhov <[email protected]>; [email protected]; [email protected]
Subject: Unknown ALPS touchpad

Adding Masaki into discussion.

Quoted 2 lines · On Sunday 19 February 2017 20:01:07 Marcos Paulo de Souza wrote:

There are other open bugs mentioning the same problem, with similar ALPS devices:
https://bugzilla.kernel.org/show_bug.cgi?id=57841

Unknown ALPS touchpad: E7=73 03 50, EC=73 02 02

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=43931

Unknown ALPS touchpad: E7=73 00 14, EC=10 00 64

Should be supported since commit 95f75e91 which was introduced in Linux version v3.13-rc4.

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=80181

Unknown ALPS touchpad: E7=73 03 0a, EC=88 b3 22

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=67941

Unknown ALPS touchpad: E7=73 03 0a, EC=88 b3 18

Quoted 2 lines

This one without even a dmesg output:
https://bugzilla.kernel.org/show_bug.cgi?id=84081

Sorry, this one does not contain any useful information.

Quoted 1 line

Maybe they are related, or also need some touch to let them being discovered as proper devices?

Masaki, can you look at those unknown ALPS touchpad identifiers and provide some information about protocol which they are using?

Basically touchpads with these identifiers are unsupported by last kernel version:

E7=73 03 50, EC=73 02 02
E7=73 03 0a, EC=88 b3 22
E7=73 03 0a, EC=88 b3 18

--
Pali Rohár
[email protected]

Signature · 2 lines
Pali Rohár
[email protected]
#7 lore raw

Re: Unknown ALPS touchpad

Quoted 18 lines · Pali Rohár
Quoted 9 lines · On Tuesday 21 February 2017 03:10:06 Masaki Ota wrote:

Hi, Pali,

I know these devices, and they are supported in new kernel. I'm not sure when they are supported from.
In alps.c has below code.

static int alps_identify(struct psmouse *psmouse, struct alps_data *priv) {...
...

Quoted 7 lines
		if (e7[0] == 0x73 && e7[1] == 0x03 && e7[2] == 0x50 &&
			   ec[0] == 0x73 && (ec[1] == 0x01 || ec[1] == 0x02)) {
			protocol = &alps_v5_protocol_data;
		} else if (ec[0] == 0x88 &&
			   ((ec[1] & 0xf0) == 0xb0 || (ec[1] & 0xf0) == 0xc0)) {
			protocol = &alps_v7_protocol_data;}
}
Quoted 7 lines

Ou, sorry I have missed this checks for ec[0] == 0x88.

Marcos, so conclusion is that all those ALPS devices are already supported by last mainline kernel. So you can close those bug reports. If you need with git blame you can identify commit in which was support added and then you can find in which kernel version was particular commit first time.

Thanks Pali and Masaki, I closed all mentioned commits, pointing the right kernel version that supports such devices.

Quoted 59 lines
Quoted 55 lines

E7=73 03 50, EC=73 02 02 <- alps_v5_protocol_data
E7=73 03 0a, EC=88 b3 22 <- alps_v7_protocol_data
E7=73 03 0a, EC=88 b3 18 <- alps_v7_protocol_data

Best Regards,
Masaki Ota
-----Original Message-----
From: Pali Rohár [mailto:[email protected]]
Sent: Tuesday, February 21, 2017 12:51 AM
To: Marcos Paulo de Souza <[email protected]>; 太田 真喜 Masaki Ota <[email protected]>
Cc: John Preston <[email protected]>; Dmitry Torokhov <[email protected]>; [email protected]; [email protected]
Subject: Unknown ALPS touchpad

Adding Masaki into discussion.

Quoted 2 lines · On Sunday 19 February 2017 20:01:07 Marcos Paulo de Souza wrote:

There are other open bugs mentioning the same problem, with similar ALPS devices:
https://bugzilla.kernel.org/show_bug.cgi?id=57841

Unknown ALPS touchpad: E7=73 03 50, EC=73 02 02

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=43931

Unknown ALPS touchpad: E7=73 00 14, EC=10 00 64

Should be supported since commit 95f75e91 which was introduced in Linux version v3.13-rc4.

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=80181

Unknown ALPS touchpad: E7=73 03 0a, EC=88 b3 22

Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=67941

Unknown ALPS touchpad: E7=73 03 0a, EC=88 b3 18

Quoted 2 lines

This one without even a dmesg output:
https://bugzilla.kernel.org/show_bug.cgi?id=84081

Sorry, this one does not contain any useful information.

Quoted 1 line

Maybe they are related, or also need some touch to let them being discovered as proper devices?

Masaki, can you look at those unknown ALPS touchpad identifiers and provide some information about protocol which they are using?

Basically touchpads with these identifiers are unsupported by last kernel version:

E7=73 03 50, EC=73 02 02
E7=73 03 0a, EC=88 b3 22
E7=73 03 0a, EC=88 b3 18

--
Pali Rohár
[email protected]

Signature · 2 lines
Pali Rohár
[email protected]
#8 lore raw
In reply to John Preston
Quoted 42 lines · On Sunday 19 February 2017 15:24:58 John Preston wrote:
Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Sunday 19 February 2017 13:16:34 John L. Preston wrote:

---
drivers/input/mouse/alps.c | 1 +

1 file changed, 1 insertion(+)
drivers/input/mouse/alps.c +0 -0
index 328edc8c8786..c0a4edefe54d 100644
@@ -139,6 +139,7 @@ static const struct alps_model_info
 alps_model_data[] = {
 	{ { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } },				/* Toshiba

Tecra A11-11L */

	{ { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
drivers/input/mouse/alps.c +1 -0
+	{ { 0x73, 0x03, 0x28 }, 0x13, { ALPS_PROTO_V8, 0x18, 0x18, 0 } },			/*

Dell Precision 3510 */
};

Quoted 5 lines
Quoted 1 line

static const struct alps_protocol_info alps_v3_protocol_data = {

Hi John! This is not a correct place do add new proto data. I already proposed reducing this table to just for PROTO_V2, but Dmitry was not happy about it.

Hi Pali. :)

Quoted 7 lines

Anyway, look at function alps_identify() where is detection for ALPS_V8:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/input/mouse/alps.c?h=v4.10-rc8#n2829

V8 is already detected when e7 is (0x73, 0x03, 0x28) and ec[1] is 0x01. What are your ec data? Probably ec[1] is not 0x01 as otherwise it should be already detected.

I have just found that code and am confused because that is not the same code I have running on my system. My ec[1] is 0x01 so you are correct, it should already be detected and my patch is unnecessary. Sorry for the inconvenience.

Quoted 1 line
Quoted 8 lines
Quoted 1 line

Btw, from where you got your proto data in this patch?

I pulled it from dmesg:

[john@slate ~]$ dmesg|grep "Unknown ALPS touchpad"

[    3.071891] psmouse serio1: alps: Unknown ALPS touchpad: E7=73 03 28,

EC=73 01 13

So you have old kernel without support for your touchpad...

Signature · 2 lines
Pali Rohár
[email protected]