Skip to contentSkip to conversation

qt5: disallow 5.8 version for ARMv4

PATCH New Peter Korsgaard 2 participants 3 messages Feb 20, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qt5: disallow 5.8 version for ARMv4

Fixes:
http://autobuild.buildroot.net/results/197/197ab8a12bf1d780a986e5d447d1e0f5ee070405/

qt5.8 no longer supports ARMv4. From src/corelib/global/qprocessordetection.h:

if Q_PROCESSOR_ARM >= 6
define Q_PROCESSOR_ARM_V6
endif
if Q_PROCESSOR_ARM >= 5
define Q_PROCESSOR_ARM_V5
else
error "ARM architecture too old"

---
 package/qt5/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/qt5/Config.in +1 -0
index b3cb2adfe..71258aafc 100644
@@ -38,6 +38,7 @@ config BR2_PACKAGE_QT5_VERSION_LATEST
 	bool "Latest (5.8)"
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
 	depends on BR2_HOST_GCC_AT_LEAST_4_8 # C++11
+	depends on !BR2_ARM_CPU_ARMV4 # needs ARMv5+
 	help
 	  This option builds Qt 5.8, which is licensed under
 	  (L)GPLv3+.
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 qt5: disallow 5.8 version for ARMv4

Hi Peter,

Quoted 23 lines · Peter Korsgaard

Fixes:
http://autobuild.buildroot.net/results/197/197ab8a12bf1d780a986e5d447d1e0f5ee070405/

qt5.8 no longer supports ARMv4. From src/corelib/global/qprocessordetection.h:

if Q_PROCESSOR_ARM >= 6
define Q_PROCESSOR_ARM_V6
endif
if Q_PROCESSOR_ARM >= 5
define Q_PROCESSOR_ARM_V5
else
error "ARM architecture too old"

---
 package/qt5/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/qt5/Config.in +0 -0
index b3cb2adfe..71258aafc 100644

package/qt5/Config.in config BR2_PACKAGE_QT5_VERSION_LATEST · line 44

Quoted 7 lines
package/qt5/Config.in +1 -0
@@ -38,6 +38,7 @@ config BR2_PACKAGE_QT5_VERSION_LATEST
 	bool "Latest (5.8)"
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
 	depends on BR2_HOST_GCC_AT_LEAST_4_8 # C++11
+	depends on !BR2_ARM_CPU_ARMV4 # needs ARMv5+
 	help
 	  This option builds Qt 5.8, which is licensed under
 	  (L)GPLv3+.

The comment dependencies needs an update as well.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 qt5: disallow 5.8 version for ARMv4

Quoted 22 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Hi Peter,

Quoted 18 lines · Peter Korsgaard

Fixes:
http://autobuild.buildroot.net/results/197/197ab8a12bf1d780a986e5d447d1e0f5ee070405/

qt5.8 no longer supports ARMv4. From src/corelib/global/qprocessordetection.h:

if Q_PROCESSOR_ARM >= 6
define Q_PROCESSOR_ARM_V6
endif
if Q_PROCESSOR_ARM >= 5
define Q_PROCESSOR_ARM_V5
else
error "ARM architecture too old"

---
package/qt5/Config.in | 1 +

1 file changed, 1 insertion(+)
Quoted 14 lines
Quoted 9 lines
package/qt5/Config.in +0 -0
index b3cb2adfe..71258aafc 100644
@@ -38,6 +38,7 @@ config BR2_PACKAGE_QT5_VERSION_LATEST

bool "Latest (5.8)"
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
depends on BR2_HOST_GCC_AT_LEAST_4_8 # C++11

package/qt5/Config.in +1 -0
+	depends on !BR2_ARM_CPU_ARMV4 # needs ARMv5+
Quoted 3 lines

help
This option builds Qt 5.8, which is licensed under (L)GPLv3+.

The comment dependencies needs an update as well.

Ahh yes, true. I'll fix that and commit - Thanks!

Signature · 1 line
Bye, Peter Korsgaard