Fuzz/x86emul and x86emul/test fixes
v4 cover Fuzz/x86emul and x86emul/test fixes
Wei Liu (2):
fuzz/x86emul: avoid race in link farm rune
x86emul/test: avoid race in link farm rune
tools/fuzz/x86_instruction_emulator/Makefile | 12 ++++++++---- tools/tests/x86_emulator/Makefile | 12 ++++++++---- 2 files changed, 16 insertions(+), 8 deletions(-)
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
PATCH v4 1/2 fuzz/x86emul: avoid race in link farm rune
Several ln -sf can race with each other and cause error like:
14:43:56 00:07:06 O: ln: cannot remove 'asm': No such file or directory
Provide dedicated targets for soft-linking directories.
--- tools/fuzz/x86_instruction_emulator/Makefile | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
tools/fuzz/x86_instruction_emulator/Makefile +8 -4
@@ -8,11 +8,15 @@ else x86-instruction-emulator-fuzzer-all: endif -x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h: - [ -L x86_emulate ] || ln -sf $(XEN_ROOT)/xen/arch/x86/x86_emulate . +x86_emulate: + [ -L $@ ] || ln -sf $(XEN_ROOT)/xen/arch/x86/$@ -asm/x86-vendors.h asm/x86-defns.h asm/msr-index.h: - [ -L asm ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 asm +x86_emulate/%: x86_emulate ; + +asm: + [ -L $@ ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 $@ + +asm/%: asm ; x86_emulate.c x86_emulate.h: %: [ -L $* ] || ln -sf $(XEN_ROOT)/tools/tests/x86_emulator/$*
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
Re: [PATCH v4 1/2] fuzz/x86emul: avoid race in link farm rune
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 20.02.17 at 15:37, <[email protected]> wrote:
Several
ln -sfcan race with each other and cause error like:14:43:56 00:07:06 O: ln: cannot remove 'asm': No such file or directory
Provide dedicated targets for soft-linking directories.
Reported-by Andrew Cooper <[email protected]>Signed-off-by Wei Liu <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
PATCH v4 2/2 x86emul/test: avoid race in link farm rune
In reply to Wei LiuSeveral ln -sf can race with each other. Provide dedicated targets for soft-linking directories.
--- tools/tests/x86_emulator/Makefile | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
tools/tests/x86_emulator/Makefile +8 -4
@@ -40,11 +40,15 @@ distclean: clean .PHONY: install install: -x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h: - [ -L x86_emulate ] || ln -sf $(XEN_ROOT)/xen/arch/x86/x86_emulate . +x86_emulate: + [ -L $@ ] || ln -sf $(XEN_ROOT)/xen/arch/x86/$@ -asm/x86-vendors.h asm/x86-defns.h asm/msr-index.h: - [ -L asm ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 asm +x86_emulate/%: x86_emulate ; + +asm: + [ -L $@ ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 $@ + +asm/%: asm ; HOSTCFLAGS += $(CFLAGS_xeninclude) -I.
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
Re: [PATCH v4 2/2] x86emul/test: avoid race in link farm rune
Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 20.02.17 at 15:37, <[email protected]> wrote:
Several
ln -sfcan race with each other. Provide dedicated targets for soft-linking directories.Signed-off-by Wei Liu <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel