ARM: dts: sun8i: NanoPi NEO Air add WiFi / eMMC
Subsystems (2)
PATCH 1/1 ARM: dts: sun8i: NanoPi NEO Air add WiFi / eMMC
Enable the WiFi (AP6212) chip and eMMC support for the NanoPi NEO Air.
--- arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts | 45 +++++++++++++++++++++++++++ 1 file changed, 45 insertions(+)
arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts +45 -0
@@ -73,6 +73,13 @@ gpios = <&pio 0 10 GPIO_ACTIVE_HIGH>; /* PA10 */ }; }; + + wifi_pwrseq: wifi_pwrseq { + compatible = "mmc-pwrseq-simple"; + pinctrl-names = "default"; + pinctrl-0 = <&wifi_en_nanopi_neo_air>; + reset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */ + }; }; &mmc0 {
@@ -85,6 +92,44 @@ status = "okay"; }; +&mmc1 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins_a>; + vmmc-supply = <®_vcc3v3>; + vqmmc-supply = <®_vcc3v3>; + mmc-pwrseq = <&wifi_pwrseq>; + bus-width = <4>; + non-removable; + status = "okay"; + + brcmf: bcrmf at 1 { + reg = <1>; + compatible = "brcm,bcm4329-fmac"; + interrupt-parent = <&pio>; + interrupts = <6 10 IRQ_TYPE_LEVEL_LOW>; /* PG10 / EINT10 */ + interrupt-names = "host-wake"; + }; +}; + +&mmc2 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc2_8bit_pins>; + vmmc-supply = <®_vcc3v3>; + vqmmc-supply = <®_vcc3v3>; + bus-width = <8>; + non-removable; + status = "okay"; +}; + +&r_pio { + wifi_en_nanopi_neo_air: wifi_en_pin { + allwinner,pins = "PL7"; + allwinner,function = "gpio_out"; + allwinner,drive = <SUN4I_PINCTRL_10_MA>; + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; + }; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pins_a>;
Signature · 1 line
2.11.1
PATCH 1/1 ARM: dts: sun8i: NanoPi NEO Air add WiFi / eMMC
Quoted 12 lines · Jelle van der Waa
Enable the WiFi (AP6212) chip and eMMC support for the NanoPi NEO Air.
Signed-off-by Jelle van der Waa <[email protected]>--- arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts | 45 +++++++++++++++++++++++++++ 1 file changed, 45 insertions(+)arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts +0
-0
arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts line 77
Quoted 5 lines
arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts +2
-0@@ -73,6 +73,13 @@ gpios = <&pio 0 10 GPIO_ACTIVE_HIGH>; /* PA10 */ }; }; + + wifi_pwrseq: wifi_pwrseq {
There should not be underscores in node names. See e.g.:
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html
https://www.mail-archive.com/netdev%40vger.kernel.org/msg90319.html
arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts line 131
Quoted 8 lines
arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts +8
-0+&r_pio { + wifi_en_nanopi_neo_air: wifi_en_pin { + allwinner,pins = "PL7"; + allwinner,function = "gpio_out"; + allwinner,drive = <SUN4I_PINCTRL_10_MA>; + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; + }; +};
1. Underscores in the node name.
2. Pinmux nodes for GPIO usage is considered unnecessary or even harmful these days. As a bonus, you avoid a duplicate definition.
3. Please use the generic properties, as in
pins = "PL7"; function ="gpio_out"; drive-strength = <10>; bias-disable;
(but you should just drop the node in this case).
(Do we not usually address the dts maintainers directly when submitting device tree patches? Just wondering.)
Signature · 1 line
Rask Ingemann Lambertsen