Skip to contentSkip to conversation

auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

PATCH In review Dmitry Torokhov 3 participants 7 messages Feb 21, 2017 – Mar 7, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

The OF device table must be terminated, otherwise we'll be walking past it and into areas unknown.

This causes KASAN errors reported by 0day kernel testing robot.

Fixes 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII...")
---
 drivers/auxdisplay/img-ascii-lcd.c | 1 +
 1 file changed, 1 insertion(+)
drivers/auxdisplay/img-ascii-lcd.c +1 -0
index bf43b5d2aafc..83f1439e57fd 100644
@@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[] = {
 	{ .compatible = "img,boston-lcd", .data = &boston_config },
 	{ .compatible = "mti,malta-lcd", .data = &malta_config },
 	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
+	{ /* sentinel */ }
 };
 
 /**
Signature · 5 lines
2.11.0.483.g087da7b7c-goog


-- 
Dmitry
#1 lore raw

Hi Dmitry,

Quoted 10 lines · On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:

The OF device table must be terminated, otherwise we'll be walking past it and into areas unknown.

This causes KASAN errors reported by 0day kernel testing robot.

Fixes 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple

ASCII...") Cc: [email protected]

An essentially identical patch was already submitted over here:

https://patchwork.kernel.org/patch/9493973/

I'm not sure how it ought to get into mainline - since the driver went through the MIPS tree perhaps this fix can too?

Thanks,
Paul

Quoted 17 lines
---
 drivers/auxdisplay/img-ascii-lcd.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/auxdisplay/img-ascii-lcd.c index bf43b5d2aafc..83f1439e57fd 100644

drivers/auxdisplay/img-ascii-lcd.c +1 -0
@@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[]
 = { { .compatible = "img,boston-lcd", .data = &boston_config },
 	{ .compatible = "mti,malta-lcd", .data = &malta_config },
 	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
+	{ /* sentinel */ }
 };
 
 /**
#2 lore raw

Hello Paul,

Quoted 14 lines · Paul Burton

Hi Dmitry,

Quoted 10 lines · On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:

The OF device table must be terminated, otherwise we'll be walking past it and into areas unknown.

This causes KASAN errors reported by 0day kernel testing robot.

Fixes 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple

ASCII...") Cc: [email protected]

Quoted 7 lines

An essentially identical patch was already submitted over here:

https://patchwork.kernel.org/patch/9493973/

I'm not sure how it ought to get into mainline - since the driver went through the MIPS tree perhaps this fix can too?

Do you know who should I ping about it? It has been posted a couple of months ago.

Quoted 3 lines

Thanks,
Paul

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Open Source Group
Samsung Research America
#3 lore raw

Hi Javier,

Quoted 15 lines · On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
Quoted 14 lines · Paul Burton
Quoted 10 lines · On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:

The OF device table must be terminated, otherwise we'll be walking past it and into areas unknown.

This causes KASAN errors reported by 0day kernel testing robot.

Fixes 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple

ASCII...") Cc: [email protected]

An essentially identical patch was already submitted over here:

Quoted 7 lines
Quoted 4 lines

https://patchwork.kernel.org/patch/9493973/

I'm not sure how it ought to get into mainline - since the driver went through the MIPS tree perhaps this fix can too?

Do you know who should I ping about it? It has been posted a couple of months ago.

If it can go through the MIPS tree that would be Ralf (who I copied previously). If not then it's Miguel as auxdisplay maintainer.

Thanks,
Paul

#4 lore raw

Hello Paul,

Quoted 20 lines · Paul Burton

Hi Javier,

Quoted 17 lines · On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
Quoted 16 lines · Paul Burton
Quoted 10 lines · On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:

The OF device table must be terminated, otherwise we'll be walking past it and into areas unknown.

This causes KASAN errors reported by 0day kernel testing robot.

Fixes 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple

ASCII...") Cc: [email protected]

An essentially identical patch was already submitted over here:

https://patchwork.kernel.org/patch/9493973/

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

I'm not sure how it ought to get into mainline - since the driver went through the MIPS tree perhaps this fix can too?

Do you know who should I ping about it? It has been posted a couple of months ago.

If it can go through the MIPS tree that would be Ralf (who I copied previously). If not then it's Miguel as auxdisplay maintainer.

Ok, Thanks for your help. I just asked in case MAINTAINERS wasn't up-to-date since the patches were posted a long time ago and had no feedback.

Quoted 3 lines

Thanks,
Paul

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Open Source Group
Samsung Research America
#5 lore raw
Quoted 29 lines · Javier Martinez Canillas

Hello Paul,

Quoted 26 lines · Paul Burton

Hi Javier,

Quoted 22 lines · On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
Quoted 12 lines · Paul Burton
Quoted 10 lines · On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:

The OF device table must be terminated, otherwise we'll be walking past it and into areas unknown.

This causes KASAN errors reported by 0day kernel testing robot.

Fixes 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple

ASCII...") Cc: [email protected]

Quoted 6 lines

An essentially identical patch was already submitted over here:

https://patchwork.kernel.org/patch/9493973/

I'm not sure how it ought to get into mainline - since the driver went through the MIPS tree perhaps this fix can too?

Do you know who should I ping about it? It has been posted a couple of months ago.

Quoted 6 lines
Quoted 3 lines

If it can go through the MIPS tree that would be Ralf (who I copied previously). If not then it's Miguel as auxdisplay maintainer.

Ok, Thanks for your help. I just asked in case MAINTAINERS wasn't up-to-date since the patches were posted a long time ago and had no feedback.

Maybe we could get akpm pick it up?

Thanks.

Signature · 1 line
Dmitry
#6 lore raw

Hello Dmitry,

Quoted 30 lines · Dmitry Torokhov
Quoted 29 lines · Javier Martinez Canillas

Hello Paul,

Quoted 26 lines · Paul Burton

Hi Javier,

Quoted 22 lines · On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
Quoted 12 lines · Paul Burton
Quoted 10 lines · On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:

The OF device table must be terminated, otherwise we'll be walking past it and into areas unknown.

This causes KASAN errors reported by 0day kernel testing robot.

Fixes 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple

ASCII...") Cc: [email protected]

Quoted 6 lines

An essentially identical patch was already submitted over here:

https://patchwork.kernel.org/patch/9493973/

I'm not sure how it ought to get into mainline - since the driver went through the MIPS tree perhaps this fix can too?

Do you know who should I ping about it? It has been posted a couple of months ago.

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

If it can go through the MIPS tree that would be Ralf (who I copied previously). If not then it's Miguel as auxdisplay maintainer.

Ok, Thanks for your help. I just asked in case MAINTAINERS wasn't up-to-date since the patches were posted a long time ago and had no feedback.

Maybe we could get akpm pick it up?

Good idea, I'll re-send with akpm to cc so he can pick them.

Quoted 2 lines

Thanks.

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Open Source Group
Samsung Research America