drm/i915/tracepoints: Tidy request event class
Subsystems (2)
Tvrtko Ursulin
maintainerPATCH 1/8 drm/i915/tracepoints: Tidy request event class
From: Tvrtko Ursulin <[email protected]>
At the moment only the global seqno is logged which is not set until the request is ready for submission.
Add the per-contex seqno and the context hardware id which are both interesting data points.
--- drivers/gpu/drm/i915/i915_trace.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_trace.h +8 -3
@@ -451,18 +451,23 @@ DECLARE_EVENT_CLASS(i915_gem_request,TP_STRUCT__entry (__field (u32 ,dev ) +__field (u32, ctx)__field (u32, ring)__field (u32, seqno) +__field (u32, global) ),TP_fast_assign ( __entry->dev = req->i915->drm.primary->index; + __entry->ctx = req->ctx->hw_id; __entry->ring = req->engine->id; - __entry->seqno = req->global_seqno; + __entry->seqno = req->fence.seqno; + __entry->global = req->global_seqno; ), -TP_printk ("dev=%u, ring=%u, seqno=%u" , - __entry->dev, __entry->ring, __entry->seqno) +TP_printk ("dev=%u, ring=%u, ctx=%u, seqno=%u, global=%u" , + __entry->dev, __entry->ring, __entry->ctx, __entry->seqno, + __entry->global) ); DEFINE_EVENT(i915_gem_request, i915_gem_request_add,
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH 2/8 drm/i915/tracepoints: Adjust i915_gem_ring_dispatch
From: Tvrtko Ursulin <[email protected]>
Rename it to i915_gem_request_queue and fix the logged info equivalent to the i915_gem_request even class. Also moved it a bit further apart from the i915_gem_request_add tracepoint since they otherwise provide similar information too close in time.
v2: Remove sw fence singalling. We will rely on the soon to
come GuC scheduling backend to enable that. (Chris Wilson)
v3: Log hex with 0x prefix for clarity.
--- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 ++-- drivers/gpu/drm/i915/i915_trace.h | 12 +++++++----- 2 files changed, 9 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/i915_gem_execbuffer.c +2 -2
@@ -1493,8 +1493,6 @@ execbuf_submit(struct i915_execbuffer_params *params,if (ret)return ret; -trace_i915_gem_ring_dispatch (params->request, params->dispatch_flags); -i915_gem_execbuffer_move_to_active (vmas, params->request);return 0 ;
@@ -1836,6 +1834,8 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data, params->dispatch_flags = dispatch_flags; params->ctx = ctx; +trace_i915_gem_request_queue (params->request, dispatch_flags); + ret =execbuf_submit (params, args, &eb->vmas); err_request:__i915_add_request (params->request, ret ==0 );
drivers/gpu/drm/i915/i915_trace.h +7 -5
@@ -399,13 +399,14 @@ TRACE_EVENT(i915_gem_ring_sync_to, __entry->seqno) ); -TRACE_EVENT(i915_gem_ring_dispatch, +TRACE_EVENT(i915_gem_request_queue, TP_PROTO(struct drm_i915_gem_request *req, u32 flags), TP_ARGS(req, flags), TP_STRUCT__entry( __field(u32, dev) __field(u32, ring) + __field(u32, ctx) __field(u32, seqno) __field(u32, flags) ),
@@ -413,13 +414,14 @@ TRACE_EVENT(i915_gem_ring_dispatch,TP_fast_assign ( __entry->dev = req->i915->drm.primary->index; __entry->ring = req->engine->id; - __entry->seqno = req->global_seqno; + __entry->ctx = req->ctx->hw_id; + __entry->seqno = req->fence.seqno; __entry->flags = flags; -dma_fence_enable_sw_signaling (&req->fence); ), -TP_printk ("dev=%u, ring=%u, seqno=%u, flags=%x" , - __entry->dev, __entry->ring, __entry->seqno, __entry->flags) +TP_printk ("dev=%u, ring=%u, ctx=%u, seqno=%u, flags=0x%x" , + __entry->dev, __entry->ring, __entry->ctx, __entry->seqno, + __entry->flags) ); TRACE_EVENT(i915_gem_ring_flush,
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH 3/8 drm/i915/tracepoints: Tidy i915_gem_request_wait_begin
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Provide the same information as the other request event classes.
v2: Pass in flags so we can properly report the blocking status.
(Chris Wilson)
v3: Log hex with 0x prefix for clarity.
--- drivers/gpu/drm/i915/i915_gem_request.c | 2 +- drivers/gpu/drm/i915/i915_trace.h | 21 +++++++++++++-------- 2 files changed, 14 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/i915_gem_request.c +1 -1
@@ -1092,7 +1092,7 @@ long i915_wait_request(struct drm_i915_gem_request *req,if (!timeout)return -ETIME ; -trace_i915_gem_request_wait_begin (req); +trace_i915_gem_request_wait_begin (req, flags);if (!i915_sw_fence_done (&req->execute)) { timeout =__i915_request_wait_for_execute (req, flags, timeout);
drivers/gpu/drm/i915/i915_trace.h +13 -8
@@ -508,13 +508,16 @@ DEFINE_EVENT(i915_gem_request, i915_gem_request_complete, ); TRACE_EVENT(i915_gem_request_wait_begin, - TP_PROTO(struct drm_i915_gem_request *req), - TP_ARGS(req), + TP_PROTO(struct drm_i915_gem_request *req, unsigned int flags), + TP_ARGS(req, flags), TP_STRUCT__entry( __field(u32, dev) __field(u32, ring) + __field(u32, ctx) __field(u32, seqno) + __field(u32, global) + __field(unsigned int, flags) __field(bool, blocking) ),
@@ -527,14 +530,16 @@ TRACE_EVENT(i915_gem_request_wait_begin,TP_fast_assign ( __entry->dev = req->i915->drm.primary->index; __entry->ring = req->engine->id; - __entry->seqno = req->global_seqno; - __entry->blocking = -mutex_is_locked (&req->i915->drm.struct_mutex); + __entry->ctx = req->ctx->hw_id; + __entry->seqno = req->fence.seqno; + __entry->global = req->global_seqno; + __entry->flags = flags; + __entry->blocking = flags &I915_WAIT_LOCKED ; ), -TP_printk ("dev=%u, ring=%u, seqno=%u, blocking=%s" , - __entry->dev, __entry->ring, - __entry->seqno, __entry->blocking ?"yes (NB)" :"no" ) +TP_printk ("dev=%u, ring=%u, ctx=%u, seqno=%u, global=%u, blocking=%u, flags=0x%x" , + __entry->dev, __entry->ring, __entry->ctx, __entry->seqno, + __entry->global, __entry->blocking, __entry->flags) ); DEFINE_EVENT(i915_gem_request, i915_gem_request_wait_end,
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/8] drm/i915/tracepoints: Tidy i915_gem_request_wait_begin
Quoted 61 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Provide the same information as the other request event classes.
v2: Pass in flags so we can properly report the blocking status.
(Chris Wilson)v3: Log hex with 0x prefix for clarity.
Signed-off-by Tvrtko Ursulin <[email protected]>--- drivers/gpu/drm/i915/i915_gem_request.c | 2 +- drivers/gpu/drm/i915/i915_trace.h | 21 +++++++++++++-------- 2 files changed, 14 insertions(+), 9 deletions(-)drivers/gpu/drm/i915/i915_gem_request.c +1
-1@@ -1092,7 +1092,7 @@ long i915_wait_request(struct drm_i915_gem_request *req,if (!timeout)return -ETIME ; -trace_i915_gem_request_wait_begin (req); +trace_i915_gem_request_wait_begin (req, flags);if (!i915_sw_fence_done (&req->execute)) { timeout =__i915_request_wait_for_execute (req, flags, timeout);drivers/gpu/drm/i915/i915_trace.h +8
-5@@ -508,13 +508,16 @@ DEFINE_EVENT(i915_gem_request, i915_gem_request_complete, ); TRACE_EVENT(i915_gem_request_wait_begin, - TP_PROTO(struct drm_i915_gem_request *req), - TP_ARGS(req), + TP_PROTO(struct drm_i915_gem_request *req, unsigned int flags), + TP_ARGS(req, flags), TP_STRUCT__entry( __field(u32, dev) __field(u32, ring) + __field(u32, ctx) __field(u32, seqno) + __field(u32, global) + __field(unsigned int, flags) __field(bool, blocking) ),@@ -527,14 +530,16 @@ TRACE_EVENT(i915_gem_request_wait_begin,TP_fast_assign ( __entry->dev = req->i915->drm.primary->index; __entry->ring = req->engine->id; - __entry->seqno = req->global_seqno; - __entry->blocking = -mutex_is_locked (&req->i915->drm.struct_mutex); + __entry->ctx = req->ctx->hw_id; + __entry->seqno = req->fence.seqno; + __entry->global = req->global_seqno;
drivers/gpu/drm/i915/i915_trace.h TRACE_EVENT(i915_gem_request_wait_begin, · line 542
Quoted 10 lines
drivers/gpu/drm/i915/i915_trace.h +5
-3+ __entry->flags = flags; + __entry->blocking = flags &I915_WAIT_LOCKED ; ), -TP_printk ("dev=%u, ring=%u, seqno=%u, blocking=%s" , - __entry->dev, __entry->ring, - __entry->seqno, __entry->blocking ?"yes (NB)" :"no" ) +TP_printk ("dev=%u, ring=%u, ctx=%u, seqno=%u, global=%u, blocking=%u, flags=0x%x" , + __entry->dev, __entry->ring, __entry->ctx, __entry->seqno, + __entry->global, __entry->blocking, __entry->flags)
We don't need to store bool blocking, we can just pluck it out of flags in the printk.
Hmm. How should we handle global changing value in the course of the wait?
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/8] drm/i915/tracepoints: Tidy i915_gem_request_wait_begin
Quoted 66 lines · Chris Wilson
Quoted 65 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Provide the same information as the other request event classes.
v2: Pass in flags so we can properly report the blocking status.
(Chris Wilson)v3: Log hex with 0x prefix for clarity.
Signed-off-by Tvrtko Ursulin <[email protected]>--- drivers/gpu/drm/i915/i915_gem_request.c | 2 +- drivers/gpu/drm/i915/i915_trace.h | 21 ++++++++++++-------- 2 files changed, 14 insertions(+), 9 deletions(-)drivers/gpu/drm/i915/i915_gem_request.c +1
-1@@ -1092,7 +1092,7 @@ long i915_wait_request(struct drm_i915_gem_request *req,if (!timeout)return -ETIME ; -trace_i915_gem_request_wait_begin (req); +trace_i915_gem_request_wait_begin (req, flags);if (!i915_sw_fence_done (&req->execute)) { timeout =__i915_request_wait_for_execute (req, flags, timeout);drivers/gpu/drm/i915/i915_trace.h +10
-5@@ -508,13 +508,16 @@ DEFINE_EVENT(i915_gem_request, i915_gem_request_complete, ); TRACE_EVENT(i915_gem_request_wait_begin, - TP_PROTO(struct drm_i915_gem_request *req), - TP_ARGS(req), + TP_PROTO(struct drm_i915_gem_request *req, unsigned int flags), + TP_ARGS(req, flags), TP_STRUCT__entry( __field(u32, dev) __field(u32, ring) + __field(u32, ctx) __field(u32, seqno) + __field(u32, global) + __field(unsigned int, flags) __field(bool, blocking) ),@@ -527,14 +530,16 @@ TRACE_EVENT(i915_gem_request_wait_begin,TP_fast_assign ( __entry->dev = req->i915->drm.primary->index; __entry->ring = req->engine->id; - __entry->seqno = req->global_seqno; - __entry->blocking = -mutex_is_locked (&req->i915->drm.struct_mutex); + __entry->ctx = req->ctx->hw_id; + __entry->seqno = req->fence.seqno; + __entry->global = req->global_seqno; + __entry->flags = flags; + __entry->blocking = flags &I915_WAIT_LOCKED ; ),
Quoted 9 lines
drivers/gpu/drm/i915/i915_trace.h TRACE_EVENT(i915_gem_request_wait_begin, · line 542
Quoted 6 lines
drivers/gpu/drm/i915/i915_trace.h +3
-3-TP_printk ("dev=%u, ring=%u, seqno=%u, blocking=%s" , - __entry->dev, __entry->ring, - __entry->seqno, __entry->blocking ?"yes (NB)" :"no" ) +TP_printk ("dev=%u, ring=%u, ctx=%u, seqno=%u, global=%u, blocking=%u, flags=0x%x" , + __entry->dev, __entry->ring, __entry->ctx, __entry->seqno, + __entry->global, __entry->blocking, __entry->flags)We don't need to store bool blocking, we can just pluck it out of flags in the printk.
Ok.
Quoted 2 lines
Hmm. How should we handle global changing value in the course of the wait?
How would you do that? It will get logged at the end of the wait and ctx/ring/seqno can be used as an unique identifier to match the two ends.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/8] drm/i915/tracepoints: Tidy i915_gem_request_wait_begin
Quoted 8 lines · Tvrtko Ursulin
Quoted 2 lines · Chris Wilson
Hmm. How should we handle global changing value in the course of the wait?
How would you do that? It will get logged at the end of the wait and ctx/ring/seqno can be used as an unique identifier to match the two ends.
I was wondering what value global had in the early tracepoint. It tells us if the wait begins before the request was executed. Then at the end, you can see if it was interrupted by seeing if global changed.
It will definitely help in the trivial cases of reading through the logs and tieing the waits to the execution - I just forsee some confusion occasionally :)
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH v4 3/8 drm/i915/tracepoints: Tidy i915_gem_request_wait_begin
From: Tvrtko Ursulin <[email protected]>
Provide the same information as the other request event classes.
v2: Pass in flags so we can properly report the blocking status.
(Chris Wilson)
v3: Log hex with 0x prefix for clarity.
v4: Derive blocking status from flags. (Chris Wilson)
--- drivers/gpu/drm/i915/i915_gem_request.c | 2 +- drivers/gpu/drm/i915/i915_trace.h | 22 +++++++++++++--------- 2 files changed, 14 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/i915_gem_request.c +1 -1
@@ -1092,7 +1092,7 @@ long i915_wait_request(struct drm_i915_gem_request *req,if (!timeout)return -ETIME ; -trace_i915_gem_request_wait_begin (req); +trace_i915_gem_request_wait_begin (req, flags);if (!i915_sw_fence_done (&req->execute)) { timeout =__i915_request_wait_for_execute (req, flags, timeout);
drivers/gpu/drm/i915/i915_trace.h +13 -9
@@ -508,14 +508,16 @@ DEFINE_EVENT(i915_gem_request, i915_gem_request_complete, ); TRACE_EVENT(i915_gem_request_wait_begin, - TP_PROTO(struct drm_i915_gem_request *req), - TP_ARGS(req), + TP_PROTO(struct drm_i915_gem_request *req, unsigned int flags), + TP_ARGS(req, flags), TP_STRUCT__entry( __field(u32, dev) __field(u32, ring) + __field(u32, ctx) __field(u32, seqno) - __field(bool, blocking) + __field(u32, global) + __field(unsigned int, flags) ),/* NB: the blocking information is racy since mutex_is_locked
@@ -527,14 +529,16 @@ TRACE_EVENT(i915_gem_request_wait_begin,TP_fast_assign ( __entry->dev = req->i915->drm.primary->index; __entry->ring = req->engine->id; - __entry->seqno = req->global_seqno; - __entry->blocking = -mutex_is_locked (&req->i915->drm.struct_mutex); + __entry->ctx = req->ctx->hw_id; + __entry->seqno = req->fence.seqno; + __entry->global = req->global_seqno; + __entry->flags = flags; ), -TP_printk ("dev=%u, ring=%u, seqno=%u, blocking=%s" , - __entry->dev, __entry->ring, - __entry->seqno, __entry->blocking ?"yes (NB)" :"no" ) +TP_printk ("dev=%u, ring=%u, ctx=%u, seqno=%u, global=%u, blocking=%u, flags=0x%x" , + __entry->dev, __entry->ring, __entry->ctx, __entry->seqno, + __entry->global, !!(__entry->flags &I915_WAIT_LOCKED ), + __entry->flags) ); DEFINE_EVENT(i915_gem_request, i915_gem_request_wait_end,
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH 4/8 drm/i915/tracepoints: Remove unused i915_gem_request_complete
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Tracepoint is not used and won't be suitable for its replacement.
--- drivers/gpu/drm/i915/i915_trace.h | 5 ----- 1 file changed, 5 deletions(-)
drivers/gpu/drm/i915/i915_trace.h +0 -5
@@ -502,11 +502,6 @@ DEFINE_EVENT(i915_gem_request, i915_gem_request_retire,TP_ARGS (req) ); -DEFINE_EVENT (i915_gem_request, i915_gem_request_complete, - TP_PROTO(struct drm_i915_gem_request *req), -TP_ARGS (req) -); - TRACE_EVENT(i915_gem_request_wait_begin, TP_PROTO(struct drm_i915_gem_request *req, unsigned int flags), TP_ARGS(req, flags),
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH 5/8 drm/i915/tracepoints: Add request submit and execute tracepoints
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
These new tracepoints are emitted once the request is ready to be submitted to the GPU and once the request is about to be submitted to the GPU, respectively.
Former condition triggers as soon as all the fences and dependencies have been resolved, and the latter once the backend is about to submit it to the GPU.
New tracepoint are enabled via the new DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option which is disabled by default to alleviate the performance impact concerns.
--- drivers/gpu/drm/i915/Kconfig.debug | 11 +++++++++++ drivers/gpu/drm/i915/i915_gem_request.c | 2 ++ drivers/gpu/drm/i915/i915_trace.h | 24 ++++++++++++++++++++++++ 3 files changed, 37 insertions(+)
drivers/gpu/drm/i915/Kconfig.debug +11 -0
@@ -76,3 +76,14 @@ config DRM_I915_SELFTEST Recommended for driver developers only. If in doubt, say "N". + +config DRM_I915_LOW_LEVEL_TRACEPOINTS + bool "Enable low level request tracing events" + depends on DRM_I915 + default n + help + Choose this option to turn on low level request tracing events. + This provides the ability to precisely monitor engine utilisation + and also analyze the request dependency resolving timeline. + + If in doubt, say "N".
drivers/gpu/drm/i915/i915_gem_request.c +2 -0
@@ -449,6 +449,7 @@ submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)switch (state) {case FENCE_COMPLETE : +trace_i915_gem_request_submit (request); request->engine->submit_request (request);break ;
@@ -468,6 +469,7 @@ execute_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)switch (state) {case FENCE_COMPLETE : +trace_i915_gem_request_execute (request);break ;case FENCE_FREE :
drivers/gpu/drm/i915/i915_trace.h +24 -0
@@ -477,6 +477,30 @@ DEFINE_EVENT(i915_gem_request, i915_gem_request_add,TP_ARGS (req) ); +#if defined(CONFIG_DRM_I915_LOW_LEVEL_TRACEPOINTS ) +DEFINE_EVENT (i915_gem_request, i915_gem_request_submit, + TP_PROTO(struct drm_i915_gem_request *req), +TP_ARGS (req) +); + +DEFINE_EVENT (i915_gem_request, i915_gem_request_execute, + TP_PROTO(struct drm_i915_gem_request *req), +TP_ARGS (req) +); +#else +#if !defined(TRACE_HEADER_MULTI_READ ) +static inline void +trace_i915_gem_request_submit (struct drm_i915_gem_request *req) +{ +} + +static inline void +trace_i915_gem_request_execute (struct drm_i915_gem_request *req) +{ +} +#endif +#endif + TRACE_EVENT(i915_gem_request_notify, TP_PROTO(struct intel_engine_cs *engine), TP_ARGS(engine),
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 5/8] drm/i915/tracepoints: Add request submit and execute tracepoints
drivers/gpu/drm/i915/i915_gem_request.c execute_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state) · line 473
Quoted 6 lines · Tvrtko Ursulin
drivers/gpu/drm/i915/i915_gem_request.c +1
-0@@ -468,6 +469,7 @@ execute_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)switch (state) {case FENCE_COMPLETE : +trace_i915_gem_request_execute (request);break ;
Move to __i915_gem_request_submit(). (One less complication for me). I guess you are thinking of changing its name to __i915_gem_request_execute().
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 5/8] drm/i915/tracepoints: Add request submit and execute tracepoints
Quoted 9 lines · Chris Wilson
drivers/gpu/drm/i915/i915_gem_request.c execute_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state) · line 473
Quoted 6 lines · Tvrtko Ursulin
drivers/gpu/drm/i915/i915_gem_request.c +1
-0@@ -468,6 +469,7 @@ execute_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)switch (state) {case FENCE_COMPLETE : +trace_i915_gem_request_execute (request);break ;Move to
__i915_gem_request_submit(). (One less complication for me).
Ack.
Quoted 2 lines
I guess you are thinking of changing its name to
__i915_gem_request_execute().
No, why? The idea is i915_gem_request_submit -> "ready for execution / dependencies resolved" and i915_gem_request_execute -> "about to be submitted to execution backend".
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 5/8] drm/i915/tracepoints: Add request submit and execute tracepoints
Quoted 13 lines · Tvrtko Ursulin
Quoted 9 lines · Chris Wilson
drivers/gpu/drm/i915/i915_gem_request.c execute_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state) · line 473
Quoted 6 lines · Tvrtko Ursulin
drivers/gpu/drm/i915/i915_gem_request.c +1
-0@@ -468,6 +469,7 @@ execute_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)switch (state) {case FENCE_COMPLETE : +trace_i915_gem_request_execute (request);break ;Move to
__i915_gem_request_submit(). (One less complication for me).
Quoted 8 lines
Ack.
Quoted 2 lines
I guess you are thinking of changing its name to
__i915_gem_request_execute().No, why? The idea is
i915_gem_request_submit-> "ready for execution / dependencies resolved" andi915_gem_request_execute-> "about to be submitted to execution backend".
Right. Only "i915_gem_request_execute" is currently called __i915_gem_request_submit().
add_request ->
[deps complete] ->
submit_notify ->
backend->submit() ->
[some time passes] ->
__i915_gem_request_submit() You've convinced me that __i915_gem_request_execute is a step forward from __i915_gem_request_submit.
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH v2 5/8 drm/i915/tracepoints: Add request submit and execute tracepoints
From: Tvrtko Ursulin <[email protected]>
These new tracepoints are emitted once the request is ready to be submitted to the GPU and once the request is about to be submitted to the GPU, respectively.
Former condition triggers as soon as all the fences and dependencies have been resolved, and the latter once the backend is about to submit it to the GPU.
New tracepoint are enabled via the new DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option which is disabled by default to alleviate the performance impact concerns.
v2: Move execute tracepoint to __i915_gem_request_submit.
(Chris Wilson)
--- drivers/gpu/drm/i915/Kconfig.debug | 11 +++++++++++ drivers/gpu/drm/i915/i915_gem_request.c | 2 ++ drivers/gpu/drm/i915/i915_trace.h | 24 ++++++++++++++++++++++++ 3 files changed, 37 insertions(+)
drivers/gpu/drm/i915/Kconfig.debug +11 -0
@@ -76,3 +76,14 @@ config DRM_I915_SELFTEST Recommended for driver developers only. If in doubt, say "N". + +config DRM_I915_LOW_LEVEL_TRACEPOINTS + bool "Enable low level request tracing events" + depends on DRM_I915 + default n + help + Choose this option to turn on low level request tracing events. + This provides the ability to precisely monitor engine utilisation + and also analyze the request dependency resolving timeline. + + If in doubt, say "N".
drivers/gpu/drm/i915/i915_gem_request.c +2 -0
@@ -426,6 +426,7 @@ void __i915_gem_request_submit(struct drm_i915_gem_request *request)spin_unlock (&request->timeline->lock);i915_sw_fence_commit (&request->execute); +trace_i915_gem_request_execute (request); }void i915_gem_request_submit (struct drm_i915_gem_request *request)
@@ -449,6 +450,7 @@ submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)switch (state) {case FENCE_COMPLETE : +trace_i915_gem_request_submit (request); request->engine->submit_request (request);break ;
drivers/gpu/drm/i915/i915_trace.h +24 -0
@@ -477,6 +477,30 @@ DEFINE_EVENT(i915_gem_request, i915_gem_request_add,TP_ARGS (req) ); +#if defined(CONFIG_DRM_I915_LOW_LEVEL_TRACEPOINTS ) +DEFINE_EVENT (i915_gem_request, i915_gem_request_submit, + TP_PROTO(struct drm_i915_gem_request *req), +TP_ARGS (req) +); + +DEFINE_EVENT (i915_gem_request, i915_gem_request_execute, + TP_PROTO(struct drm_i915_gem_request *req), +TP_ARGS (req) +); +#else +#if !defined(TRACE_HEADER_MULTI_READ ) +static inline void +trace_i915_gem_request_submit (struct drm_i915_gem_request *req) +{ +} + +static inline void +trace_i915_gem_request_execute (struct drm_i915_gem_request *req) +{ +} +#endif +#endif + TRACE_EVENT(i915_gem_request_notify, TP_PROTO(struct intel_engine_cs *engine), TP_ARGS(engine),
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH 6/8 drm/i915/tracepoints: Rename i915_gem_request_notify
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
i915_gem_ring_notify is more appropriate since we do not have the request information at this point, but it is simply a signal from the engine that some request has been completed.
v2:
* Always trace and log if there were any waiters.
* Rename to intel_engine_notify. (Chris Wilson)
--- drivers/gpu/drm/i915/i915_irq.c | 6 ++++-- drivers/gpu/drm/i915/i915_trace.h | 13 ++++++++----- 2 files changed, 12 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/i915_irq.c +4 -2
@@ -1033,10 +1033,12 @@ static void ironlake_rps_change_irq_handler(struct drm_i915_private *dev_priv)static void notify_ring (struct intel_engine_cs *engine) { +bool waiters; +atomic_inc (&engine->irq_count);set_bit (ENGINE_IRQ_BREADCRUMB , &engine->irq_posted); -if (intel_engine_wakeup (engine)) -trace_i915_gem_request_notify (engine); + waiters =intel_engine_wakeup (engine); +trace_intel_engine_notify (engine, waiters); } static void vlv_c0_read(struct drm_i915_private *dev_priv,
drivers/gpu/drm/i915/i915_trace.h +8 -5
@@ -501,24 +501,27 @@ trace_i915_gem_request_execute(struct drm_i915_gem_request *req)#endif #endif -TRACE_EVENT (i915_gem_request_notify, - TP_PROTO(struct intel_engine_cs *engine), -TP_ARGS (engine), +TRACE_EVENT (intel_engine_notify, + TP_PROTO(struct intel_engine_cs *engine, bool waiters), +TP_ARGS (engine, waiters),TP_STRUCT__entry ( __field(u32, dev) __field(u32, ring) __field(u32, seqno) +__field (bool, waiters) ),TP_fast_assign ( __entry->dev = engine->i915->drm.primary->index; __entry->ring = engine->id; __entry->seqno = intel_engine_get_seqno(engine); + __entry->waiters = waiters; ), -TP_printk ("dev=%u, ring=%u, seqno=%u" , - __entry->dev, __entry->ring, __entry->seqno) +TP_printk ("dev=%u, ring=%u, seqno=%u, waiters=%u" , + __entry->dev, __entry->ring, __entry->seqno, + __entry->waiters) ); DEFINE_EVENT(i915_gem_request, i915_gem_request_retire,
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 6/8] drm/i915/tracepoints: Rename i915_gem_request_notify
Quoted 22 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
i915_gem_ring_notifyis more appropriate since we do not have the request information at this point, but it is simply a signal from the engine that some request has been completed.v2:
* Always trace and log if there were any waiters.
* Rename tointel_engine_notify. (Chris Wilson)Signed-off-by Tvrtko Ursulin <[email protected]>--- drivers/gpu/drm/i915/i915_irq.c | 6 ++++-- drivers/gpu/drm/i915/i915_trace.h | 13 ++++++++----- 2 files changed, 12 insertions(+), 7 deletions(-)drivers/gpu/drm/i915/i915_irq.c +0
-0@@ -1033,10 +1033,12 @@ static void ironlake_rps_change_irq_handler(struct drm_i915_private *dev_priv)
drivers/gpu/drm/i915/i915_irq.c static void ironlake_rps_change_irq_handler(struct drm_i915_private *dev_priv) · line 1041
Quoted 10 lines
drivers/gpu/drm/i915/i915_irq.c +4
-2static void notify_ring (struct intel_engine_cs *engine) { +bool waiters; +atomic_inc (&engine->irq_count);set_bit (ENGINE_IRQ_BREADCRUMB , &engine->irq_posted); -if (intel_engine_wakeup (engine)) -trace_i915_gem_request_notify (engine); + waiters =intel_engine_wakeup (engine); +trace_intel_engine_notify (engine, waiters);
Close enough! (Here the waiters are sleepers, but that will change shortly).
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH 7/8 drm/i915/tracepoints: Add backend level request in and out tracepoints
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Two new tracepoints placed at the call sites where requests are actually passed to the GPU enable userspace to track engine utilisation.
These tracepoints are only enabled when the DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option is enabled.
v2: Fix compilation with !CONFIG_DRM_I915_LOW_LEVEL_TRACEPOINTS.
v3: Name global seqno consistently across tracepoints.
--- drivers/gpu/drm/i915/i915_guc_submission.c | 2 ++ drivers/gpu/drm/i915/i915_trace.h | 49 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_lrc.c | 4 +++ 3 files changed, 55 insertions(+)
drivers/gpu/drm/i915/i915_guc_submission.c +2 -0
@@ -518,6 +518,8 @@ static void __i915_guc_submit(struct drm_i915_gem_request *rq)if (i915_vma_is_map_and_fenceable (rq->ring->vma))POSTING_READ_FW (GUC_STATUS ); +trace_i915_gem_request_in (rq,0 ); + b_ret =guc_ring_doorbell (client); client->submissions[engine_id] +=1 ;
drivers/gpu/drm/i915/i915_trace.h +49 -0
61 lines not on this page · raw message
drivers/gpu/drm/i915/intel_lrc.c +4 -0
@@ -479,6 +479,7 @@ static void execlists_dequeue(struct intel_engine_cs *engine) cursor->priotree.priority =INT_MAX ;__i915_gem_request_submit (cursor); +trace_i915_gem_request_in (cursor, port - engine->execlist_port); last = cursor; submit = true; }
@@ -541,6 +542,7 @@ static void intel_lrc_irq_handler(unsigned long data)struct intel_engine_cs *engine = (struct intel_engine_cs *)data;struct execlist_port *port = engine->execlist_port;struct drm_i915_private *dev_priv = engine->i915; +unsigned int portidx =0 ;intel_uncore_forcewake_get (dev_priv, engine->fw_domains);
@@ -593,6 +595,8 @@ static void intel_lrc_irq_handler(unsigned long data)execlists_context_status_change (port[0 ].request,INTEL_CONTEXT_SCHEDULE_OUT ); +trace_i915_gem_request_out (port[0 ].request, + portidx++);i915_gem_request_put (port[0 ].request); port[0 ] = port[1 ];memset (&port[1 ],0 ,sizeof (port[1 ]));
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 7/8] drm/i915/tracepoints: Add backend level request in and out tracepoints
drivers/gpu/drm/i915/intel_lrc.c static void intel_lrc_irq_handler(unsigned long data) · line 599
Quoted 6 lines · Tvrtko Ursulin
drivers/gpu/drm/i915/intel_lrc.c +2
-0@@ -593,6 +595,8 @@ static void intel_lrc_irq_handler(unsigned long data)execlists_context_status_change (port[0 ].request,INTEL_CONTEXT_SCHEDULE_OUT ); +trace_i915_gem_request_out (port[0 ].request, + portidx++);
Not seeing the value in portidx here, since if we process this as two seperate interrupts, it always comes out as 0. And 0 is what we expect. Knowing that we processed more than one completion event inside a single tasklet?
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 7/8] drm/i915/tracepoints: Add backend level request in and out tracepoints
Quoted 5 lines · Chris Wilson
Quoted 4 lines · Tvrtko Ursulin
drivers/gpu/drm/i915/intel_lrc.c +0
-0@@ -593,6 +595,8 @@ static void intel_lrc_irq_handler(unsigned long data)execlists_context_status_change (port[0 ].request,INTEL_CONTEXT_SCHEDULE_OUT );
Quoted 7 lines
drivers/gpu/drm/i915/intel_lrc.c static void intel_lrc_irq_handler(unsigned long data) · line 599
Quoted 2 lines
drivers/gpu/drm/i915/intel_lrc.c +2
-0+trace_i915_gem_request_out (port[0 ].request, + portidx++);Not seeing the value in portidx here, since if we process this as two seperate interrupts, it always comes out as 0. And 0 is what we expect. Knowing that we processed more than one completion event inside a single tasklet?
Yes, but I know that is very unlikely. In all the traces I have laying around here is is 546921 to 3 for port being zero. :)
Perhaps the fact can also be derived from the timestamps on trace events but it would be a bit of a heuristics. Sounds safer to just report the fact at source, but I can also remove it if you want.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 7/8] drm/i915/tracepoints: Add backend level request in and out tracepoints
Quoted 15 lines · Tvrtko Ursulin
Quoted 5 lines · Chris Wilson
Quoted 4 lines · Tvrtko Ursulin
drivers/gpu/drm/i915/intel_lrc.c +0
-0@@ -593,6 +595,8 @@ static void intel_lrc_irq_handler(unsigned long data)execlists_context_status_change (port[0 ].request,INTEL_CONTEXT_SCHEDULE_OUT );Quoted 7 lines
drivers/gpu/drm/i915/intel_lrc.c static void intel_lrc_irq_handler(unsigned long data) · line 599
Quoted 2 lines
drivers/gpu/drm/i915/intel_lrc.c +2
-0+trace_i915_gem_request_out (port[0 ].request, + portidx++);Not seeing the value in portidx here, since if we process this as two seperate interrupts, it always comes out as 0. And 0 is what we expect. Knowing that we processed more than one completion event inside a single tasklet?
Quoted 6 lines
Yes, but I know that is very unlikely. In all the traces I have laying around here is is 546921 to 3 for port being zero. :)
Perhaps the fact can also be derived from the timestamps on trace events but it would be a bit of a heuristics. Sounds safer to just report the fact at source, but I can also remove it if you want.
I think I'd prefer it without portidx++. I just am not seeing the value in it, whereas in[0] or in[1] clearly does have value. I also don't think we are limiting ourselves to never adding extra information here. -Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH v4 7/8 drm/i915/tracepoints: Add backend level request in and out tracepoints
From: Tvrtko Ursulin <[email protected]>
Two new tracepoints placed at the call sites where requests are actually passed to the GPU enable userspace to track engine utilisation.
These tracepoints are only enabled when the DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option is enabled.
v2: Fix compilation with !CONFIG_DRM_I915_LOW_LEVEL_TRACEPOINTS.
v3: Name global seqno consistently across tracepoints.
v4: Remove port info from request out tracepoint. (Chris Wilson)
--- drivers/gpu/drm/i915/i915_guc_submission.c | 2 ++ drivers/gpu/drm/i915/i915_trace.h | 49 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_lrc.c | 2 ++ 3 files changed, 53 insertions(+)
drivers/gpu/drm/i915/i915_guc_submission.c +2 -0
@@ -518,6 +518,8 @@ static void __i915_guc_submit(struct drm_i915_gem_request *rq)if (i915_vma_is_map_and_fenceable (rq->ring->vma))POSTING_READ_FW (GUC_STATUS ); +trace_i915_gem_request_in (rq,0 ); + b_ret =guc_ring_doorbell (client); client->submissions[engine_id] +=1 ;
drivers/gpu/drm/i915/i915_trace.h +49 -0
61 lines not on this page · raw message
drivers/gpu/drm/i915/intel_lrc.c +2 -0
@@ -479,6 +479,7 @@ static void execlists_dequeue(struct intel_engine_cs *engine) cursor->priotree.priority =INT_MAX ;__i915_gem_request_submit (cursor); +trace_i915_gem_request_in (cursor, port - engine->execlist_port); last = cursor; submit = true; }
@@ -593,6 +594,7 @@ static void intel_lrc_irq_handler(unsigned long data)execlists_context_status_change (port[0 ].request,INTEL_CONTEXT_SCHEDULE_OUT ); +trace_i915_gem_request_out (port[0 ].request);i915_gem_request_put (port[0 ].request); port[0 ] = port[1 ];memset (&port[1 ],0 ,sizeof (port[1 ]));
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH 8/8 drm/i915/tracepoints: Add hw_id to context tracepoints
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
It is useful to provide this info to match the one provided in the request tracepoints.
--- drivers/gpu/drm/i915/i915_trace.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_trace.h +5 -3
@@ -748,17 +748,19 @@ DECLARE_EVENT_CLASS(i915_context,TP_STRUCT__entry (__field (u32 ,dev ) __field(struct i915_gem_context *, ctx) +__field (u32, hw_id) __field(struct i915_address_space *, vm) ),TP_fast_assign ( + __entry->dev = ctx->i915->drm.primary->index; __entry->ctx = ctx; + __entry->hw_id = ctx->hw_id; __entry->vm = ctx->ppgtt ? &ctx->ppgtt->base :NULL ; - __entry->dev = ctx->i915->drm.primary->index; ), - TP_printk("dev=%u, ctx=%p, ctx_vm=%p", - __entry->dev, __entry->ctx, __entry->vm) + TP_printk("dev=%u, ctx=%p, ctx_vm=%p, hw_id=%u", + __entry->dev, __entry->ctx, __entry->vm, __entry->hw_id) ) DEFINE_EVENT(i915_context, i915_context_create,
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
At the moment only the global seqno is logged which is not set until the request is ready for submission.
Add the per-contex seqno and the context hardware id which are both interesting data points.
Signed-off-by Tvrtko Ursulin <[email protected]>
Some minor conversation pieces, but on the whole, the series is
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Chris Wilson
Reviewed-byQuoted 6 lines · Chris Wilson
Quoted 5 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
At the moment only the global seqno is logged which is not set until the request is ready for submission.
Quoted 7 lines
Quoted 4 lines
Add the per-contex seqno and the context hardware id which are both interesting data points.
Signed-off-by Tvrtko Ursulin <[email protected]>Some minor conversation pieces, but on the whole, the series is
Reviewed-by Chris Wilson <[email protected]>
And the updates lgtm, so
for all
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/8] drm/i915/tracepoints: Tidy request event class
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: series starting with [1/8] drm/i915/tracepoints: Tidy request event class
URL : https://patchwork.freedesktop.org/series/19994/
State : success
== Summary ==
Series 19994v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/19994/revisions/1/mbox/
fi-bdw-5557u total:253 pass:242 dwarn:0 dfail:0 fail:0 skip:11 fi-bsw-n3050 total:253 pass:214 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:253 pass:234 dwarn:0 dfail:0 fail:0 skip:19 fi-bxt-t5700 total:83 pass:70 dwarn:0 dfail:0 fail:0 skip:12 fi-byt-j1900 total:253 pass:226 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-n2820 total:253 pass:222 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:253 pass:237 dwarn:0 dfail:0 fail:0 skip:16 fi-hsw-4770r total:253 pass:237 dwarn:0 dfail:0 fail:0 skip:16 fi-ilk-650 total:253 pass:203 dwarn:0 dfail:0 fail:0 skip:50 fi-ivb-3520m total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-ivb-3770 total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-kbl-7500u total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-skl-6260u total:253 pass:243 dwarn:0 dfail:0 fail:0 skip:10 fi-skl-6700hq total:253 pass:236 dwarn:0 dfail:0 fail:0 skip:17 fi-skl-6700k total:253 pass:231 dwarn:4 dfail:0 fail:0 skip:18 fi-skl-6770hq total:253 pass:243 dwarn:0 dfail:0 fail:0 skip:10 fi-snb-2520m total:253 pass:225 dwarn:0 dfail:0 fail:0 skip:28 fi-snb-2600 total:253 pass:224 dwarn:0 dfail:0 fail:0 skip:29
0a03ea9496b49746b4964d05cc1f483385d1df8a drm-tip: 2017y-02m-20d-17h-19m-56s UTC integration manifest ccaaf31 drm/i915/tracepoints: Add hw_id to context tracepoints
f9c512c drm/i915/tracepoints: Add backend level request in and out tracepoints 213162b drm/i915/tracepoints: Rename i915_gem_request_notify
9af3ce4 drm/i915/tracepoints: Add request submit and execute tracepoints
d5d8820 drm/i915/tracepoints: Remove unused i915_gem_request_complete
4925b43 drm/i915/tracepoints: Tidy i915_gem_request_wait_begin
78983bb drm/i915/tracepoints: Adjust i915_gem_ring_dispatch
05219be drm/i915/tracepoints: Tidy request event class
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3906/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/8] drm/i915/tracepoints: Tidy request event class (rev4)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: series starting with [1/8] drm/i915/tracepoints: Tidy request event class (rev4)
URL : https://patchwork.freedesktop.org/series/19994/
State : success
== Summary ==
Series 19994v4 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/19994/revisions/4/mbox/
fi-bdw-5557u total:253 pass:242 dwarn:0 dfail:0 fail:0 skip:11 fi-bsw-n3050 total:253 pass:214 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:253 pass:234 dwarn:0 dfail:0 fail:0 skip:19 fi-bxt-t5700 total:83 pass:70 dwarn:0 dfail:0 fail:0 skip:12 fi-byt-j1900 total:253 pass:226 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-n2820 total:253 pass:222 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:253 pass:237 dwarn:0 dfail:0 fail:0 skip:16 fi-hsw-4770r total:253 pass:237 dwarn:0 dfail:0 fail:0 skip:16 fi-ilk-650 total:253 pass:203 dwarn:0 dfail:0 fail:0 skip:50 fi-ivb-3520m total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-ivb-3770 total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-kbl-7500u total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-skl-6260u total:253 pass:243 dwarn:0 dfail:0 fail:0 skip:10 fi-skl-6700hq total:253 pass:236 dwarn:0 dfail:0 fail:0 skip:17 fi-skl-6700k total:253 pass:231 dwarn:4 dfail:0 fail:0 skip:18 fi-skl-6770hq total:253 pass:243 dwarn:0 dfail:0 fail:0 skip:10 fi-snb-2520m total:253 pass:225 dwarn:0 dfail:0 fail:0 skip:28 fi-snb-2600 total:253 pass:224 dwarn:0 dfail:0 fail:0 skip:29
0a03ea9496b49746b4964d05cc1f483385d1df8a drm-tip: 2017y-02m-20d-17h-19m-56s UTC integration manifest fdf3bad drm/i915/tracepoints: Add hw_id to context tracepoints
6d071e3 drm/i915/tracepoints: Add backend level request in and out tracepoints ef730d9 drm/i915/tracepoints: Rename i915_gem_request_notify
8091bc4 drm/i915/tracepoints: Add request submit and execute tracepoints
ef253f3 drm/i915/tracepoints: Remove unused i915_gem_request_complete
7430dbb drm/i915/tracepoints: Tidy i915_gem_request_wait_begin
fd9296e drm/i915/tracepoints: Adjust i915_gem_ring_dispatch
db2870b drm/i915/tracepoints: Tidy request event class
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3910/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for series starting with [1/8] drm/i915/tracepoints: Tidy request event class (rev4)
Quoted 30 lines · Patchwork
== Series Details ==
Series: series starting with [1/8] drm/i915/tracepoints: Tidy request event class (rev4)
URL : https://patchwork.freedesktop.org/series/19994/
State : success== Summary ==
Series 19994v4 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/19994/revisions/4/mbox/fi-bdw-5557u total:253 pass:242 dwarn:0 dfail:0 fail:0 skip:11 fi-bsw-n3050 total:253 pass:214 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:253 pass:234 dwarn:0 dfail:0 fail:0 skip:19 fi-bxt-t5700 total:83 pass:70 dwarn:0 dfail:0 fail:0 skip:12 fi-byt-j1900 total:253 pass:226 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-n2820 total:253 pass:222 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:253 pass:237 dwarn:0 dfail:0 fail:0 skip:16 fi-hsw-4770r total:253 pass:237 dwarn:0 dfail:0 fail:0 skip:16 fi-ilk-650 total:253 pass:203 dwarn:0 dfail:0 fail:0 skip:50 fi-ivb-3520m total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-ivb-3770 total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-kbl-7500u total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-skl-6260u total:253 pass:243 dwarn:0 dfail:0 fail:0 skip:10 fi-skl-6700hq total:253 pass:236 dwarn:0 dfail:0 fail:0 skip:17 fi-skl-6700k total:253 pass:231 dwarn:4 dfail:0 fail:0 skip:18 fi-skl-6770hq total:253 pass:243 dwarn:0 dfail:0 fail:0 skip:10 fi-snb-2520m total:253 pass:225 dwarn:0 dfail:0 fail:0 skip:28 fi-snb-2600 total:253 pass:224 dwarn:0 dfail:0 fail:0 skip:29
Quoted 9 lines
0a03ea9496b49746b4964d05cc1f483385d1df8adrm-tip: 2017y-02m-20d-17h-19m-56s UTC integration manifest fdf3bad drm/i915/tracepoints: Addhw_idto context tracepoints
6d071e3 drm/i915/tracepoints: Add backend level request in and out tracepoints ef730d9 drm/i915/tracepoints: Renamei915_gem_request_notify
8091bc4 drm/i915/tracepoints: Add request submit and execute tracepoints
ef253f3 drm/i915/tracepoints: Remove unusedi915_gem_request_complete
7430dbb drm/i915/tracepoints: Tidyi915_gem_request_wait_begin
fd9296e drm/i915/tracepoints: Adjusti915_gem_ring_dispatch
db2870b drm/i915/tracepoints: Tidy request event class
Pushed, thanks for the review.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx