usercopy: ARM NOMMU has no 64-bit get_user
PATCH 1/1 usercopy: ARM NOMMU has no 64-bit get_user
On a NOMMU ARM kernel, we get this link error:
ERROR: "__get_user_bad" [lib/test_user_copy.ko] undefined!
The problem is that the extended get_user/put_user definitions were only added for the noral (MMU based) case.
We could add it for NOMMU as well, but it seems easier to just not call it, since no other code needs it.
Fixes 075c4ea5363d ("usercopy: Add tests for all get_user() sizes")
Signed-off-by Arnd Bergmann <[email protected]>
--- lib/test_user_copy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
lib/test_user_copy.c +2 -1
@@ -30,7 +30,8 @@* As there doesn't appear to be anything that can safely determine * their capability at compile-time, we just have to opt-out certain archs. */ -#if BITS_PER_LONG == 64 || (!defined(CONFIG_AVR32) && \ +#if BITS_PER_LONG == 64 || (!(defined(CONFIG_ARM) && !defined(MMU)) && \ + !defined(CONFIG_AVR32) && \ !defined(CONFIG_BLACKFIN) && \ !defined(CONFIG_M32R) && \ !defined(CONFIG_M68K) && \
Signature · 1 line
2.9.0
Quoted 4 lines · Arnd Bergmann
On a NOMMU ARM kernel, we get this link error:
ERROR: "
__get_user_bad" [lib/test_user_copy.ko] undefined!
Quoted 8 lines
The problem is that the extended get_user/put_user definitions were only added for the noral (MMU based) case.
We could add it for NOMMU as well, but it seems easier to just not call it, since no other code needs it.
Fixes 075c4ea5363d ("usercopy: Add tests for all get_user() sizes")Signed-off-by Arnd Bergmann <[email protected]>
Ah, excellent, thanks! I'll get this in.
-Kees
Quoted 21 lines
--- lib/test_user_copy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)lib/test_user_copy.c +2
-2@@ -30,7 +30,8 @@* As there doesn't appear to be anything that can safely determine * their capability at compile-time, we just have to opt-out certain archs. */ -#if BITS_PER_LONG == 64 || (!defined(CONFIG_AVR32) && \ +#if BITS_PER_LONG == 64 || (!(defined(CONFIG_ARM) && !defined(MMU)) && \ + !defined(CONFIG_AVR32) && \ !defined(CONFIG_BLACKFIN) && \ !defined(CONFIG_M32R) && \ !defined(CONFIG_M68K) && \ --2.9.0
Signature · 2 lines
Kees Cook Pixel Security