fs/9p: Compare qid.path in v9fs_test_inode
Subsystems (3)
PATCH 1/1 fs/9p: Compare qid.path in v9fs_test_inode
Commit fd2421f54423 ("fs/9p: When doing inode lookup compare qid details and inode mode bits.") transformed v9fs_qid_iget() to use iget5_locked() instead of iget_locked(). However, the test() callback is not checking fid.path at all, which means that a lookup in the inode cache can now accidentally locate a completely wrong inode from the same inode hash bucket if the other fields (qid.type and qid.version) match.
---
Does this sound sensible? I have never reproduced the problem myself but reportedly this patch solves some really weird problems where the symptoms match (wrong files being opened unpredictably).
--- fs/9p/vfs_inode.c | 3 +++ fs/9p/vfs_inode_dotl.c | 3 +++ 2 files changed, 6 insertions(+)
fs/9p/vfs_inode.c +3 -0
@@ -483,6 +483,9 @@ static int v9fs_test_inode(struct inode *inode, void *data)if (v9inode->qid.type != st->qid.type)return 0 ; + +if (v9inode->qid.path != st->qid.path) +return 0 ;return 1 ; }
fs/9p/vfs_inode_dotl.c +3 -0
@@ -87,6 +87,9 @@ static int v9fs_test_inode_dotl(struct inode *inode, void *data)if (v9inode->qid.type != st->qid.type)return 0 ; + +if (v9inode->qid.path != st->qid.path) +return 0 ;return 1 ; }
Signature · 1 line
2.11.1
Quoted 7 lines · On Wed, 22 Feb 2017 02:06:29 +0200 Tuomas Tynkkynen <[email protected]> wrote:
Commit
fd2421f54423("fs/9p: When doing inode lookup compare qid details and inode mode bits.") transformedv9fs_qid_iget()to useiget5_locked()instead ofiget_locked(). However, thetest()callback is not checking fid.path at all, which means that a lookup in the inode cache can now accidentally locate a completely wrong inode from the same inode hash bucket if the other fields (qid.type and qid.version) match.
Al, does this sound sensible? (or if there is someone else picking up 9p patches, let me know).
Thanks!
- Tuomas
Quoted 50 lines · Tuomas Tynkkynen
Commit
fd2421f54423("fs/9p: When doing inode lookup compare qid details and inode mode bits.") transformedv9fs_qid_iget()to useiget5_locked()instead ofiget_locked(). However, thetest()callback is not checking fid.path at all, which means that a lookup in the inode cache can now accidentally locate a completely wrong inode from the same inode hash bucket if the other fields (qid.type and qid.version) match.Fixes fd2421f54423 ("fs/9p: When doing inode lookup compare qid details and inode mode bits.")Signed-off-by Tuomas Tynkkynen <[email protected]>---
Does this sound sensible? I have never reproduced the problem myself but reportedly this patch solves some really weird problems where the symptoms match (wrong files being opened unpredictably).--- fs/9p/vfs_inode.c | 3 +++ fs/9p/vfs_inode_dotl.c | 3 +++ 2 files changed, 6 insertions(+)fs/9p/vfs_inode.c +3
-0@@ -483,6 +483,9 @@ static int v9fs_test_inode(struct inode *inode, void *data)if (v9inode->qid.type != st->qid.type)return 0 ; + +if (v9inode->qid.path != st->qid.path) +return 0 ;return 1 ; }fs/9p/vfs_inode_dotl.c +3
-1@@ -87,6 +87,9 @@ static int v9fs_test_inode_dotl(struct inode *inode, void *data)if (v9inode->qid.type != st->qid.type)return 0 ; + +if (v9inode->qid.path != st->qid.path) +return 0 ;return 1 ; } --2.11.1