ARM64: Initial Marvell IAP140 enablement
Subsystems (8)
v2 cover ARM64: Initial Marvell IAP140 enablement
Hello,
This series adds initial support for the Marvell IAP140 SoC (aka PXA1908) and the Andromeda Box Edge development board.
v2 reuses ARCH_MMP.
Both earlycon and serial are working, but an explicit console=ttyS0,115200n8 is needed; with just "earlycon" and stdout-path the earlycon stops early and switches to a tty0, long before disabling the bootconsole...
All four CPUs come up, and an initrd can be reached.
However, there are errors about CPUs 1-3 having a zero SYS_CNTFRQ_EL0:
[ 0.095812] smp: Bringing up secondary CPUs ... ======pxa1908_pmu_core_pwr_on: mpidr = 0x1 ======pxa1908_pmu_core_pwr_on: mpidr = 0x2 ======pxa1908_pmu_core_pwr_on: mpidr = 0x3 [ 0.133419] Detected VIPT I-cache on CPU1 [ 0.133430] CPU features: SANITY CHECK: Unexpected variation in SYS_CNTFRQ_EL0. Boot CPU: 0x000000018cba80, CPU1: 0x00000000000000 [ 0.133447] Unsupported CPU feature variation. ... [ 0.133748] CPU1: Booted secondary processor [410fd032] [ 0.165465] Detected VIPT I-cache on CPU2 [ 0.165474] CPU features: SANITY CHECK: Unexpected variation in SYS_CNTFRQ_EL0. Boot CPU: 0x000000018cba80, CPU2: 0x00000000000000 [ 0.165505] CPU2: Booted secondary processor [410fd032] [ 0.197539] Detected VIPT I-cache on CPU3 [ 0.197546] CPU features: SANITY CHECK: Unexpected variation in SYS_CNTFRQ_EL0. Boot CPU: 0x000000018cba80, CPU3: 0x00000000000000 [ 0.197573] CPU3: Booted secondary processor [410fd032] [ 0.197625] smp: Brought up 1 node, 4 CPUs [ 0.522514] SMP: Total of 4 processors activated. [ 0.527212] CPU features: detected feature: 32-bit EL0 Support [ 0.533105] CPU: All CPU(s) started at EL2
KVM appears to initialize okay, but was not yet tested with guests.
[ 0.865255] kvm [1]: 8-bit VMID [ 0.868401] kvm [1]: IDMAP page: d23000 [ 0.872233] kvm [1]: HYP VA range: 800000000000:ffffffffffff [ 0.878262] kvm [1]: Hyp mode initialized successfully [ 0.883429] kvm [1]: vgic-v2 at d1dfc000 [ 0.887179] kvm [1]: vgic interrupt IRQ1 [ 0.891120] kvm [1]: virtual timer IRQ4
One limitation is currently the lack of an IAP140 clk driver. Patch 4/4 works around that for UART0 with a fixed-clock.
A 3.14 based tree is available on GitHub acorn-marvell/brillo_pxa_kernel.
Booting required changes to the vendor U-Boot,
cf. https://en.opensuse.org/HCL:AndromedaBoxEdge
https://github.com/afaerber/linux/commits/edge-next
Have a lot of fun!
Cheers,
Andreas
v1 -> v2:
* Add non-DT documentation
* Use ARCH_MMP instead of ARCH_PXA
* Split off Kconfig cleanups per subsystem
* Drop "mrvl,pxa-uart" and instead implement mmp earlycon
* Add some more DT nodes
Andreas F?rber (8):
Documentation: arm: Marvell: Document IAP140
tty: serial: Suppress deprecated SERIAL_PXA on arm64
tty: serial: 8250_pxa: Implement mmp earlycon
sound: soc: pxa: Suppress SND_MMP_SOC for arm64
ARM64: Prepare Marvell IAP140 aka PXA1908
Documentation: devicetree: arm: marvell: Document IAP140
ARM64: dts: marvell: Add IAP140 and Andromeda Box Edge
ARM64: dts: marvell: iap140-andromeda-box-edge: Add uart0 clock
Documentation/arm/Marvell/README | 12 +- .../devicetree/bindings/arm/marvell/iap140.txt | 11 + arch/arm64/Kconfig.platforms | 7 + arch/arm64/boot/dts/marvell/Makefile | 3 + .../boot/dts/marvell/iap140-andromeda-box-edge.dts | 87 ++++++++ arch/arm64/boot/dts/marvell/iap140.dtsi | 241 +++++++++++++++++++++ drivers/tty/serial/8250/8250_pxa.c | 1 + drivers/tty/serial/Kconfig | 2 +- sound/soc/pxa/Kconfig | 4 +- 9 files changed, 364 insertions(+), 4 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/marvell/iap140.txt create mode 100644 arch/arm64/boot/dts/marvell/iap140-andromeda-box-edge.dts create mode 100644 arch/arm64/boot/dts/marvell/iap140.dtsi
Signature · 1 line
2.10.2
PATCH v2 1/8 Documentation: arm: Marvell: Document IAP140
IAP140 is either based on or was renamed from PXA1908.
---
v2: new (Thomas)
Documentation/arm/Marvell/README | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
Documentation/arm/Marvell/README +11 -1
@@ -243,7 +243,7 @@ PXA 2xx/3xx/93x/95x family Linux kernel plat directory: arch/arm/plat-pxa MMP/MMP2/MMP3 family (communication processor) ------------------------------------------ +---------------------------------------------- Flavors: PXA168, a.k.a Armada 168
@@ -295,6 +295,16 @@ MMP/MMP2/MMP3 family (communication processor) Linux kernel mach directory: arch/arm/mach-mmp Linux kernel plat directory: arch/arm/plat-pxa +MMP ARMv8 family (application processor) +---------------------------------------- + + Flavors: + IAP140 + Product brief: http://www.marvell.com/application-processors/assets/Marvell-IAP140-Platform-Brief-20160601.pdf + Core: quad-core ARMv8 Cortex-A53 + + Homepage: http://www.marvell.com/application-processors/ + Berlin family (Multimedia Solutions) -------------------------------------
Signature · 1 line
2.10.2
PATCH v2 2/8 tty: serial: Suppress deprecated SERIAL_PXA on arm64
In reply to Andreas FärberWith Marvell IAP140 being enabled as first arm64 MMP platform, don't make the deprecated SERIAL_PXA option available outside ARM.
---
v1 -> v2: split off
* Updated for ARCH_MMP
drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/Kconfig +1 -1
@@ -439,7 +439,7 @@ config SERIAL_MPSC_CONSOLE config SERIAL_PXA bool "PXA serial port support (DEPRECATED)" - depends on ARCH_PXA || ARCH_MMP + depends on ARCH_PXA || (ARCH_MMP && ARM) select SERIAL_CORE select SERIAL_8250_PXA if SERIAL_8250=y select SERIAL_PXA_NON8250 if !SERIAL_8250=y
Signature · 1 line
2.10.2
PATCH v2 3/8 tty: serial: 8250_pxa: Implement mmp earlycon
In reply to Andreas FärberThere is an early_pxa earlycon available for "mrvl,pxa-uart", but mmp2.dtsi and soon iap140.dtsi have only "mrvl,mmp-uart". The binding does not mandate to have the fallback, so add a second earlycon for this alternative compatible string.
---
Note: early_pxa is not documented in kernel-parameters.txt, so not adding
mmp either for now.
Should early_pxa be renamed to / accompanied by pxa before it gets documented? An early_ prefix seems uncommon and redundant, thus not adopting here for mmp.
v2: new
drivers/tty/serial/8250/8250_pxa.c | 1 + 1 file changed, 1 insertion(+)
drivers/tty/serial/8250/8250_pxa.c +1 -0
@@ -183,6 +183,7 @@ static int __init early_serial_pxa_setup(struct earlycon_device *device, return early_serial8250_setup(device, NULL); }OF_EARLYCON_DECLARE (early_pxa,"mrvl,pxa-uart" , early_serial_pxa_setup); +OF_EARLYCON_DECLARE (mmp,"mrvl,mmp-uart" , early_serial_pxa_setup);#endif MODULE_AUTHOR ("Sergei Ianovich" );
Signature · 1 line
2.10.2
PATCH v2 4/8 sound: soc: pxa: Suppress SND_MMP_SOC for arm64
In reply to Andreas FärberSND_MMP_SOC selects SND_ARM, which is limited to ARM, as well as MMP_SRAM, which is a non-DT driver in arch/arm/mach-arm/.
Avoid Kconfig warnings by not making this driver available on ARM64.
While at it, tidy the title (Soc -> SoC).
---
v2: new
sound/soc/pxa/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/pxa/Kconfig +2 -2
@@ -8,8 +8,8 @@ config SND_PXA2XX_SOC to select the audio interfaces to support below. config SND_MMP_SOC - bool "Soc Audio for Marvell MMP chips" - depends on ARCH_MMP + bool "SoC Audio for Marvell MMP chips" + depends on ARCH_MMP && ARM select MMP_SRAM select SND_SOC_GENERIC_DMAENGINE_PCM select SND_ARM
Signature · 1 line
2.10.2
Mark Brown
maintainerRe: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64
On Wed, Feb 22, 2017 at 03:29:24AM +0100, Andreas Färber wrote:
This is patch 4 of 8, what's going on with dependencies here?
Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.
sound/soc/pxa/Kconfig config SND_PXA2XX_SOC · line 12
Quoted 5 lines
config
SND_MMP_SOCsound/soc/pxa/Kconfig +2
-2- bool "Soc Audio for Marvell MMP chips" - depends on ARCH_MMP + bool "SoC Audio for Marvell MMP chips" + depends on ARCH_MMP && ARM
There are no obvious build time architecture dependencies for this driver, shouldn't we have an || COMPILE_TEST in here?
Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64
Am 22.02.2017 um 19:47 schrieb Mark Brown:
Quoted 3 lines · Andreas Färber
This is patch 4 of 8, what's going on with dependencies here?
No dependencies on previous patches. 5/8 adds ARCH_MMP to arm64.
It compiled without this (just Kconfig warnings), so this could go through the appropriate sound tree as a cleanup.
Quoted 2 lines
Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.
Should I make it "ASoC: pxa: ..." then? SND_MMP_SOC selects SND_ARM, which in sound/arm/Kconfig says 'Drivers that are implemented on ASoC can be found in "ALSA for SoC audio support" section.', which confused me about whether or not this is an ASoC compliant driver if it selects a non-ASoC symbol.
Quoted 8 lines
sound/soc/pxa/Kconfig config SND_PXA2XX_SOC · line 12
Quoted 5 lines
config
SND_MMP_SOCsound/soc/pxa/Kconfig +2
-2- bool "Soc Audio for Marvell MMP chips" - depends on ARCH_MMP + bool "SoC Audio for Marvell MMP chips" + depends on ARCH_MMP && ARMThere are no obvious build time architecture dependencies for this driver, shouldn't we have an ||
COMPILE_TESTin here?
I'm the wrong person to answer that - the symbol relies on architecture-specific SND_ARM, and my understanding was that the code still relies on platform data, therefore it did not seem worthwhile to just disable inapplicable dependencies such as MMP_SRAM (arch/arm/mach-mmp/; superseded by DT mmio-sram) or SND_ARM.
Regards,
Andreas
Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64
Quoted 11 lines · Andreas Färber
Am 22.02.2017 um 19:47 schrieb Mark Brown:
Quoted 3 lines · Andreas Färber
This is patch 4 of 8, what's going on with dependencies here?
No dependencies on previous patches. 5/8 adds
ARCH_MMPto arm64.It compiled without this (just
Kconfigwarnings), so this could go through the appropriate sound tree as a cleanup.
Quoted 8 lines
Quoted 2 lines
Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.
Should I make it "ASoC: pxa: ..." then?
SND_MMP_SOCselectsSND_ARM, which insound/arm/Kconfigsays 'Drivers that are implemented on ASoC can be found in "ALSA for SoC audio support" section.', which confused me about whether or not this is an ASoC compliant driver if it selects a non-ASoC symbol.
It's a bug that selects SND_ARM there. I guess this was wrongly taken from the old example of AC97 ARM SoC code, which was fixed later. ASoC stuff is basically irrelevant from the legacy sound/arm/*.
thanks,
Takashi
Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64
Am 23.02.2017 um 15:24 schrieb Takashi Iwai:
Quoted 12 lines
Quoted 9 lines · Andreas F?rber
Am 22.02.2017 um 19:47 schrieb Mark Brown:
Quoted 2 lines
Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.
Should I make it "ASoC: pxa: ..." then?
SND_MMP_SOCselectsSND_ARM, which insound/arm/Kconfigsays 'Drivers that are implemented on ASoC can be found in "ALSA for SoC audio support" section.', which confused me about whether or not this is an ASoC compliant driver if it selects a non-ASoC symbol.
Quoted 3 lines
It's a bug that selects
SND_ARMthere. I guess this was wrongly taken from the old example of AC97 ARM SoC code, which was fixed later. ASoC stuff is basically irrelevant from the legacysound/arm/*.
Thanks, Takashi-san. I'll update as follows then.
sound/soc/pxa/Kconfig +2 -3
@@ -9,10 +9,9 @@ config SND_PXA2XX_SOC config SND_MMP_SOC bool "SoC Audio for Marvell MMP chips" - depends on ARCH_MMP && ARM - select MMP_SRAM + depends on ARCH_MMP || COMPILE_TEST + select MMP_SRAM if ARM select SND_SOC_GENERIC_DMAENGINE_PCM - select SND_ARM help Say Y if you want to add support for codecs attached to the MMP SSPA interface.
Okay to do that in one patch or break up into three?
Regards,
Andreas
Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg)
PATCH v2 5/8 ARM64: Prepare Marvell IAP140 aka PXA1908
In reply to Andreas FärberMake ARCH_MMP available on arm64, too.
---
v1 -> v2:
* Switched from ARCH_PXA to ARCH_MMP - obsoletes clk and mmp Kconfig changes
* Split off serial Kconfig cleanup
arch/arm64/Kconfig.platforms | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm64/Kconfig.platforms +7 -0
@@ -111,6 +111,13 @@ config ARCH_MVEBU - Armada 7K SoC Family - Armada 8K SoC Family +config ARCH_MMP + bool "Marvell MMP SoC Family" + select PINCTRL + select PINCTRL_SINGLE + help + This enables support for the Marvell MMP family. + config ARCH_QCOM bool "Qualcomm Platforms" select GPIOLIB
Signature · 1 line
2.10.2
PATCH v2 6/8 Documentation: devicetree: arm: marvell: Document IAP140
In reply to Andreas Färber---
v1 -> v2:
* Adopted "marvell" vendor prefix (Thomas)
* Documented Andromeda Box Edge as example
Documentation/devicetree/bindings/arm/marvell/iap140.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/iap140.txt
Documentation/devicetree/bindings/arm/marvell/iap140.txt new file +11 -0
@@ -0,0 +1,11 @@ +Marvell IAP140 Device Tree Bindings +----------------------------------- + +Boards using a SoC of the Marvell IAP140 family must carry the following +root node property: + + - compatible : must contain "marvell,iap140" + +Example: + + compatible = "marvell,andromeda-box-edge", "marvell,iap140";
Signature · 1 line
2.10.2
Re: [PATCH v2 6/8] Documentation: devicetree: arm: marvell: Document IAP140
Quoted 9 lines · Andreas F?rber
Signed-off-by Andreas F?rber <[email protected]>---
v1 -> v2:
* Adopted "marvell" vendor prefix (Thomas)
* Documented Andromeda Box Edge as exampleDocumentation/devicetree/bindings/arm/marvell/iap140.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/iap140.txt
PATCH v2 7/8 ARM64: dts: marvell: Add IAP140 and Andromeda Box Edge
In reply to Andreas FärberPPI interrupts 11, 10, 9 are guesses, and so are the second two memory regions of the GIC.
---
v1 -> v2:
* Updated for ARCH_MMP, added Makefile comment
* Adopted "marvell" vendor prefix (Thomas)
* Disabled smmu in .dtsi, re-enabled in .dts
* Enabled asram node
* Added adma, timer, pinctrl nodes
arch/arm64/boot/dts/marvell/Makefile | 3 + .../boot/dts/marvell/iap140-andromeda-box-edge.dts | 80 +++++++ arch/arm64/boot/dts/marvell/iap140.dtsi | 241 +++++++++++++++++++++ 3 files changed, 324 insertions(+) create mode 100644 arch/arm64/boot/dts/marvell/iap140-andromeda-box-edge.dts create mode 100644 arch/arm64/boot/dts/marvell/iap140.dtsi
arch/arm64/boot/dts/marvell/Makefile +3 -0
@@ -2,6 +2,9 @@ dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-dmp.dtb dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-stb.dtb +# MMP SoC Family +dtb-$(CONFIG_ARCH_MMP) += iap140-andromeda-box-edge.dtb + # Mvebu SoC Family dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
arch/arm64/boot/dts/marvell/iap140-andromeda-box-edge.dts new file +80 -0
80 lines not on this page · raw message
arch/arm64/boot/dts/marvell/iap140.dtsi new file +241 -0
241 lines not on this page · raw message
Signature · 1 line
2.10.2
PATCH v2 8/8 ARM64: dts: marvell: iap140-andromeda-box-edge: Add uart0 clock
In reply to Andreas FärberUse a fixed clock to enable ttyS0 output.
---
v1 -> v2: unchanged
arch/arm64/boot/dts/marvell/iap140-andromeda-box-edge.dts | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/marvell/iap140-andromeda-box-edge.dts +7 -0
@@ -63,6 +63,12 @@ device_type = "memory"; reg = <0x0 0x0 0x0 0x40000000>; }; + + uart0_clk: uart0-clk { + compatible = "fixed-clock"; + clock-frequency = <14740000>; + #clock-cells = <0>; + }; }; &pmx {
@@ -77,4 +83,5 @@ &uart0 { status = "okay"; + clocks = <&uart0_clk>; };
Signature · 1 line
2.10.2
Rob Herring
maintainerQuoted 45 lines · Andreas F?rber
Hello,
This series adds initial support for the Marvell IAP140 SoC (aka PXA1908) and the Andromeda Box Edge development board.
v2 reuses
ARCH_MMP.Both earlycon and serial are working, but an explicit console=ttyS0,115200n8 is needed; with just "earlycon" and stdout-path the earlycon stops early and switches to a tty0, long before disabling the bootconsole...
All four CPUs come up, and an initrd can be reached.
However, there are errors about CPUs 1-3 having a zero
SYS_CNTFRQ_EL0:[ 0.095812] smp: Bringing up secondary CPUs ... ======pxa1908_pmu_core_pwr_on: mpidr = 0x1 ======pxa1908_pmu_core_pwr_on: mpidr = 0x2 ======pxa1908_pmu_core_pwr_on: mpidr = 0x3 [ 0.133419] Detected VIPT I-cache on CPU1 [ 0.133430] CPU features: SANITY CHECK: Unexpected variation in SYS_CNTFRQ_EL0. Boot CPU: 0x000000018cba80, CPU1: 0x00000000000000 [ 0.133447] Unsupported CPU feature variation. ... [ 0.133748] CPU1: Booted secondary processor [410fd032] [ 0.165465] Detected VIPT I-cache on CPU2 [ 0.165474] CPU features: SANITY CHECK: Unexpected variation in SYS_CNTFRQ_EL0. Boot CPU: 0x000000018cba80, CPU2: 0x00000000000000 [ 0.165505] CPU2: Booted secondary processor [410fd032] [ 0.197539] Detected VIPT I-cache on CPU3 [ 0.197546] CPU features: SANITY CHECK: Unexpected variation in SYS_CNTFRQ_EL0. Boot CPU: 0x000000018cba80, CPU3: 0x00000000000000 [ 0.197573] CPU3: Booted secondary processor [410fd032] [ 0.197625] smp: Brought up 1 node, 4 CPUs [ 0.522514] SMP: Total of 4 processors activated. [ 0.527212] CPU features: detected feature: 32-bit EL0 Support [ 0.533105] CPU: All CPU(s) started at EL2KVM appears to initialize okay, but was not yet tested with guests.
[ 0.865255] kvm [1]: 8-bit VMID [ 0.868401] kvm [1]: IDMAP page: d23000 [ 0.872233] kvm [1]: HYP VA range: 800000000000:ffffffffffff [ 0.878262] kvm [1]: Hyp mode initialized successfully [ 0.883429] kvm [1]: vgic-v2 at d1dfc000 [ 0.887179] kvm [1]: vgic interrupt IRQ1 [ 0.891120] kvm [1]: virtual timer IRQ4
Quoted 2 lines
One limitation is currently the lack of an IAP140 clk driver. Patch 4/4 works around that for UART0 with a fixed-clock.
The PXA1928 clock driver should be close to what you need. They are supposed to be very similar.
Quoted 24 lines
A 3.14 based tree is available on GitHub acorn-marvell/brillo_pxa_kernel.
Booting required changes to the vendor U-Boot,
cf. https://en.opensuse.org/HCL:AndromedaBoxEdgehttps://github.com/afaerber/linux/commits/edge-next
Have a lot of fun!
Cheers,
Andreasv1 -> v2:
* Add non-DT documentation
* UseARCH_MMPinstead ofARCH_PXA
* Split offKconfigcleanups per subsystem
* Drop "mrvl,pxa-uart" and instead implement mmp earlycon
* Add some more DT nodesCc Thomas Petazzoni <[email protected]>Cc Gregory Clement <[email protected]>Cc info at andromedabox.orgCc devicetree at vger.kernel.org
Quoted 4 lines
Andreas F?rber (8):
Documentation: arm: Marvell: Document IAP140
tty: serial: Suppress deprecatedSERIAL_PXAon arm64
tty: serial: 8250_pxa: Implement mmp earlycon
You should not use the pxa serial driver. AFAICT, it was separate to add DMA support, but now the base 8250 driver supports DMA. The base 8250 driver works with the PXA1928 and should also work with the PXA1908.
Quoted 6 lines
sound: soc: pxa: Suppress
SND_MMP_SOCfor arm64
ARM64: Prepare Marvell IAP140 aka PXA1908
Documentation: devicetree: arm: marvell: Document IAP140
ARM64: dts: marvell: Add IAP140 and Andromeda Box Edge
ARM64: dts: marvell: iap140-andromeda-box-edge: Add uart0 clock
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob,
Am 22.02.2017 um 14:34 schrieb Rob Herring:
Quoted 6 lines · Andreas F?rber
Quoted 2 lines
One limitation is currently the lack of an IAP140 clk driver. Patch 4/4 works around that for UART0 with a fixed-clock.
The PXA1928 clock driver should be close to what you need. They are supposed to be very similar.
Where do you see that in mainline? Not in drivers/clk/pxa/ at least. I'm certain the acorn-marvell tree has a PXA1908 clk driver somewhere, too, I just haven't ported it yet.
Quoted 9 lines
Quoted 4 lines
Andreas F?rber (8):
Documentation: arm: Marvell: Document IAP140
tty: serial: Suppress deprecatedSERIAL_PXAon arm64
tty: serial: 8250_pxa: Implement mmp earlyconYou should not use the pxa serial driver. AFAICT, it was separate to add DMA support, but now the base 8250 driver supports DMA. The base 8250 driver works with the PXA1928 and should also work with the PXA1908.
Do you personally have one? I didn't spot a pxa1928 DT in mainline.
So, by my reading both 8250_of.c and 8250_pxa.c list "mrvl,mmp-uart" for the platform driver. Is that really intentional?
What the early_pxa earlycon does is set the register shift and then reuse the 8250 core - that looks perfectly valid to me. Are you possibly mixing that up with the non-8250 pxa serial driver that I am already suppressing one patch earlier?
While at it, are you aware that we have two drivers, one pxa and one mmp, that bind to "marvell,pdma-1.0"? That seemed wrong to me, too.
Regards,
Andreas
Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg)
Am 22.02.2017 um 17:43 schrieb Andreas F?rber:
Quoted 26 lines
Hi Rob,
Am 22.02.2017 um 14:34 schrieb Rob Herring:
Quoted 6 lines · Andreas F?rber
Quoted 2 lines
One limitation is currently the lack of an IAP140 clk driver. Patch 4/4 works around that for UART0 with a fixed-clock.
The PXA1928 clock driver should be close to what you need. They are supposed to be very similar.
Where do you see that in mainline? Not in
drivers/clk/pxa/at least. I'm certain the acorn-marvell tree has a PXA1908 clk driver somewhere, too, I just haven't ported it yet.Quoted 9 lines
Quoted 4 lines
Andreas F?rber (8):
Documentation: arm: Marvell: Document IAP140
tty: serial: Suppress deprecatedSERIAL_PXAon arm64
tty: serial: 8250_pxa: Implement mmp earlyconYou should not use the pxa serial driver. AFAICT, it was separate to add DMA support, but now the base 8250 driver supports DMA. The base 8250 driver works with the PXA1928 and should also work with the PXA1908.
Do you personally have one? I didn't spot a pxa1928 DT in mainline.
Quoted 7 lines
So, by my reading both
8250_of.cand8250_pxa.clist "mrvl,mmp-uart" for the platform driver. Is that really intentional?What the
early_pxaearlycon does is set the register shift and then reuse the 8250 core - that looks perfectly valid to me. Are you possibly mixing that up with the non-8250 pxa serial driver that I am already suppressing one patch earlier?
Hit send too early: There's also 8250_early.c, but that does not appear to use the reg-shift property (which is not mentioned in the mrvl,mmp-uart binding) and thus omap has a custom earlycon driver there, similar to what is in 8250_pxa.c.
Quoted 7 lines
While at it, are you aware that we have two drivers, one pxa and one mmp, that bind to "marvell,pdma-1.0"? That seemed wrong to me, too.
Regards,
Andreas
Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg)
Rob Herring
maintainerQuoted 7 lines · Andreas F?rber
Hi Rob,
Am 22.02.2017 um 14:34 schrieb Rob Herring:
Quoted 4 lines · Andreas F?rber
Quoted 2 lines
One limitation is currently the lack of an IAP140 clk driver. Patch 4/4 works around that for UART0 with a fixed-clock.
Quoted 6 lines
Quoted 2 lines
The PXA1928 clock driver should be close to what you need. They are supposed to be very similar.
Where do you see that in mainline? Not in
drivers/clk/pxa/at least. I'm certain the acorn-marvell tree has a PXA1908 clk driver somewhere, too, I just haven't ported it yet.
drivers/clk/mmp/clk-of-pxa1928.c
I ported/rewrote that from Marvell's 3.10 vendor tree.
Quoted 11 lines
Quoted 9 lines
Quoted 4 lines
Andreas F?rber (8):
Documentation: arm: Marvell: Document IAP140
tty: serial: Suppress deprecatedSERIAL_PXAon arm64
tty: serial: 8250_pxa: Implement mmp earlyconYou should not use the pxa serial driver. AFAICT, it was separate to add DMA support, but now the base 8250 driver supports DMA. The base 8250 driver works with the PXA1928 and should also work with the PXA1908.
Do you personally have one? I didn't spot a pxa1928 DT in mainline.
Yes. It never got released and got abandoned. I got several drivers cleaned up to support it and the clock code in before that happened. I had a in-progress DRM driver too. I was debugging why some monitors worked and others didn't when I stopped working on it. I think the board you are working on has the same ADV7533?
It's all up on my Linaro tree:
https://git.linaro.org/people/rob.herring/linux.git
Quoted 2 lines
So, by my reading both
8250_of.cand8250_pxa.clist "mrvl,mmp-uart" for the platform driver. Is that really intentional?
Humm, well I added support in commit 6ad991b699b4e to of_serial.c and then it looks like it got copied to 8250_pxa.c recently. Not sure if that really made sense or not. We should remove one of them. 8250_pxa.c looks fairly pointless to me. Turning a clock on/off in resume/suspend is already supported by 8250_of.c (which doesn't have the bug of turning off the console's clock in suspend). The only other thing is the errata in serial_pxa_dl_write.
Quoted 4 lines
What the
early_pxaearlycon does is set the register shift and then reuse the 8250 core - that looks perfectly valid to me. Are you possibly mixing that up with the non-8250 pxa serial driver that I am already suppressing one patch earlier?
The earlycon core already sets up reg-shift for you.
I added earlycon support in commit a4c639b04f301d. I used "ns16650a" as a fallback compatible string, so there's not an explicit PXA/MMP compatible string there.
Quoted 2 lines
While at it, are you aware that we have two drivers, one pxa and one mmp, that bind to "marvell,pdma-1.0"? That seemed wrong to me, too.
Yeah, it was drivers/tty/serial/pxa.c that I was thinking of. I was incorrectly thinking 8250_pxa.c was that one.
Rob