mm: do not access page->mapping directly on page_endio
Subsystems (3)
PATCH 1/1 mm: do not access page->mapping directly on page_endio
With rw_page, page_endio is used for completing IO on a page and it propagates write error to the address space if the IO fails. The problem is it accesses page->mapping directly which might be okay for file-backed pages but it shouldn't for anonymous page. Otherwise, it can corrupt one of field from anon_vma under us and system goes panic randomly.
--- mm/filemap.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
mm/filemap.c +5 -2
@@ -1008,9 +1008,12 @@ void page_endio(struct page *page, bool is_write, int err)unlock_page (page); }else {if (err) { +struct address_space *mapping; +SetPageError (page); -if (page->mapping) -mapping_set_error (page->mapping, err); + mapping =page_mapping (page); +if (mapping) +mapping_set_error (mapping, err); }end_page_writeback (page); }
Signature · 1 line
2.7.4
Quoted 6 lines · Minchan Kim
With
rw_page,page_endiois used for completing IO on a page and it propagates write error to the address space if the IO fails. The problem is it accessespage->mappingdirectly which might be okay for file-backed pages but it shouldn't for anonymous page. Otherwise, it can corrupt one of field fromanon_vmaunder us and system goes panic randomly.
I was about to say that anonymous pages shouldn't hit that path because the end_swap_bio_write doesn call page_endio. But then I've noticed that zram does call this function. On a closer look, though, it doesn't seem to call it with err != 0 so it cannot hit this path. So I am wondering whether this actually fixes anything. Why it has been marked for stable?
Quoted 29 lines
Cc Matthew Wilcox <[email protected]>Cc <[email protected]>Signed-off-by Minchan Kim <[email protected]>--- mm/filemap.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)mm/filemap.c +5
-2@@ -1008,9 +1008,12 @@ void page_endio(struct page *page, bool is_write, int err)unlock_page (page); }else {if (err) { +struct address_space *mapping; +SetPageError (page); -if (page->mapping) -mapping_set_error (page->mapping, err); + mapping =page_mapping (page); +if (mapping) +mapping_set_error (mapping, err); }end_page_writeback (page); }Signature · 1 line
2.7.4
Signature · 2 lines
Michal Hocko SUSE Labs
Quoted 10 lines · Michal Hocko
Quoted 6 lines · Minchan Kim
With
rw_page,page_endiois used for completing IO on a page and it propagates write error to the address space if the IO fails. The problem is it accessespage->mappingdirectly which might be okay for file-backed pages but it shouldn't for anonymous page. Otherwise, it can corrupt one of field fromanon_vmaunder us and system goes panic randomly.I was about to say that anonymous pages shouldn't hit that path because the
end_swap_bio_writedoesn callpage_endio. But then I've noticed that
No. For driver to support rw_page, every swap_writepage calls rw_page.
swap_writepage
bdev_writepage
ops->rw_page
Quoted 3 lines
zram does call this function. On a closer look, though, it doesn't seem to call it with err != 0 so it cannot hit this path. So I am wondering whether this actually fixes anything. Why it has been marked for stable?
Look at other drivers to support rw_page, not zram, esp, brd. They can be used for swap device and then can hit the case.
In fact, I encountered the BUG during zram development(i.e., it doesn't land to upstream) and it was really hard to figure it out because it made random crash, sometime mmap_sem lockdep, sometime other places where places never related to zram/zsmalloc, sometime not reproducible.
When I consider how that bug is subtle and people do fast-swap test as brd, it's worth to add stable mark, I think.
Quoted 9 lines · Minchan Kim
Quoted 8 lines · Michal Hocko
Quoted 6 lines · Minchan Kim
With
rw_page,page_endiois used for completing IO on a page and it propagates write error to the address space if the IO fails. The problem is it accessespage->mappingdirectly which might be okay for file-backed pages but it shouldn't for anonymous page. Otherwise, it can corrupt one of field fromanon_vmaunder us and system goes panic randomly.
Quoted 8 lines
Quoted 2 lines
I was about to say that anonymous pages shouldn't hit that path because the
end_swap_bio_writedoesn callpage_endio. But then I've noticed thatNo. For driver to support
rw_page, everyswap_writepagecallsrw_page.
swap_writepage
bdev_writepageops->rw_page
Ohh, you are right, I have missed this option. I was looking at the normal swapout path which uses bio.
Quoted 7 lines
Quoted 3 lines
zram does call this function. On a closer look, though, it doesn't seem to call it with err != 0 so it cannot hit this path. So I am wondering whether this actually fixes anything. Why it has been marked for stable?
Look at other drivers to support
rw_page, not zram, esp, brd. They can be used for swap device and then can hit the case.
Quoted 7 lines
In fact, I encountered the BUG during zram
development(i.e., it doesn't land to upstream)and it was really hard to figure it out because it made random crash, sometimemmap_semlockdep, sometime other places where places never related to zram/zsmalloc, sometime not reproducible.When I consider how that bug is subtle and people do fast-swap test as brd, it's worth to add stable mark, I think.
Sure, could you add this to the changelog. Along with Fixes tag? I suspect it is dd6bd0d9c7db ("swap: use bdev_read_page() / bdev_write_page()") which has introduced this but I didn't look too close. The patch is trivially correct.
Signature · 2 lines
Michal Hocko SUSE Labs
Quoted 34 lines · Michal Hocko
Quoted 9 lines · Minchan Kim
Quoted 8 lines · Michal Hocko
Quoted 6 lines · Minchan Kim
With
rw_page,page_endiois used for completing IO on a page and it propagates write error to the address space if the IO fails. The problem is it accessespage->mappingdirectly which might be okay for file-backed pages but it shouldn't for anonymous page. Otherwise, it can corrupt one of field fromanon_vmaunder us and system goes panic randomly.Quoted 8 lines
Quoted 2 lines
I was about to say that anonymous pages shouldn't hit that path because the
end_swap_bio_writedoesn callpage_endio. But then I've noticed thatNo. For driver to support
rw_page, everyswap_writepagecallsrw_page.
swap_writepage
bdev_writepageops->rw_pageOhh, you are right, I have missed this option. I was looking at the normal swapout path which uses bio.
Quoted 12 lines
Quoted 3 lines
zram does call this function. On a closer look, though, it doesn't seem to call it with err != 0 so it cannot hit this path. So I am wondering whether this actually fixes anything. Why it has been marked for stable?
Look at other drivers to support
rw_page, not zram, esp, brd. They can be used for swap device and then can hit the case.In fact, I encountered the BUG during zram
development(i.e., it doesn't land to upstream)and it was really hard to figure it out because it made random crash, sometimemmap_semlockdep, sometime other places where places never related to zram/zsmalloc, sometime not reproducible.
Quoted 7 lines
Quoted 2 lines
When I consider how that bug is subtle and people do fast-swap test as brd, it's worth to add stable mark, I think.
Sure, could you add this to the changelog. Along with Fixes tag? I suspect it is
dd6bd0d9c7db("swap: usebdev_read_page()/bdev_write_page()") which has introduced this but I didn't look too close. The patch is trivially correct.
Sure. Thanks for the review.
Andrew, Could you change description with this?
Quoted 1 line
From
9efb87a873db67a9e6ebf44fdabf7d05fe4b4e21Mon Sep 17 00:00:00 2001
From: Minchan Kim <[email protected]>
Date: Fri, 4 Nov 2016 09:12:39 +0900
Subject: [PATCH v2] mm: do not access page->mapping directly on page_endio
With rw_page, page_endio is used for completing IO on a page and it propagates write error to the address space if the IO fails. The problem is it accesses page->mapping directly which might be okay for file-backed pages but it shouldn't for anonymous page. Otherwise, it can corrupt one of field from anon_vma under us and system goes panic randomly.
swap_writepage
bdev_writepage
ops->rw_page
I encountered the BUG during developing new zram feature and it was really hard to figure it out because it made random crash, somtime mmap_sem lockdep, sometime other places where places never related to zram/zsmalloc, and not reproducible with some configuration.
When I consider how that bug is subtle and people do fast-swap test with brd, it's worth to add stable mark, I think.
---
* from v1
* add more detailed description with Fix tag - Michal
mm/filemap.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
mm/filemap.c +5 -2
@@ -1008,9 +1008,12 @@ void page_endio(struct page *page, bool is_write, int err)unlock_page (page); }else {if (err) { +struct address_space *mapping; +SetPageError (page); -if (page->mapping) -mapping_set_error (page->mapping, err); + mapping =page_mapping (page); +if (mapping) +mapping_set_error (mapping, err); }end_page_writeback (page); }
Signature · 1 line
2.7.4
Michal Hocko
Acked-byOn Fri 24-02-17 08:26:09, Minchan Kim wrote:
[...]
Quoted 22 lines
Quoted 1 line
From
9efb87a873db67a9e6ebf44fdabf7d05fe4b4e21Mon Sep 17 00:00:00 2001From: Minchan Kim <[email protected]>
Date: Fri, 4 Nov 2016 09:12:39 +0900
Subject: [PATCH v2] mm: do not accesspage->mappingdirectly onpage_endioWith
rw_page,page_endiois used for completing IO on a page and it propagates write error to the address space if the IO fails. The problem is it accessespage->mappingdirectly which might be okay for file-backed pages but it shouldn't for anonymous page. Otherwise, it can corrupt one of field fromanon_vmaunder us and system goes panic randomly.
swap_writepage
bdev_writepageops->rw_pageI encountered the BUG during developing new zram feature and it was really hard to figure it out because it made random crash, somtime
mmap_semlockdep, sometime other places where places never related to zram/zsmalloc, and not reproducible with some configuration.
Quoted 8 lines
When I consider how that bug is subtle and people do fast-swap test with brd, it's worth to add stable mark, I think.
Fixes dd6bd0d9c7db ("swap: use bdev_read_page() / bdev_write_page()")Cc Michal Hocko <[email protected]>Cc Matthew Wilcox <[email protected]>Cc <[email protected]>Signed-off-by Minchan Kim <[email protected]>
Thanks for the chagelog update
Quoted 28 lines
---
* from v1
* add more detailed description with Fix tag - Michalmm/filemap.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)mm/filemap.c +5
-2@@ -1008,9 +1008,12 @@ void page_endio(struct page *page, bool is_write, int err)unlock_page (page); }else {if (err) { +struct address_space *mapping; +SetPageError (page); -if (page->mapping) -mapping_set_error (page->mapping, err); + mapping =page_mapping (page); +if (mapping) +mapping_set_error (mapping, err); }end_page_writeback (page); }Signature · 1 line
2.7.4
Signature · 2 lines
Michal Hocko SUSE Labs