ARM64: Initial Realtek RTD1295 enablement
Subsystems (4)
v2 cover ARM64: Initial Realtek RTD1295 enablement
Hello,
This mini-series adds initial support for the Realtek RTD1295 SoC and the Zidoo X9S TV box.
v2 does minor cleanups only.
With these patches CPU0 can be booted with earlycon.
PSCI doesn't work despite present in the vendor device tree; as enable-method it instead used a custom "rtk-spin-table" that I sadly have no source code of.
The UARTs use a custom interrupt controller that I again lack source code of; with interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH> it can boot into an initrd.
The boot process is slightly twisted: The files need to be loaded from a 32-bit U-Boot, then boot into 64-bit U-Boot where the kernel can be booted. Similar to my previous Amlogic S905 work, the TEXT_OFFSET poses a problem, so a uImage needs to be used (or the kernel patched) for load address 0x00280000. I haven't succeeded loading an initrd via bootm/booti; but as quick workaround initrd=$rootfs_loadaddr,0x$filesize can manually be specified in $bootargs.
Cf. https://en.opensuse.org/HCL:Zidoo_X9S
KVM appears to initialize okay, but was not yet tested with QEMU.
[ 0.256947] kvm [1]: 8-bit VMID [ 0.256986] kvm [1]: IDMAP page: 73b000 [ 0.257025] kvm [1]: HYP VA range: 800000000000:ffffffffffff [ 0.257458] kvm [1]: Hyp mode initialized successfully [ 0.257529] kvm [1]: virtual timer IRQ3
More experimental patches at:
https://github.com/afaerber/linux/commits/rtd1295-next
Have a lot of fun!
Cheers,
Andreas
v1 -> v2:
* Add Acked-bys
* Tweak DT subjects
* Reword DT bindings
* Drop one memreserve
* Add MAINTAINERS patch
Andreas F?rber (5):
dt-bindings: Add vendor prefix for Zidoo
dt-bindings: arm: Add Realtek RTD1295 bindings
ARM64: Prepare Realtek RTD1295
ARM64: dts: Prepare Realtek RTD1295 and Zidoo X9S
MAINTAINERS: Add Realtek section
Documentation/devicetree/bindings/arm/realtek.txt | 20 +++ .../devicetree/bindings/vendor-prefixes.txt | 1 + MAINTAINERS | 7 + arch/arm64/Kconfig.platforms | 6 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/realtek/Makefile | 5 + arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts | 78 ++++++++++ arch/arm64/boot/dts/realtek/rtd1295.dtsi | 162 +++++++++++++++++++++ 8 files changed, 280 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/realtek.txt create mode 100644 arch/arm64/boot/dts/realtek/Makefile create mode 100644 arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts create mode 100644 arch/arm64/boot/dts/realtek/rtd1295.dtsi
Signature · 1 line
2.10.2
PATCH v2 1/5 dt-bindings: Add vendor prefix for Zidoo
Zidoo is a Chinese manufacturer of TV boxes.
---
v1 -> v2:
* Changed subject
* Extended commit message
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
@@ -343,6 +343,7 @@ xlnx Xilinx xunlong Shenzhen Xunlong Software CO.,Limited zarlink Zarlink Semiconductor zeitec ZEITEC Semiconductor Co., LTD. +zidoo Shenzhen Zidoo Technology Co., Ltd. zii Zodiac Inflight Innovations zte ZTE Corp. zyxel ZyXEL Communications Corp.
Signature · 1 line
2.10.2
PATCH v2 2/5 dt-bindings: arm: Add Realtek RTD1295 bindings
In reply to Andreas FärberThe Zidoo X9S and a few other recent TV boxes feature the Realtek RTD1295, a quad-core ARM Cortex-A53 SoC.
---
v1 -> v2:
* Changed subject
* Extended commit message
* Clarified wording
Documentation/devicetree/bindings/arm/realtek.txt | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/realtek.txt
Documentation/devicetree/bindings/arm/realtek.txt new file +20 -0
@@ -0,0 +1,20 @@ +Realtek platforms device tree bindings +-------------------------------------- + + +RTD1295 SoC +=========== + +Required root node properties: + + - compatible : must contain "realtek,rtd1295" + + +Root node property compatible must contain, depending on board: + + - Zidoo X9S: "zidoo,x9s" + + +Example: + + compatible = "zidoo,x9s", "realtek,rtd1295";
Signature · 1 line
2.10.2
Re: [PATCH v2 2/5] dt-bindings: arm: Add Realtek RTD1295 bindings
Quoted 12 lines · Andreas F?rber
The Zidoo X9S and a few other recent TV boxes feature the Realtek RTD1295, a quad-core ARM Cortex-A53 SoC.
Acked-by Arnd Bergmann <[email protected]>Acked-by Roc He <[email protected]>Signed-off-by Andreas F?rber <[email protected]>---
v1 -> v2:
* Changed subject
* Extended commit message
* Clarified wording
Quoted 3 lines
Documentation/devicetree/bindings/arm/realtek.txt | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/realtek.txt
PATCH v2 3/5 ARM64: Prepare Realtek RTD1295
In reply to Andreas FärberAdd a Kconfig option ARCH_REALTEK.
---
v1 -> v2: unchanged
arch/arm64/Kconfig.platforms | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm64/Kconfig.platforms +6 -0
@@ -118,6 +118,12 @@ config ARCH_QCOM help This enables support for the ARMv8 based Qualcomm chipsets. +config ARCH_REALTEK + bool "Realtek Platforms" + help + This enables support for the ARMv8 based Realtek chipsets, + like the RTD1295. + config ARCH_ROCKCHIP bool "Rockchip Platforms" select ARCH_HAS_RESET_CONTROLLER
Signature · 1 line
2.10.2
PATCH v2 4/5 ARM64: dts: Prepare Realtek RTD1295 and Zidoo X9S
In reply to Andreas FärberAdd initial device trees for the RTD1295 SoC and the Zidoo X9S TV box.
The CPUs lack the enable-method property because the vendor device tree uses a custom "rtk-spin-table" method and "psci" did not appear to work.
The UARTs lack the interrupts properties because the vendor device tree connects them to a custom interrupt controller. earlycon works without.
A list of memory reservations is adopted from v1.2.11 vendor device tree:0x02200000 can be used for an initrd, 0x01b00000 is audio-related; ion-related 0x02600000, 0x02c00000 and 0x11000000 are left out; 0x10000000 is used for sharing the U-Boot environment; others remain to be investigated.
---
v1 -> v2:
* Dropped 0x0000000010000000 /memreserve/
arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/realtek/Makefile | 5 + arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts | 78 +++++++++++ arch/arm64/boot/dts/realtek/rtd1295.dtsi | 162 ++++++++++++++++++++++ 4 files changed, 246 insertions(+) create mode 100644 arch/arm64/boot/dts/realtek/Makefile create mode 100644 arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts create mode 100644 arch/arm64/boot/dts/realtek/rtd1295.dtsi
arch/arm64/boot/dts/Makefile +1 -0
@@ -14,6 +14,7 @@ dts-dirs += marvell dts-dirs += mediatek dts-dirs += nvidia dts-dirs += qcom +dts-dirs += realtek dts-dirs += renesas dts-dirs += rockchip dts-dirs += socionext
arch/arm64/boot/dts/realtek/Makefile new file +5 -0
@@ -0,0 +1,5 @@ +dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-zidoo-x9s.dtb + +always := $(dtb-y) +subdir-y := $(dts-dirs) +clean-files := *.dtb
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +78 -0
78 lines not on this page · raw message
arch/arm64/boot/dts/realtek/rtd1295.dtsi new file +162 -0
162 lines not on this page · raw message
Signature · 1 line
2.10.2
Rob Herring
maintainerRe: [PATCH v2 4/5] ARM64: dts: Prepare Realtek RTD1295 and Zidoo X9S
Quoted 58 lines · Andreas F?rber
Add initial device trees for the RTD1295 SoC and the Zidoo X9S TV box.
The CPUs lack the enable-method property because the vendor device tree uses a custom "rtk-spin-table" method and "psci" did not appear to work.
The UARTs lack the interrupts properties because the vendor device tree connects them to a custom interrupt controller. earlycon works without.
A list of memory reservations is adopted from v1.2.11 vendor device tree:
0x02200000can be used for an initrd,0x01b00000is audio-related; ion-related0x02600000,0x02c00000and0x11000000are left out;0x10000000is used for sharing the U-Boot environment; others remain to be investigated.Acked-by Arnd Bergmann <[email protected]>Signed-off-by Andreas F?rber <[email protected]>---
v1 -> v2:
* Dropped0x0000000010000000/memreserve/arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/realtek/Makefile | 5 + arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts | 78 +++++++++++ arch/arm64/boot/dts/realtek/rtd1295.dtsi | 162 ++++++++++++++++++++++ 4 files changed, 246 insertions(+) create mode 100644 arch/arm64/boot/dts/realtek/Makefile create mode 100644 arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts create mode 100644 arch/arm64/boot/dts/realtek/rtd1295.dtsiarch/arm64/boot/dts/Makefile +1
-0@@ -14,6 +14,7 @@ dts-dirs += marvell dts-dirs += mediatek dts-dirs += nvidia dts-dirs += qcom +dts-dirs += realtek dts-dirs += renesas dts-dirs += rockchip dts-dirs += socionextarch/arm64/boot/dts/realtek/Makefile new file +5
-0@@ -0,0 +1,5 @@ +dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-zidoo-x9s.dtb + +always := $(dtb-y) +subdir-y := $(dts-dirs) +clean-files := *.dtbarch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +0
-0
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts line 7
Quoted 7 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +7
-0@@ -0,0 +1,78 @@ +/* + * Copyright (c) 2016-2017 Andreas F?rber + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole.
You can use SPDX tag here instead.
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts line 10
Quoted 3 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +3
-0+ reserved-memory { + #address-cells = <2>; + #size-cells = <2>;
Unless you have >4GB regions, you don't really need 2 cells here.
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts
Quoted 13 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +11
-0+ ranges; + + tee at 10100000 { + reg = <0x0 0x10100000 0x0 0xf00000>; + no-map; + }; + }; + soc { + compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>;
Same here. And use ranges to narrow the address space to what you need.
Quoted 26 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +26
-0+ ranges; + + uart0: serial at 98007800 { + compatible = "snps,dw-apb-uart"; + reg = <0x0 0x98007800 0x0 0x400>, + <0x0 0x98007000 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clock-frequency = <27000000>; + status = "disabled"; + }; + + uart1: serial at 9801b200 { + compatible = "snps,dw-apb-uart"; + reg = <0x0 0x9801b200 0x0 0x100>, + <0x0 0x9801b00c 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clock-frequency = <432000000>; + status = "disabled"; + }; + + uart2: serial at 9801b400 { + compatible = "snps,dw-apb-uart"; + reg = <0x0 0x9801b400 0x0 0x100>, + <0x0 0x9801b00c 0x0 0x100>;
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts
Quoted 10 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +10
-0+ reg-shift = <2>; + reg-io-width = <4>; + clock-frequency = <432000000>; + status = "disabled"; + }; + + gic: interrupt-controller at ff011000 { + compatible = "arm,gic-400"; + reg = <0x0 0xff011000 0x0 0x1000>, + <0x0 0xff012000 0x0 0x1000>;
You are missing some register ranges and the sizes may be wrong. Check the binding doc.
Quoted 8 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +5
-0+ interrupt-controller; + #interrupt-cells = <3>; + }; + }; +};Signature · 1 line
2.10.2
Re: [PATCH v2 4/5] ARM64: dts: Prepare Realtek RTD1295 and Zidoo X9S
Am 28.02.2017 um 01:03 schrieb Rob Herring:
Quoted 60 lines · Andreas F?rber
Quoted 59 lines
Add initial device trees for the RTD1295 SoC and the Zidoo X9S TV box.
The CPUs lack the enable-method property because the vendor device tree uses a custom "rtk-spin-table" method and "psci" did not appear to work.
The UARTs lack the interrupts properties because the vendor device tree connects them to a custom interrupt controller. earlycon works without.
A list of memory reservations is adopted from v1.2.11 vendor device tree:
0x02200000can be used for an initrd,0x01b00000is audio-related; ion-related0x02600000,0x02c00000and0x11000000are left out;0x10000000is used for sharing the U-Boot environment; others remain to be investigated.Acked-by Arnd Bergmann <[email protected]>Signed-off-by Andreas F?rber <[email protected]>---
v1 -> v2:
* Dropped0x0000000010000000/memreserve/arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/realtek/Makefile | 5 + arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts | 78 +++++++++++ arch/arm64/boot/dts/realtek/rtd1295.dtsi | 162 ++++++++++++++++++++++ 4 files changed, 246 insertions(+) create mode 100644 arch/arm64/boot/dts/realtek/Makefile create mode 100644 arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts create mode 100644 arch/arm64/boot/dts/realtek/rtd1295.dtsiarch/arm64/boot/dts/Makefile +1
-0@@ -14,6 +14,7 @@ dts-dirs += marvell dts-dirs += mediatek dts-dirs += nvidia dts-dirs += qcom +dts-dirs += realtek dts-dirs += renesas dts-dirs += rockchip dts-dirs += socionextarch/arm64/boot/dts/realtek/Makefile new file +5
-0@@ -0,0 +1,5 @@ +dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-zidoo-x9s.dtb + +always := $(dtb-y) +subdir-y := $(dts-dirs) +clean-files := *.dtbarch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +1
-0@@ -0,0 +1,78 @@ +/*
Quoted 8 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts line 7
Quoted 6 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +6
-0+ * Copyright (c) 2016-2017 Andreas F?rber + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole.You can use SPDX tag here instead.
Already done. :)
Quoted 5 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts line 10
Quoted 3 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +3
-0+ reserved-memory { + #address-cells = <2>; + #size-cells = <2>;Unless you have >4GB regions, you don't really need 2 cells here.
Correct, but using less cells than in the root node requires a ranges mapping, and we don't have size information available for that. So I would rather leave it like this initially.
Quoted 9 lines
Quoted 7 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +7
-0+ ranges; + + tee at 10100000 { + reg = <0x0 0x10100000 0x0 0xf00000>; + no-map; + }; + };
Quoted 6 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts line 21
Quoted 4 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +4
-0+ soc { + compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>;Same here. And use ranges to narrow the address space to what you need.
By my definition, SoC is the whole memory range.
And as pointed out in the v1 cover letter, I don't have sufficient documentation for this chip - there's not even a general address map in the datasheet, nor any bus information - so any attempt to restrict it would be a wild guess and specific to the 2G .dts rather than suitable for the generic .dtsi here.
If we had the info, I would still want to leave the soc node like this and instead have bus sub-nodes with suitable ranges, like we did for meson-gxbb. I don't see harm in having the .dts be a few cells larger.
Quoted 31 lines
Quoted 31 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +31
-0+ ranges; + + uart0: serial at 98007800 { + compatible = "snps,dw-apb-uart"; + reg = <0x0 0x98007800 0x0 0x400>, + <0x0 0x98007000 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clock-frequency = <27000000>; + status = "disabled"; + }; + + uart1: serial at 9801b200 { + compatible = "snps,dw-apb-uart"; + reg = <0x0 0x9801b200 0x0 0x100>, + <0x0 0x9801b00c 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clock-frequency = <432000000>; + status = "disabled"; + }; + + uart2: serial at 9801b400 { + compatible = "snps,dw-apb-uart"; + reg = <0x0 0x9801b400 0x0 0x100>, + <0x0 0x9801b00c 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clock-frequency = <432000000>; + status = "disabled"; + };
Quoted 8 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts line 57
Quoted 5 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +5
-0+ + gic: interrupt-controller at ff011000 { + compatible = "arm,gic-400"; + reg = <0x0 0xff011000 0x0 0x1000>, + <0x0 0xff012000 0x0 0x1000>;You are missing some register ranges and the sizes may be wrong. Check the binding doc.
I have in the meantime tested that 1k, 2k, 2k, 2k plus PPI 9 lets KVM initialize the vGIC:
[ 0.256915] kvm [1]: 8-bit VMID [ 0.256951] kvm [1]: IDMAP page: 73f000 [ 0.256986] kvm [1]: HYP VA range: 800000000000:ffffffffffff [ 0.257417] kvm [1]: Hyp mode initialized successfully [ 0.257479] kvm [1]: vgic-v2 at ff014000 [ 0.257554] kvm [1]: vgic interrupt IRQ1 [ 0.257600] kvm [1]: virtual timer IRQ4
As usual, not yet tested with a guest for lack of proper rootfs.
Mark, is there any benefit in using a raw 0xf mask over a simple 4, when there are only 4 CPUs? I tested the simple 4 copied from my S900, whereas the timer based on the vendor device tree uses raw 0xf, i.e., simple 8. Should I change that to be consistently simple 4?
Quoted 5 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts line 62
Quoted 5 lines
arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts new file +5
-0+ interrupt-controller; + #interrupt-cells = <3>; + }; + }; +};
Additionally I am dropping the irq.h include, because arm-gic.h already does that for us.
Regards,
Andreas
Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg)
PATCH v2 5/5 MAINTAINERS: Add Realtek section
In reply to Andreas FärberAdd myself as maintainer.
---
v2: new
MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+)
MAINTAINERS +7 -0
@@ -1647,6 +1647,13 @@ M: Lennert Buytenhek <[email protected]> L: linux-arm-kernel at lists.infradead.org (moderated for non-subscribers) S: Maintained +ARM/REALTEK ARCHITECTURE +M: Andreas F?rber <[email protected]> +L: linux-arm-kernel at lists.infradead.org (moderated for non-subscribers) +S: Supported +F: arch/arm64/boot/dts/realtek/ +F: Documentation/devicetree/bindings/arm/realtek.txt + ARM/RENESAS ARM64 ARCHITECTURE M: Simon Horman <[email protected]> M: Magnus Damm <[email protected]>
Signature · 1 line
2.10.2