Skip to contentSkip to conversation

phy: phy-exynos-pcie: make it explicitly non-modular

PATCH New Paul Gortmaker 1 participant 1 message Feb 23, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: phy-exynos-pcie: make it explicitly non-modular

The Kconfig currently controlling compilation of this code is:

drivers/phy/Kconfig:config PHY_EXYNOS_PCIE
drivers/phy/Kconfig: bool "Exynos PCIe PHY driver"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modular infrastructure use, so that when reading the driver there is no doubt it is builtin-only.

Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments.

Cc Jaehoon Chung <[email protected]>
Cc Jingoo Han <[email protected]>
Cc Kishon Vijay Abraham I <[email protected]>
Cc Kukjin Kim <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Pankaj Dubey <[email protected]>
Cc Vivek Gautam <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Bjorn Helgaas <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc linux-samsung-soc at vger.kernel.org

---

[ I'd normally not send patches in the merge window, but this driver
just appeared in linux-next and so I'm assuming it is intended for addition during this merge window, hence we might as well fix it now.]

 drivers/phy/phy-exynos-pcie.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/phy/phy-exynos-pcie.c +2 -7
index 4f60b83641d5..d92d8616a106 100644
@@ -14,8 +14,8 @@
 #include <linux/delay.h>
 #include <linux/io.h>
 #include <linux/iopoll.h>
+#include <linux/init.h>
 #include <linux/mfd/syscon.h>
-#include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_platform.h>
@@ -228,7 +228,6 @@ static const struct of_device_id exynos_pcie_phy_match[] = {
 	},
 	{},
 };
-MODULE_DEVICE_TABLE(of, exynos_pcie_phy_match);
 
 static int exynos_pcie_phy_probe(struct platform_device *pdev)
 {
@@ -278,8 +277,4 @@ static struct platform_driver exynos_pcie_phy_driver = {
 		.name		= "exynos_pcie_phy",
 	}
 };
-module_platform_driver(exynos_pcie_phy_driver);
-
-MODULE_DESCRIPTION("Samsung S5P/EXYNOS SoC PCIe PHY driver");
-MODULE_AUTHOR("Jaehoon Chung <[email protected]>");
-MODULE_LICENSE("GPL v2");
+builtin_platform_driver(exynos_pcie_phy_driver);
Signature · 1 line
2.11.0