net: phy: Add missing driver check in phy_aneg_done()
Subsystems (3)
PATCH 1/1 net: phy: Add missing driver check in phy_aneg_done()
Dan's static checker caught a potential code path in phy_state_machine() where we were not checking phydev->drv which is in phy_aneg_done().
Reported-by Dan Carpenter <[email protected]>
Fixes 25149ef9d25c ("net: phy: Check phydev->drv")
Signed-off-by Florian Fainelli <[email protected]>
--- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/phy.c +1 -1
@@ -146,7 +146,7 @@ static int phy_config_interrupt(struct phy_device *phydev, u32 interrupts)*/ int phy_aneg_done (struct phy_device *phydev) { -if (phydev->drv->aneg_done) +if (phydev->drv && phydev->drv->aneg_done)return phydev->drv->aneg_done (phydev);return genphy_aneg_done (phydev);
Signature · 1 line
2.9.3
From: Florian Fainelli <[email protected]>
Date: Thu, 23 Feb 2017 14:22:19 -0800
Quoted 6 lines
Dan's static checker caught a potential code path in
phy_state_machine()where we were not checkingphydev->drvwhich is inphy_aneg_done().Reported-by Dan Carpenter <[email protected]>Fixes 25149ef9d25c ("net: phy: Check phydev->drv")Signed-off-by Florian Fainelli <[email protected]>
Applied.