Skip to contentSkip to conversation

s390/topology: correct allocation of topology information

PATCH New Martin Schwidefsky 1 participant 1 message Feb 24, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390/topology: correct allocation of topology information

commit 8676caa4fb7fc02b2c76842a0024919d0caa4b8d upstream.

Relevant for 4.10 only.

The data stored by the STSI instruction can be up to a page in size but the memblock_virt_alloc allocation for tl_info only specifies 16 bytes. The memory after the short allocation is overwritten every time arch_update_cpu_topology is called.

Fixes 8c9105802235 "s390/numa: establish cpu to node mapping early"
---
 arch/s390/kernel/topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kernel/topology.c +1 -1
index 7b2b19b..2cd5f4f 100644
@@ -458,7 +458,7 @@ void __init topology_init_early(void)
 	set_sched_topology(s390_topology);
 	if (!MACHINE_HAS_TOPOLOGY)
 		goto out;
-	tl_info = memblock_virt_alloc(sizeof(*tl_info), PAGE_SIZE);
+	tl_info = memblock_virt_alloc(PAGE_SIZE, PAGE_SIZE);
 	info = tl_info;
 	store_topology(info);
 	pr_info("The CPU configuration topology of the machine is: %d %d %d %d %d %d / %d\n",
Signature · 1 line
2.8.4