Skip to contentSkip to conversation

staging: ks7010: Block comments use * on subsequent lines

PATCH In review Arushi Singhal 2 participants 2 messages Feb 18, 2017 – Feb 24, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: ks7010: Block comments use * on subsequent lines

Some of the block comments styles are not encouraged:
for example:
/*
block comment without introductory *
*/
and
/*
* block comment with line terminating */

---
 drivers/staging/ks7010/ks7010_sdio.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks7010_sdio.c +4 -2
index a604c83c957e..2c263f98bdbb 100644
@@ -495,8 +495,10 @@ static void ks7010_rw_function(struct work_struct *work)
 	/* wiat after WAKEUP */
 	while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
 		DPRINTK(4, "wait after WAKEUP\n");
-/*		queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
-		(priv->last_wakeup + ((30*HZ)/1000) - jiffies));*/
+/* 
+ *   queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
+ *   (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
+ */
 		dev_info(&priv->ks_wlan_hw.sdio_card->func->dev,
 			 "wake: %lu %lu\n",
 			 priv->last_wakeup + (30 * HZ) / 1000,
Signature · 1 line
2.11.0
maintainer
#1 lore raw
Quoted 19 lines · Arushi Singhal

Some of the block comments styles are not encouraged:
for example:
/*
block comment without introductory *
*/
and
/*
* block comment with line terminating */

---
 drivers/staging/ks7010/ks7010_sdio.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks7010_sdio.c +0 -0
index a604c83c957e..2c263f98bdbb 100644

drivers/staging/ks7010/ks7010_sdio.c static void ks7010_rw_function(struct work_struct *work) · line 501

Quoted 9 lines
drivers/staging/ks7010/ks7010_sdio.c +4 -2
@@ -495,8 +495,10 @@ static void ks7010_rw_function(struct work_struct *work)
 	/* wiat after WAKEUP */
 	while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
 		DPRINTK(4, "wait after WAKEUP\n");
-/*		queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
-		(priv->last_wakeup + ((30*HZ)/1000) - jiffies));*/
+/* 
+ *   queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
+ *   (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
+ */

Why did you loose the correct indentation here when you commented this out?

If it's commented out, why not just delete the code instead?

thanks,

greg k-h