staging: iio: Single source header file reorganization
Subsystems (3)
PATCH 1/1 staging: iio: Single source header file reorganization
The contents of the header file are used only by this single source file. Move content into .c and remove .h.
Signed-off-by Sreya Mittal <[email protected]>
--- drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 33 +++++++++++++++++------ drivers/staging/iio/trigger/iio-trig-bfin-timer.h | 24 ----------------- 2 files changed, 25 insertions(+), 32 deletions(-) delete mode 100644 drivers/staging/iio/trigger/iio-trig-bfin-timer.h
drivers/staging/iio/trigger/iio-trig-bfin-timer.c +25 -8
@@ -5,21 +5,38 @@* */ +#include <asm/gptimers.h> +#include <asm/portmux.h> +#include <linux/delay.h> +#include <linux/interrupt.h> +#include <linux/irq.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/slab.h> -#include <linux/interrupt.h> -#include <linux/irq.h> -#include <linux/delay.h> - -#include <asm/gptimers.h> -#include <asm/portmux.h> -#include <linux/iio/iio.h> #include <linux/iio/trigger.h> -#include "iio-trig-bfin-timer.h" +/** +* * struct iio_bfin_timer_trigger_pdata - timer trigger platform data +* * @output_enable: Enable external trigger pulse generation. +* * @active_low: Whether the trigger pulse is active low. +* * @duty_ns: Length of the trigger pulse in nanoseconds. +* * +* * This struct is used to configure the output pulse generation of the blackfin +* * timer trigger. If output_enable is set to true an external trigger signal +* * will generated on the pin corresponding to the timer. This is useful for +* * converters which needs an external signal to start conversion. active_low and +* * duty_ns are used to configure the type of the trigger pulse. If output_enable +* * is set to false no external trigger pulse will be generated and active_low +* * and duty_ns are ignored. +* **/ + +struct iio_bfin_timer_trigger_pdata { +bool output_enable; +bool active_low; +unsigned int duty_ns; +};struct bfin_timer {unsigned short id, bit;
drivers/staging/iio/trigger/iio-trig-bfin-timer.h deleted +0 -24
@@ -1,24 +0,0 @@ -#ifndef __IIO_BFIN_TIMER_TRIGGER_H__ -#define __IIO_BFIN_TIMER_TRIGGER_H__ - -/** -* struct iio_bfin_timer_trigger_pdata - timer trigger platform data -* @output_enable: Enable external trigger pulse generation. -* @active_low: Whether the trigger pulse is active low. -* @duty_ns: Length of the trigger pulse in nanoseconds. -* -* This struct is used to configure the output pulse generation of the blackfin -* timer trigger. If output_enable is set to true an external trigger signal -* will generated on the pin corresponding to the timer. This is useful for -* converters which needs an external signal to start conversion. active_low and -* duty_ns are used to configure the type of the trigger pulse. If output_enable -* is set to false no external trigger pulse will be generated and active_low -* and duty_ns are ignored. -**/ -struct iio_bfin_timer_trigger_pdata { -bool output_enable; -bool active_low; -unsigned int duty_ns; -}; - -#endif
Signature · 1 line
2.9.3
Quoted 4 lines · Sreya Mittal
The contents of the header file are used only by this single source file. Move content into .c and remove .h.
Signed-off-by Sreya Mittal <[email protected]>
Hi,
In general the intend of the patch is correct, but it looks like something went wrong with the indention of the documentation.
[....]
Quoted 15 lines
drivers/staging/iio/trigger/iio-trig-bfin-timer.c +14
-1-#include "iio-trig-bfin-timer.h" +/** +* * struct iio_bfin_timer_trigger_pdata - timer trigger platform data +* * @output_enable: Enable external trigger pulse generation. +* * @active_low: Whether the trigger pulse is active low. +* * @duty_ns: Length of the trigger pulse in nanoseconds. +* * +* * This struct is used to configure the output pulse generation of the blackfin +* * timer trigger. If output_enable is set to true an external trigger signal +* * will generated on the pin corresponding to the timer. This is useful for +* * converters which needs an external signal to start conversion. active_low and +* * duty_ns are used to configure the type of the trigger pulse. If output_enable +* * is set to false no external trigger pulse will be generated and active_low +* * and duty_ns are ignored. +* **/