percpu: acquire pcpu_lock when updating pcpu_nr_empty_pop_pages
Subsystems (2)
PATCH 2/3 percpu: acquire pcpu_lock when updating pcpu_nr_empty_pop_pages
Update to pcpu_nr_empty_pop_pages in pcpu_alloc() is currently done without holding pcpu_lock. This can lead to bad updates to the variable. Add missing lock calls.
Fixes b539b87fed37 ("percpu: implmeent pcpu_nr_empty_pop_pages and chunk->nr_populated")
Signed-off-by Tahsin Erdogan <[email protected]>
--- mm/percpu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
mm/percpu.c +4 -1
@@ -1011,8 +1011,11 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved,mutex_unlock (&pcpu_alloc_mutex); } -if (chunk != pcpu_reserved_chunk) +if (chunk != pcpu_reserved_chunk) { +spin_lock_irqsave (&pcpu_lock, flags); pcpu_nr_empty_pop_pages -= occ_pages; +spin_unlock_irqrestore (&pcpu_lock, flags); + }if (pcpu_nr_empty_pop_pages <PCPU_EMPTY_POP_PAGES_LOW )pcpu_schedule_balance_work ();
Signature · 7 lines
2.11.0.483.g087da7b7c-goog -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 6 lines · Tahsin Erdogan
Update to
pcpu_nr_empty_pop_pagesinpcpu_alloc()is currently done without holdingpcpu_lock. This can lead to bad updates to the variable. Add missing lock calls.Fixes b539b87fed37 ("percpu: implmeent pcpu_nr_empty_pop_pages and chunk->nr_populated")Signed-off-by Tahsin Erdogan <[email protected]>
Applied to percpu/for-4.11-fixes w/ stable cc'd.
Thanks.
Signature · 7 lines
tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>