Skip to contentSkip to conversation

drm: mxsfb: Assure CTRL and CTRL1 values are latched into HW

PATCH New Marek Vasut 1 participant 1 message Feb 26, 2017

Subsystems (4)
lore
Share & tools
lore

Marek Vasut

author maintainer
#0 lore raw

PATCH 1/1 drm: mxsfb: Assure CTRL and CTRL1 values are latched into HW

For reasons unknown, the first write into CTRL and CTRL1 registers is not actually latched into the hardware and the data read back are the reset values. Second write into the same registers has the expected effect though and a readback returns the written values. Add the second write.

Cc Breno Lima <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Dave Airlie <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Stefan Agner <[email protected]>
---
 drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/mxsfb/mxsfb_crtc.c +2 -0
index 6d701d2c362d..f02d23d55995 100644
@@ -84,6 +84,8 @@ static int mxsfb_set_pixel_fmt(struct mxsfb_drm_private *mxsfb)
 
 	writel(ctrl1, mxsfb->base + LCDC_CTRL1);
 	writel(ctrl, mxsfb->base + LCDC_CTRL);
+	writel(ctrl1, mxsfb->base + LCDC_CTRL1);
+	writel(ctrl, mxsfb->base + LCDC_CTRL);
 
 	return 0;
 }
Signature · 6 lines
2.11.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel