Skip to contentSkip to conversation

openrd: disable private arch memset, memcpy and libgcc

PATCH New Albert ARIBAUD 2 participants 2 messages Feb 26, 2017 – Feb 27, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openrd: disable private arch memset, memcpy and libgcc

The switch to private LIBGCC causes 'undefined instruction' exception in at least the Open-RD Ultimate and Client, and quite probably the Open-RD Base as well.

While debugging this issue, it appeared the switch to architecture-optimized memset and memcpy also causes the same exceptions.

Until a fix to private libgcc and architecture-optimized memcpy and memset is mainlined, disable their use in all openrd configurations.

---

 configs/openrd_base_defconfig     | 4 ++++
 configs/openrd_client_defconfig   | 4 ++++
 configs/openrd_ultimate_defconfig | 4 ++++
 3 files changed, 12 insertions(+)
configs/openrd_base_defconfig +4 -0
index 067ddbc5cc..4b8c51a771 100644
@@ -21,3 +21,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_OF_LIBFDT=y
+# Private memcpy, memset and libgcc cause undefined instruction exceptions
+CONFIG_USE_ARCH_MEMSET=n
+CONFIG_USE_ARCH_MEMCPY=n
+CONFIG_USE_PRIVATE_LIBGCC=n
configs/openrd_client_defconfig +4 -0
index b90ead158f..04f243a57b 100644
@@ -21,3 +21,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_OF_LIBFDT=y
+# Private memcpy, memset and libgcc cause undefined instruction exceptions
+CONFIG_USE_ARCH_MEMSET=n
+CONFIG_USE_ARCH_MEMCPY=n
+CONFIG_USE_PRIVATE_LIBGCC=n
configs/openrd_ultimate_defconfig +4 -0
index 2bc8ace8d0..c8d4c3176f 100644
@@ -21,3 +21,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_OF_LIBFDT=y
+# Private memcpy, memset and libgcc cause undefined instruction exceptions
+CONFIG_USE_ARCH_MEMSET=n
+CONFIG_USE_ARCH_MEMCPY=n
+CONFIG_USE_PRIVATE_LIBGCC=n
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 openrd: disable private arch memset, memcpy and libgcc

Quoted 8 lines · Albert ARIBAUD

The switch to private LIBGCC causes 'undefined instruction' exception in at least the Open-RD Ultimate and Client, and quite probably the Open-RD Base as well.

While debugging this issue, it appeared the switch to architecture-optimized memset and memcpy also causes the same exceptions.

Quoted 5 lines

Until a fix to private libgcc and architecture-optimized memcpy and memset is mainlined, disable their use in all openrd configurations.

Implementation wise, there's two big problems here. First, all of the code we're talking about is a direct drop-in from the kernel. So whatever is wrong here is a problem that the kernel itself can trigger, so needs sorting out and fixing. Second, do you have more details on how to recreate (or not recreate) these problems?

Quoted 36 lines

---

 configs/openrd_base_defconfig     | 4 ++++
 configs/openrd_client_defconfig   | 4 ++++
 configs/openrd_ultimate_defconfig | 4 ++++
 3 files changed, 12 insertions(+)
configs/openrd_base_defconfig +4 -0
index 067ddbc5cc..4b8c51a771 100644
@@ -21,3 +21,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_OF_LIBFDT=y
+# Private memcpy, memset and libgcc cause undefined instruction exceptions
+CONFIG_USE_ARCH_MEMSET=n
+CONFIG_USE_ARCH_MEMCPY=n
+CONFIG_USE_PRIVATE_LIBGCC=n
configs/openrd_client_defconfig +4 -0
index b90ead158f..04f243a57b 100644
@@ -21,3 +21,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_OF_LIBFDT=y
+# Private memcpy, memset and libgcc cause undefined instruction exceptions
+CONFIG_USE_ARCH_MEMSET=n
+CONFIG_USE_ARCH_MEMCPY=n
+CONFIG_USE_PRIVATE_LIBGCC=n
configs/openrd_ultimate_defconfig +0 -0
index 2bc8ace8d0..c8d4c3176f 100644

configs/openrd_ultimate_defconfig CONFIG_SYS_NS16550=y · line 27

Quoted 7 lines
configs/openrd_ultimate_defconfig +4 -0
@@ -21,3 +21,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_OF_LIBFDT=y
+# Private memcpy, memset and libgcc cause undefined instruction exceptions
+CONFIG_USE_ARCH_MEMSET=n
+CONFIG_USE_ARCH_MEMCPY=n
+CONFIG_USE_PRIVATE_LIBGCC=n

Content-wise, this is wrong. Please run them past 'savedefconfig'. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170226/d2e3bd6c/attachment.sig>