Skip to contentSkip to conversation

vlc: workaround microblaze gcc internal compiler error

PATCH New Waldemar Brodkorb 2 participants 3 messages Feb 27, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vlc: workaround microblaze gcc internal compiler error

Override gcc optimization flags with -O0.

The workaround is not required for gcc6 anymore, but gcc6 is disabled for microblaze, because it breaks startup of the system somehow. So the bug is not reported upstream.

Fixes:
http://autobuild.buildroot.net/results/a318f0838a6a602046e719103ac81965c0084d52

---
 package/vlc/vlc.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/vlc/vlc.mk +6 -0
index 666b8d4..a523f8f 100644
@@ -15,6 +15,12 @@ VLC_AUTORECONF = YES
 # Install vlc libraries in staging.
 VLC_INSTALL_STAGING = YES
 
+# gcc bug internal compiler error: in merge_overlapping_regs, at regrename.c:304
+ifeq ($(BR2_microblaze),y)
+VLC_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O0"
+VLC_CONF_OPTS += --disable-optimizations
+endif
+
 # VLC defines two autoconf functions which are also defined by our own pkg.m4
 # from pkgconf. Unfortunately, they are defined in a different way: VLC adds
 # --enable- options, but pkg.m4 adds --with- options. To make sure we use
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 vlc: workaround microblaze gcc internal compiler error

Hello,

Quoted 5 lines · Waldemar Brodkorb

Override gcc optimization flags with -O0.

The workaround is not required for gcc6 anymore, but gcc6 is disabled for microblaze, because it breaks startup of the system somehow. So the bug is not reported upstream.

If it's not required for gcc6, then perhaps we should add a BR2_TOOLCHAIN_GCC_AT_LEAST_6 condition, so that this chunk gets a chance to be removed at some point in the future.

package/vlc/vlc.mk VLC_AUTORECONF = YES · line 19

Quoted 2 lines
package/vlc/vlc.mk +2 -0
+# gcc bug internal compiler error: in merge_overlapping_regs, at regrename.c:304
+ifeq ($(BR2_microblaze),y)

I.e.:

ifeq ($(BR2_microblaze):$(BR2_TOOLCHAIN_GCC_AT_LEAST_6),y:)

package/vlc/vlc.mk VLC_AUTORECONF = YES · line 22

Quoted 3 lines
package/vlc/vlc.mk +3 -0
+VLC_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O0"
+VLC_CONF_OPTS += --disable-optimizations
+endif

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 vlc: workaround microblaze gcc internal compiler error

In reply to Waldemar Brodkorb

Hello,

Quoted 6 lines · Waldemar Brodkorb

Override gcc optimization flags with -O0.

The workaround is not required for gcc6 anymore, but gcc6 is disabled for microblaze, because it breaks startup of the system somehow. So the bug is not reported upstream.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/a318f0838a6a602046e719103ac81965c0084d52

---
 package/vlc/vlc.mk | 6 ++++++
 1 file changed, 6 insertions(+)

Applied to master after tweaking the condition so that it applies only to gcc < 6.x.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com