staging: speakup: Align with open parentheses
PATCH 1/2 staging: speakup: Align with open parentheses
Align next line of print statements
to the right of open parentheses.
--- drivers/staging/speakup/keyhelp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/speakup/keyhelp.c +2 -2
@@ -117,7 +117,7 @@ static void say_key(int key) }if ((key >0 ) && (key <= num_key_names))synth_printf (" %s\n" , -spk_msg_get (MSG_KEYNAMES_START + (key -1 ))); +spk_msg_get (MSG_KEYNAMES_START + (key -1 ))); }static int help_init (void )
@@ -182,7 +182,7 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key) name =NULL ;if ((type !=KT_SPKUP ) && (key >0 ) && (key <= num_key_names)) {synth_printf ("%s\n" , -spk_msg_get (MSG_KEYNAMES_START + key -1 )); +spk_msg_get (MSG_KEYNAMES_START + key -1 ));return 1 ; }for (i =0 ; funcvals[i] !=0 && !name; i++) {
Signature · 1 line
2.9.3
Quoted 13 lines · Sreya Mittal
Align next line of print statements
to the right of open parentheses.Signed-off-by Sreya Mittal <[email protected]>--- drivers/staging/speakup/keyhelp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/speakup/keyhelp.c +0
-0
drivers/staging/speakup/keyhelp.c static void say_key(int key) · line 118
Quoted 2 lines
drivers/staging/speakup/keyhelp.c +0
-0@@ -117,7 +117,7 @@ static void say_key(int key) }if ((key >0 ) && (key <= num_key_names))
It's not related to this change, but there are a lot of parentheses in the if tests that can be dropped.
julia
Quoted 25 lines
drivers/staging/speakup/keyhelp.c +2
-3synth_printf (" %s\n" , -spk_msg_get (MSG_KEYNAMES_START + (key -1 ))); +spk_msg_get (MSG_KEYNAMES_START + (key -1 ))); }static int help_init (void )@@ -182,7 +182,7 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key) name =NULL ;if ((type !=KT_SPKUP ) && (key >0 ) && (key <= num_key_names)) {synth_printf ("%s\n" , -spk_msg_get (MSG_KEYNAMES_START + key -1 )); +spk_msg_get (MSG_KEYNAMES_START + key -1 ));return 1 ; }for (i =0 ; funcvals[i] !=0 && !name; i++) { --2.9.3
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170227151124.18063-1-sreyamittal5%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 25 lines · Julia Lawall
Review
Quoted 9 lines · Sreya Mittal
Align next line of print statements
to the right of open parentheses.Signed-off-by Sreya Mittal <[email protected] <javascript:>>---
drivers/staging/speakup/keyhelp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/staging/speakup/keyhelp.cdrivers/staging/speakup/keyhelp.c static void say_key(int key) · line 118
Quoted 6 lines
index ce94cb1..f5156bb 100644
drivers/staging/speakup/keyhelp.c +0
-0@@ -117,7 +117,7 @@ static void say_key(int key) }if ((key >0 ) && (key <= num_key_names))It's not related to this change, but there are a lot of parentheses in the if tests that can be dropped.
Quoted 2 lines
julia
Ok. I will make the changes and send again.
Sreya
Quoted 38 lines
drivers/staging/speakup/keyhelp.c static void say_key(int key) · line 120
Quoted 3 lines
drivers/staging/speakup/keyhelp.c +0
-1synth_printf(" %s\n", - spk_msg_get(MSG_KEYNAMES_START + (key -1)));
drivers/staging/speakup/keyhelp.c static void say_key(int key) · line 120
Quoted 1 line
drivers/staging/speakup/keyhelp.c +1
-0+ spk_msg_get(MSG_KEYNAMES_START + (key -1)));
drivers/staging/speakup/keyhelp.c int spk_handle_help(struct vc_data *vc, u_char type,
Quoted 4 lines
drivers/staging/speakup/keyhelp.c +0
-0}static int help_init (void )@@ -182,7 +182,7 @@ int spk_handle_help(struct vc_data *vc, u_char type,
u_charch,u_shortkey)drivers/staging/speakup/keyhelp.c int spk_handle_help(struct vc_data *vc, u_char type, · line 183
Quoted 2 lines
drivers/staging/speakup/keyhelp.c +0
-0name =NULL ; if ((type != KT_SPKUP) && (key > 0) && (key <=
num_key_names)) {drivers/staging/speakup/keyhelp.c int spk_handle_help(struct vc_data *vc, u_char type, · line 185
Quoted 2 lines
drivers/staging/speakup/keyhelp.c +0
-1synth_printf("%s\n", - spk_msg_get(MSG_KEYNAMES_START + key -1));
drivers/staging/speakup/keyhelp.c int spk_handle_help(struct vc_data *vc, u_char type, · line 185
Quoted 1 line
drivers/staging/speakup/keyhelp.c +1
-0+ spk_msg_get(MSG_KEYNAMES_START +key - 1));
Quoted 8 lines
drivers/staging/speakup/keyhelp.c +0
-0return 1 ; }for (i =0 ; funcvals[i] !=0 && !name; i++) {Signature · 4 lines
2.9.3 -- You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <javascript:>.
Quoted 1 line
To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20170227151124.18063-1-sreyamittal5%40gmail.com.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.
Quoted 24 lines · Sreya Mittal
On Monday, February 27, 2017 at 8:45:31 PM UTC+5:30, Julia Lawall wrote:
On Mon, 27 Feb 2017, Sreya Mittal wrote:
> Align next line of print statements
> to the right of open parentheses.
>
> Signed-off-by: Sreya Mittal <[email protected]> > ---
> drivers/staging/speakup/keyhelp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
> diff --gita/drivers/staging/speakup/keyhelp.cb/drivers/staging/speakup/keyhelp.c
> index ce94cb1..f5156bb 100644
> ---a/drivers/staging/speakup/keyhelp.c> +++b/drivers/staging/speakup/keyhelp.c> @@ -117,7 +117,7 @@ static voidsay_key(int key)> }
> if ((key > 0) && (key <=num_key_names))
Quoted 8 lines
It's not related to this change, but there are a lot of parentheses in
the if tests that can be dropped.julia
Ok. I will make the changes and send again.
It's not for the same patch. You can make a series, though.
julia
Quoted 53 lines
Sreya
> synth_printf(" %s\n", > - spk_msg_get(MSG_KEYNAMES_START + (key - 1))); > + spk_msg_get(MSG_KEYNAMES_START + (key - 1))); > } > > static int help_init(void) > @@ -182,7 +182,7 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key) > name = NULL; > if ((type != KT_SPKUP) && (key > 0) && (key <= num_key_names)) { > synth_printf("%s\n", > - spk_msg_get(MSG_KEYNAMES_START + key - 1)); > + spk_msg_get(MSG_KEYNAMES_START + key - 1)); > return 1; > } > for (i = 0; funcvals[i] != 0 && !name; i++) { > -- > 2.9.3 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170227151124.18063-1-s reyamittal5%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/9955a49f-05fa-4a47-8999- 175c54069811%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.