Skip to contentSkip to conversation

scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.

bug report Dan Carpenter 1 participant 1 message Feb 27, 2017 SCSI

lore
Share & tools
lore
#0 lore raw

Hello Dupuis, Chad,

This is a semi-automatic email about new static checker warnings.

The patch 61d8658b4a43: "scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework." from Feb 15, 2017, leads to the following Smatch complaint:

drivers/scsi/qedf/qedf_main.c:1565 qedf_vport_destroy()

	 warn: variable dereferenced before check 'vn_port->host' (see line 1551)

drivers/scsi/qedf/qedf_main.c
1550 /* Detach from scsi-ml */

  1551		fc_remove_host(vn_port->host);
                               ^^^^^^^^^^^^^

Dereferenced inside function.

1552 scsi_remove_host(vn_port->host);
1553
1554 /*
1555 * Only try to release the exchange manager if the vn_port
1556 * configuration is complete.
1557 */
1558 if (vn_port->state == LPORT_ST_READY)
1559 fc_exch_mgr_free(vn_port);
1560
1561 /* Free memory used by statistical counters */
1562 fc_lport_free_stats(vn_port);
1563
1564 /* Release Scsi_Host */
1565 if (vn_port->host)

                    ^^^^^^^^^^^^^

Too late.

  1566			scsi_host_put(vn_port->host);
  1567	

regards,
dan carpenter