Skip to contentSkip to conversation

staging: dgnc: replace udelay with usleep_range

PATCH New Aishwarya Pant 1 participant 1 message Feb 27, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 staging: dgnc: replace udelay with usleep_range

Fix checkpatch warning on dgnc_cls.c: CHECK usleep_range is preferred over udelay. udelay(t) in function cls_uart_init is within non-atomic context and can be safely replaced by usleep_range(t, t + delta) where delta is t (as t is between 10 and 20 microseconds).

---
Changes in v5:
- Breakup the patch to handle one cleanup
Changes in v4:
- Fix commit message formatting
Changes in v3:
- Replace usleep_range by udelay in cls_flush_uart_write
- Fix diff in commit message
Changes in v2:
- Revert usage of usleep_range in atomic context
- Cleanup the commit message

 drivers/staging/dgnc/dgnc_cls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_cls.c +1 -1
index c20ffdd..28a3e16 100644
@@ -1096,7 +1096,7 @@ static void cls_uart_init(struct channel_t *ch)
 
 	writeb(UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT,
 	       &ch->ch_cls_uart->isr_fcr);
-	udelay(10);
+	usleep_range(10, 20);
 
 	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
 
Signature · 1 line
2.7.4