block/mirror: fix broken sparseness detection
PATCH 1/1 block/mirror: fix broken sparseness detection
int64_t is in all likelihood the actual scalar type we want. Yep, really.
Signed-off-by John Snow <[email protected]>
--- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
block/mirror.c +1 -1
@@ -386,7 +386,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) nb_chunks * sectors_per_chunk);bitmap_set (s->in_flight_bitmap, sector_num / sectors_per_chunk, nb_chunks);while (nb_chunks >0 && sector_num < end) { -int ret; +int64_t ret;int io_sectors, io_sectors_acct;BlockDriverState *file; enum MirrorMethod {
Signature · 1 line
2.9.3
Quoted 26 lines · John Snow
int64_tis in all likelihood the actual scalar type we want. Yep, really.Signed-off-by John Snow <[email protected]>--- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)block/mirror.c +1
-1@@ -386,7 +386,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) nb_chunks * sectors_per_chunk);bitmap_set (s->in_flight_bitmap, sector_num / sectors_per_chunk, nb_chunks);while (nb_chunks >0 && sector_num < end) { -int ret; +int64_t ret;int io_sectors, io_sectors_acct;BlockDriverState *file; enum MirrorMethod {Signature · 1 line
2.9.3
Reviewed-by Jeff Cody <[email protected]>
Jeff Cody
AppliedQuoted 26 lines · John Snow
int64_tis in all likelihood the actual scalar type we want. Yep, really.Signed-off-by John Snow <[email protected]>--- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)block/mirror.c +1
-1@@ -386,7 +386,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) nb_chunks * sectors_per_chunk);bitmap_set (s->in_flight_bitmap, sector_num / sectors_per_chunk, nb_chunks);while (nb_chunks >0 && sector_num < end) { -int ret; +int64_t ret;int io_sectors, io_sectors_acct;BlockDriverState *file; enum MirrorMethod {Signature · 1 line
2.9.3
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc.git block
-Jeff