Skip to contentSkip to conversation

mfd: Add Cherrytrail WhiskeyCove PMIC driver

PATCH In review Hans de Goede 2 participants 3 messages Feb 27, 2017 – Feb 28, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mfd: Add Cherrytrail WhiskeyCove PMIC driver

Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal version which implements just enough to get ACPI PMIC opregion support to work, so that suspend/resume will work on machines with this PMIC.

Cc Bin Gao <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc Andy Shevchenko <[email protected]>

---
Changes in v2:
-Since this uses plain mfd and not the intel_soc_pmic stuff give it
its own Kconfig and allow this to be built as a module
-Add missing #include <acpi/acpi_bus.h>

---
 drivers/mfd/Kconfig                |  11 +++
 drivers/mfd/Makefile               |   1 +
 drivers/mfd/intel_soc_pmic_chtwc.c | 176 +++++++++++++++++++++++++++++++++++++
 include/linux/mfd/intel_chtwc.h    |  75 ++++++++++++++++
 4 files changed, 263 insertions(+)
 create mode 100644 drivers/mfd/intel_soc_pmic_chtwc.c
 create mode 100644 include/linux/mfd/intel_chtwc.h
drivers/mfd/Kconfig +11 -0
index 4ce3b6f..98c38aa 100644
@@ -436,6 +436,17 @@ config INTEL_SOC_PMIC
 	  thermal, charger and related power management functions
 	  on these systems.
 
+config MFD_INTEL_CHT_WC
+	tristate "Support for Intel Cherry Trail Whiskey Cove PMIC"
+	depends on ACPI
+	depends on I2C
+	select MFD_CORE
+	select REGMAP_I2C
+	select REGMAP_IRQ
+	help
+	  Select this option to enable support for the Intel Cherry Trail
+	  Whiskey Cove PMIC found on some Intel Cherry Trail systems.
+
 config MFD_INTEL_LPSS
 	tristate
 	select COMMON_CLK
drivers/mfd/Makefile +1 -0
index dda4d4f..664cb81 100644
@@ -204,6 +204,7 @@ obj-$(CONFIG_MFD_HI655X_PMIC)   += hi655x-pmic.o
 obj-$(CONFIG_MFD_DLN2)		+= dln2.o
 obj-$(CONFIG_MFD_RT5033)	+= rt5033.o
 obj-$(CONFIG_MFD_SKY81452)	+= sky81452.o
+obj-$(CONFIG_MFD_INTEL_CHT_WC)	+= intel_soc_pmic_chtwc.o
 
 intel-soc-pmic-objs		:= intel_soc_pmic_core.o intel_soc_pmic_crc.o
 intel-soc-pmic-$(CONFIG_INTEL_PMC_IPC)	+= intel_soc_pmic_bxtwc.o
drivers/mfd/intel_soc_pmic_chtwc.c new file +176 -0

176 lines not on this page · raw message

include/linux/mfd/intel_chtwc.h new file +75 -0

75 lines not on this page · raw message

Signature · 1 line
2.9.3
#1 lore raw
Quoted 11 lines · Hans de Goede

Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal version which implements just enough to get ACPI PMIC opregion support to work, so that suspend/resume will work on machines with this PMIC.

Cc Bin Gao <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc Andy Shevchenko <[email protected]>

---
Changes in v2:

You were too fast. Please, give a time for reviewers to do their job.

So, please address comments per v2 first.

Review

Quoted 4 lines
(quoted diff) +0 -2
-Since this uses plain mfd and not the intel_soc_pmic stuff give it
 its own Kconfig and allow this to be built as a module
 
-Add missing #include <acpi/acpi_bus.h>

Do we need it explicitly included?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

Hi,

Quoted 15 lines · Andy Shevchenko
Quoted 11 lines · Hans de Goede

Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal version which implements just enough to get ACPI PMIC opregion support to work, so that suspend/resume will work on machines with this PMIC.

Cc Bin Gao <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc Andy Shevchenko <[email protected]>

---
Changes in v2:

You were too fast. Please, give a time for reviewers to do their job.

Quoted 8 lines

So, please address comments per v2 first.

Review

Quoted 4 lines
(quoted diff) +0 -2
-Since this uses plain mfd and not the intel_soc_pmic stuff give it
 its own Kconfig and allow this to be built as a module
 
-Add missing #include <acpi/acpi_bus.h>

Do we need it explicitly included?

I was trying to fix a kbuild bot error with this (Takashi has it on a topic-branch), but it only made it worse. so I'm dropping this again for v3, instead adding "depends on ACPI" to the Kconfig for this, which will hopefully really fix the kbuild bot errors.

Regards,

Hans