Skip to contentSkip to conversation

assimp: work around gcc bug on SuperH

PATCH New Thomas Petazzoni 1 participant 2 messages Feb 26, 2017 – Feb 27, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 assimp: work around gcc bug on SuperH

gcc versions earlier than gcc 6.x fail to build assimp on SuperH when static linking:

AssxmlExporter.cpp:623:1: error: unable to find a register to spill in class 'GENERAL_REGS'

It's the combination of -Os and *not* having -fPIC that makes gcc fail, which explains why configurations with dynamic linking work fine.

-Os -fPIC -> works
-Os -> fails
-O2 -fPIC -> works
-O2 -> works

Therefore, as a workaround, we are forcing the use of -O2 on SuperH when the gcc version is older than gcc 6.x and we're statically linking.

Fixes:

http://autobuild.buildroot.net/results/ec88aa8118179e30e24603cc45292047dca19216/

---
 package/assimp/assimp.mk | 8 ++++++++
 1 file changed, 8 insertions(+)
package/assimp/assimp.mk +8 -0
index 08893ff..298e121 100644
@@ -16,6 +16,14 @@ ifeq ($(BR2_m68k),y)
 ASSIMP_CXXFLAGS += -mxgot
 endif
 
+# workaround SuperH compiler failure when static linking (i.e -fPIC is
+# not passed) in gcc versions 5.x or older. The -Os optimization level
+# causes a "unable to find a register to spill in class
+# ?GENERAL_REGS?" error. -O2 works fine.
+ifeq ($(BR2_sh):$(BR2_STATIC_LIBS):$(BR2_HOST_GCC_AT_LEAST_6),y:y:)
+ASSIMP_CXXFLAGS += -O2
+endif
+
 ASSIMP_CONF_OPTS += -DASSIMP_BUILD_TESTS=OFF \
 	-DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) $(ASSIMP_CXXFLAGS)"
 
Signature · 1 line
2.7.4
author Applied
#1 lore raw

PATCH 1/1 assimp: work around gcc bug on SuperH

Hello,

Quoted 18 lines · Thomas Petazzoni

gcc versions earlier than gcc 6.x fail to build assimp on SuperH when static linking:

AssxmlExporter.cpp:623:1: error: unable to find a register to spill in class 'GENERAL_REGS'

It's the combination of -Os and *not* having -fPIC that makes gcc fail, which explains why configurations with dynamic linking work fine.

-Os -fPIC -> works
-Os -> fails
-O2 -fPIC -> works
-O2 -> works

Therefore, as a workaround, we are forcing the use of -O2 on SuperH when the gcc version is older than gcc 6.x and we're statically linking.

Quoted 8 lines

Fixes:

http://autobuild.buildroot.net/results/ec88aa8118179e30e24603cc45292047dca19216/

---
 package/assimp/assimp.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com