drm/via: use get_user_pages_unlocked()
Subsystems (3)
PATCH RESEND 1/1 drm/via: use get_user_pages_unlocked()
Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code and takes advantage of VM_FAULT_RETRY functionality when faulting in pages.
--- drivers/gpu/drm/via/via_dmablit.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/gpu/drm/via/via_dmablit.c +3 -7
@@ -238,13 +238,9 @@ via_lock_all_dma_pages(drm_via_sg_info_t *vsg, drm_via_dmablit_t *xfer) vsg->pages =vzalloc (sizeof (struct page *) * vsg->num_pages);if (NULL == vsg->pages)return -ENOMEM ; -down_read (¤t->mm->mmap_sem); - ret =get_user_pages ((unsigned long )xfer->mem_addr, - vsg->num_pages, - (vsg->direction ==DMA_FROM_DEVICE ) ?FOLL_WRITE :0 , - vsg->pages,NULL ); - -up_read (¤t->mm->mmap_sem); + ret =get_user_pages_unlocked ((unsigned long )xfer->mem_addr, + vsg->num_pages, vsg->pages, + (vsg->direction ==DMA_FROM_DEVICE ) ?FOLL_WRITE :0 );if (ret != vsg->num_pages) {if (ret <0 )return ret;
Signature · 7 lines
2.11.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Daniel Vetter
AppliedQuoted 4 lines · Lorenzo Stoakes
Moving from
get_user_pages()toget_user_pages_unlocked()simplifies the code and takes advantage ofVM_FAULT_RETRYfunctionality when faulting in pages.Signed-off-by Lorenzo Stoakes <[email protected]>
Queued for 4.12, thanks for the patch.
-Daniel
Quoted 28 lines
--- drivers/gpu/drm/via/via_dmablit.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)drivers/gpu/drm/via/via_dmablit.c +3
-7@@ -238,13 +238,9 @@ via_lock_all_dma_pages(drm_via_sg_info_t *vsg, drm_via_dmablit_t *xfer) vsg->pages =vzalloc (sizeof (struct page *) * vsg->num_pages);if (NULL == vsg->pages)return -ENOMEM ; -down_read (¤t->mm->mmap_sem); - ret =get_user_pages ((unsigned long )xfer->mem_addr, - vsg->num_pages, - (vsg->direction ==DMA_FROM_DEVICE ) ?FOLL_WRITE :0 , - vsg->pages,NULL ); - -up_read (¤t->mm->mmap_sem); + ret =get_user_pages_unlocked ((unsigned long )xfer->mem_addr, + vsg->num_pages, vsg->pages, + (vsg->direction ==DMA_FROM_DEVICE ) ?FOLL_WRITE :0 );if (ret != vsg->num_pages) {if (ret <0 )return ret;Signature · 1 line
2.11.1
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 3 lines · Daniel Vetter
drivers/gpu/drm/via/via_dmablit.c via_lock_all_dma_pages(drm_via_sg_info_t *vsg, drm_via_dmablit_t *xfer) · line 243
Quoted 3 lines
drivers/gpu/drm/via/via_dmablit.c +3
-0+ ret =get_user_pages_unlocked ((unsigned long )xfer->mem_addr, + vsg->num_pages, vsg->pages, + (vsg->direction ==DMA_FROM_DEVICE ) ?FOLL_WRITE :0 );
Umm... Why not
ret = get_user_pages_fast((unsigned long)xfer->mem_addr, vsg->num_pages, vsg->direction == DMA_FROM_DEVICE, vsg->pages);
IOW, do you really need a warranty that ->mmap_sem will be grabbed and released?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 6 lines · Al Viro
Quoted 3 lines · Daniel Vetter
drivers/gpu/drm/via/via_dmablit.c via_lock_all_dma_pages(drm_via_sg_info_t *vsg, drm_via_dmablit_t *xfer) · line 243
Quoted 3 lines
drivers/gpu/drm/via/via_dmablit.c +3
-0+ ret =get_user_pages_unlocked ((unsigned long )xfer->mem_addr, + vsg->num_pages, vsg->pages, + (vsg->direction ==DMA_FROM_DEVICE ) ?FOLL_WRITE :0 );
Quoted 8 lines
Umm... Why not
ret = get_user_pages_fast((unsigned long)xfer->mem_addr, vsg->num_pages, vsg->direction == DMA_FROM_DEVICE, vsg->pages);IOW, do you really need a warranty that ->mmap_sem will be grabbed and released?
Daniel will be better placed to answer in this specific case, but more generally is there any reason why we can't just use get_user_pages_fast() in all such cases? These patches were simply a mechanical/cautious replacement for code that is more or less exactly equivalent but if this would make sense perhaps it'd be worth using gup_fast() where possible?
Signature · 8 lines
Lorenzo Stoakes https://ljs.io -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 16 lines · Lorenzo Stoakes
Quoted 6 lines · Al Viro
Quoted 3 lines · Daniel Vetter
drivers/gpu/drm/via/via_dmablit.c via_lock_all_dma_pages(drm_via_sg_info_t *vsg, drm_via_dmablit_t *xfer) · line 243
Quoted 3 lines
drivers/gpu/drm/via/via_dmablit.c +3
-0+ ret =get_user_pages_unlocked ((unsigned long )xfer->mem_addr, + vsg->num_pages, vsg->pages, + (vsg->direction ==DMA_FROM_DEVICE ) ?FOLL_WRITE :0 );Quoted 8 lines
Umm... Why not
ret = get_user_pages_fast((unsigned long)xfer->mem_addr, vsg->num_pages, vsg->direction == DMA_FROM_DEVICE, vsg->pages);IOW, do you really need a warranty that ->mmap_sem will be grabbed and released?
Quoted 6 lines
Daniel will be better placed to answer in this specific case, but more generally is there any reason why we can't just use
get_user_pages_fast()in all such cases? These patches were simply a mechanical/cautious replacement for code that is more or less exactly equivalent but if this would make sense perhaps it'd be worth usinggup_fast()where possible?
I have no idea. drm/via is unmaintained, it's a dri1 racy driver with problems probably everywhere, and I'm not sure we even have someone left who cares (there's an out-of-tree kms conversion of via, but it's stuck since years).
In short, it's the drm dungeons and the only reason I merge patches is to give people an easy target for test driving the patch submission process to dri-devel. And to avoid drm being a blocker for tree-wide refactorings. Otherwise 0 reasons to change anything here.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel