usb: gadget: configs: plug memory leak
PATCH 1/1 usb: gadget: configs: plug memory leak
When binding a gadget to a device, "name" is stored in gi->udc_name, but this does not happen when unregistering and the string is leaked.
Signed-off-by John Keeping <[email protected]>
--- drivers/usb/gadget/configfs.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/gadget/configfs.c +1 -0
@@ -269,6 +269,7 @@ static ssize_t gadget_dev_desc_UDC_store(struct config_item *item, ret =unregister_gadget (gi);if (ret) goto err; +kfree (name); }else {if (gi->composite.gadget_driver.udc_name) { ret = -EBUSY ;
Signature · 1 line
2.12.0.rc2.230.ga28edc07cd.dirty
Quoted 13 lines · John Keeping
When binding a gadget to a device, "name" is stored in
gi->udc_name, but this does not happen when unregistering and the string is leaked.Signed-off-by John Keeping <[email protected]>--- drivers/usb/gadget/configfs.c | 1 + 1 file changed, 1 insertion(+)drivers/usb/gadget/configfs.c +0
-0
drivers/usb/gadget/configfs.c static ssize_t gadget_dev_desc_UDC_store(struct config_item *item, · line 272
Quoted 4 lines
drivers/usb/gadget/configfs.c +1
-0@@ -269,6 +269,7 @@ static ssize_t gadget_dev_desc_UDC_store(struct config_item *item, ret =unregister_gadget (gi);if (ret) goto err; +kfree (name);
Looks correct to me.
Suzuki